From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
jcody@redhat.com, Fam Zheng <famz@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
Date: Tue, 4 Mar 2014 14:25:31 +0000 [thread overview]
Message-ID: <CAFEAcA_q9AWWY9xgmohphZ61SFd_nTpwDyGJvyqAzxyHS2QtMg@mail.gmail.com> (raw)
In-Reply-To: <5315D6A3.1060601@weilnetz.de>
On 4 March 2014 13:35, Stefan Weil <sw@weilnetz.de> wrote:
> Am 27.02.2014 21:28, schrieb Stefan Weil:
>> Comment from Makefile.objs:
>>
>> # block-obj-y is code used by both qemu system emulation and qemu-img
>
>
> Hello Peter,
>
> the comment which I cited above got lost when you applied the patch to
> QEMU master (maybe because it started with a #).
Yes, probably happened as part of a 'git commit --amend' when I
added my signoff. Probably best to avoid starting lines in commit
messages with a '#' :-)
thanks
-- PMM
prev parent reply other threads:[~2014-03-04 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 20:28 [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build) Stefan Weil
2014-03-04 12:55 ` Paolo Bonzini
2014-03-04 13:10 ` Peter Maydell
2014-03-04 13:35 ` Stefan Weil
2014-03-04 14:25 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_q9AWWY9xgmohphZ61SFd_nTpwDyGJvyqAzxyHS2QtMg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).