* [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
@ 2014-02-27 20:28 Stefan Weil
2014-03-04 12:55 ` Paolo Bonzini
2014-03-04 13:35 ` Stefan Weil
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Weil @ 2014-02-27 20:28 UTC (permalink / raw)
To: qemu-devel, Peter Maydell; +Cc: Stefan Weil, jcody, famz
Comment from Makefile.objs:
# block-obj-y is code used by both qemu system emulation and qemu-img
The system emulation needs this dependency (which was missing in Makefile),
otherwise builds without tools (or massive parallel builds) fail.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index a28a3c8..a0dafbf 100644
--- a/Makefile
+++ b/Makefile
@@ -159,6 +159,7 @@ qemu-options.def: $(SRC_PATH)/qemu-options.hx
SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
+$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
$(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
subdir-%:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
2014-02-27 20:28 [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build) Stefan Weil
@ 2014-03-04 12:55 ` Paolo Bonzini
2014-03-04 13:10 ` Peter Maydell
2014-03-04 13:35 ` Stefan Weil
1 sibling, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2014-03-04 12:55 UTC (permalink / raw)
To: Stefan Weil, qemu-devel, Peter Maydell; +Cc: jcody, famz
Il 27/02/2014 21:28, Stefan Weil ha scritto:
> Comment from Makefile.objs:
>
> # block-obj-y is code used by both qemu system emulation and qemu-img
>
> The system emulation needs this dependency (which was missing in Makefile),
> otherwise builds without tools (or massive parallel builds) fail.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index a28a3c8..a0dafbf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,6 +159,7 @@ qemu-options.def: $(SRC_PATH)/qemu-options.hx
> SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
> SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>
> +$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
> $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
>
> subdir-%:
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
2014-03-04 12:55 ` Paolo Bonzini
@ 2014-03-04 13:10 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2014-03-04 13:10 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Stefan Weil, jcody, Fam Zheng, QEMU Developers
On 4 March 2014 12:55, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 27/02/2014 21:28, Stefan Weil ha scritto:
>
>> Comment from Makefile.objs:
>>
>> # block-obj-y is code used by both qemu system emulation and qemu-img
>>
>> The system emulation needs this dependency (which was missing in
>> Makefile),
>> otherwise builds without tools (or massive parallel builds) fail.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index a28a3c8..a0dafbf 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -159,6 +159,7 @@ qemu-options.def: $(SRC_PATH)/qemu-options.hx
>> SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
>> SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>>
>> +$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
>> $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
>>
>> subdir-%:
>>
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
2014-02-27 20:28 [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build) Stefan Weil
2014-03-04 12:55 ` Paolo Bonzini
@ 2014-03-04 13:35 ` Stefan Weil
2014-03-04 14:25 ` Peter Maydell
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Weil @ 2014-03-04 13:35 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, jcody, famz, qemu-devel
Am 27.02.2014 21:28, schrieb Stefan Weil:
> Comment from Makefile.objs:
>
> # block-obj-y is code used by both qemu system emulation and qemu-img
Hello Peter,
the comment which I cited above got lost when you applied the patch to
QEMU master (maybe because it started with a #).
Regards
Stefan
>
> The system emulation needs this dependency (which was missing in Makefile),
> otherwise builds without tools (or massive parallel builds) fail.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)
2014-03-04 13:35 ` Stefan Weil
@ 2014-03-04 14:25 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2014-03-04 14:25 UTC (permalink / raw)
To: Stefan Weil; +Cc: Paolo Bonzini, jcody, Fam Zheng, QEMU Developers
On 4 March 2014 13:35, Stefan Weil <sw@weilnetz.de> wrote:
> Am 27.02.2014 21:28, schrieb Stefan Weil:
>> Comment from Makefile.objs:
>>
>> # block-obj-y is code used by both qemu system emulation and qemu-img
>
>
> Hello Peter,
>
> the comment which I cited above got lost when you applied the patch to
> QEMU master (maybe because it started with a #).
Yes, probably happened as part of a 'git commit --amend' when I
added my signoff. Probably best to avoid starting lines in commit
messages with a '#' :-)
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-04 14:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-27 20:28 [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build) Stefan Weil
2014-03-04 12:55 ` Paolo Bonzini
2014-03-04 13:10 ` Peter Maydell
2014-03-04 13:35 ` Stefan Weil
2014-03-04 14:25 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).