From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47584)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Uguby-00075s-MN
	for qemu-devel@nongnu.org; Mon, 27 May 2013 06:25:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Ugubv-00073U-0M
	for qemu-devel@nongnu.org; Mon, 27 May 2013 06:25:06 -0400
Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:64646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Ugubu-00071I-QC
	for qemu-devel@nongnu.org; Mon, 27 May 2013 06:25:02 -0400
Received: by mail-la0-f43.google.com with SMTP id ez20so6360115lab.16
	for <qemu-devel@nongnu.org>; Mon, 27 May 2013 03:25:01 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1369635195-28279-1-git-send-email-aik@ozlabs.ru>
References: <1369635195-28279-1-git-send-email-aik@ozlabs.ru>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 27 May 2013 11:24:41 +0100
Message-ID: <CAFEAcA_qOtFuVPem2mbK7TmM4rac-ZVmdn8HYRnkHPx5iiPSOg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On 27 May 2013 07:13, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> QEMU uses headers from source directory, however the "asm" symlink was
> created in the build directory what broke KVM stuff compilation.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..9c3c5e5 100755
> --- a/configure
> +++ b/configure
> @@ -4135,7 +4135,7 @@ if test "$linux" = "yes" ; then
>    esac
>      # For non-KVM architectures we will not have asm headers
>      if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then
> -      symlink "$source_path/linux-headers/asm-$linux_arch" linux-headers/asm
> +      symlink "$source_path/linux-headers/asm-$linux_arch" $source_path/linux-headers/asm

This is definitely wrong -- the asm symlink must be created
in the build tree, because you could have two build trees
which are building for different architectures and need
different symlink targets. (More generally, an out of tree
build should never create files in the source tree, because
the point of out of tree builds is to leave the source tree
in a pristine state.)

What is the actual bug here? QEMU builds fine for me, because
the build directory is also in the include path via "-I.".

thanks
-- PMM