From: Peter Maydell <peter.maydell@linaro.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Andrew Jones <drjones@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space
Date: Tue, 13 Oct 2015 13:33:25 +0100 [thread overview]
Message-ID: <CAFEAcA_qW8DjJiYzuYy1_cuuOw9rWiscBmb4gyK55pUXsmFPJA@mail.gmail.com> (raw)
In-Reply-To: <20151013124837.GA27387@agordeev.usersys.redhat.com>
On 13 October 2015 at 13:48, Alexander Gordeev <agordeev@redhat.com> wrote:
> On Tue, Oct 13, 2015 at 09:16:34AM +0100, Peter Maydell wrote:
>> In any case, setting pci_allow_0_address is the right thing,
>> so we can just change the commit message in this patch.
>
> I will post v2 with an updated changelog then.
>
>> Incidentally, why is this a property on the machine
>> and not on the PCI controller device?
>
> I am CC-ing Laurent Vivier who introduced the flag.
>
> But IMO it *is* a machine property, not PCI controller's
> one, unless I am missing something.
I think "does this PCI controller handle BARs with
zero addresses, or does it treat them as if the BAR
was unmapped" is definitely a controller property...
you might have in theory a machine with two PCI
controllers, one of which could deal with zero-addresses
and one of which could not.
thanks
-- PMM
next prev parent reply other threads:[~2015-10-13 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 20:55 [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space Alexander Gordeev
2015-10-12 21:03 ` Peter Maydell
2015-10-13 6:31 ` Alexander Gordeev
2015-10-13 8:16 ` Peter Maydell
2015-10-13 12:48 ` Alexander Gordeev
2015-10-13 12:33 ` Peter Maydell [this message]
2015-10-13 12:47 ` Laurent Vivier
2015-10-13 13:04 ` Michael S. Tsirkin
2015-10-13 13:12 ` Peter Maydell
2015-10-13 13:19 ` Michael S. Tsirkin
2015-10-13 13:25 ` Peter Maydell
2015-10-13 13:55 ` Peter Maydell
2015-10-16 8:52 ` Laurent Vivier
2015-10-16 9:13 ` Michael S. Tsirkin
2015-10-16 9:32 ` Peter Maydell
2015-10-16 9:59 ` Laurent Vivier
2015-10-13 14:35 ` [Qemu-devel] [PATCH v2] " Alexander Gordeev
2015-10-13 17:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_qW8DjJiYzuYy1_cuuOw9rWiscBmb4gyK55pUXsmFPJA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agordeev@redhat.com \
--cc=drjones@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).