From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Ya4mC-0007Dk-MB
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:00:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Ya4m6-0002PC-Re
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:00:28 -0400
Received: from mail-ie0-f169.google.com ([209.85.223.169]:36323)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Ya4m6-0002P7-OA
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:00:22 -0400
Received: by iedm5 with SMTP id m5so39213589ied.3
	for <qemu-devel@nongnu.org>; Mon, 23 Mar 2015 09:00:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5510359F.8080400@redhat.com>
References: <CAFEAcA-8AmagfK1NBE02J7kLEvVNdcm_oRbEmJpWAArL-2jc2Q@mail.gmail.com>
	<55102594.6000902@redhat.com>
	<CAFEAcA9jnHpn4AF9FsQ7gT6n0MAEV018gkLcoV5i9TnwVXS0_A@mail.gmail.com>
	<55102EB4.6010106@redhat.com>
	<CAFEAcA9BooQqH3K8xKrHH2w9A0MqbeSJCw=5iTg2b9bpNKG0gA@mail.gmail.com>
	<551030F7.6030702@redhat.com>
	<CAFEAcA9cOcEBUuEvThGbdX-Vda-hAJHgorAEdECy72qTiuahrA@mail.gmail.com>
	<5510359F.8080400@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 23 Mar 2015 16:00:02 +0000
Message-ID: <CAFEAcA_r3_b3z34nMQ9GCTXYDhd8qLASpQHMFDVJ-4nN4R+_QQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] RFC: memory API changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Greg Bellows <greg.bellows@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On 23 March 2015 at 15:47, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Ok, so most ld*_phys users are already using cs->as.

But this is only because when the AddressSpace* argument
to ld*_phys was introduced we made it be cs->as for
existing callers, to retain the existing behaviour.
That doesn't mean that callers using cs->as are doing
the right thing. In general I would expect that any
caller that's not part of the CPU itself should not be
rummaging around inside the CPU struct to find an
AddressSpace to use...

-- PMM