qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Nowadays alsa and pulseaudio are most often the default soundsystem. When the headerfiles are found, enable the build of the alsa and pulseaudio audio driver for the default targetos.
Date: Thu, 1 May 2014 14:06:27 +0100	[thread overview]
Message-ID: <CAFEAcA_sGaVwAGMCtFpi_j6oopzGJnxBexcTSQ3_JDYcLxFPJQ@mail.gmail.com> (raw)
In-Reply-To: <338138618.20140501145639@eikelenboom.it>

On 1 May 2014 13:56, Sander Eikelenboom <linux@eikelenboom.it> wrote:
> Thursday, May 1, 2014, 1:06:35 PM, you wrote:
>> This is a lower-quality duplicate of the code we already
>> have in configure for probing whether an audio backend
>> is present (for instance it doesn't allow for the possibility
>> that the headers have been installed elsewhere). It would
>> be better to update the existing probe code to distinguish
>> between "must be present", "don't use" and "use if present"
>> for each audio driver, in the same way we do for other
>> features. Then we could just set the default list here
>> to "maybe-pa maybe-alsa oss" (syntax off the top of my
>> head, feel free to have a better idea).
>
> How bad would it be for the generic targetos case to start with:
>
> audio_drv_list == audio_possible_drivers = "oss alsa sdl esd pa"
>
> or just add the probably most used two:
> audio_drv_list = "oss alsa pa"
>
> and just let the auto probing do it's business ?

At the moment if you put something in audio_drv_list
then configure will stop with an error if that driver
can't be probed. So putting 'pa' or 'alsa' in the
default list is a bad idea, because people whose setups
worked fine for building qemu will suddenly find they
stop working.

We need both behaviours -- distributions want to be able
to say "build with pulseaudio" and have the build fail
if their pulseaudio dependencies aren't set up correctly
rather than silently produce a package which won't work
in their distro. But the average person building QEMU
for their own use generally would prefer "probe for the
features but if they're not present then just don't
build the code that uses them".

thanks
-- PMM

  reply	other threads:[~2014-05-01 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 10:56 [Qemu-devel] [PATCH] Nowadays alsa and pulseaudio are most often the default soundsystem. When the headerfiles are found, enable the build of the alsa and pulseaudio audio driver for the default targetos Sander Eikelenboom
2014-05-01 11:06 ` Peter Maydell
2014-05-01 12:56   ` Sander Eikelenboom
2014-05-01 13:06     ` Peter Maydell [this message]
2014-05-01 13:16       ` Sander Eikelenboom
2014-05-01 12:07 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_sGaVwAGMCtFpi_j6oopzGJnxBexcTSQ3_JDYcLxFPJQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=linux@eikelenboom.it \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).