From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffQq4-0000UA-SW for qemu-devel@nongnu.org; Tue, 17 Jul 2018 10:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffQq3-0005yX-NX for qemu-devel@nongnu.org; Tue, 17 Jul 2018 10:20:28 -0400 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:40202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffQq3-0005xd-Ir for qemu-devel@nongnu.org; Tue, 17 Jul 2018 10:20:27 -0400 Received: by mail-oi0-x243.google.com with SMTP id w126-v6so2316200oie.7 for ; Tue, 17 Jul 2018 07:20:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180714171601.5734-10-luc.michel@greensocs.com> References: <20180714171601.5734-1-luc.michel@greensocs.com> <20180714171601.5734-10-luc.michel@greensocs.com> From: Peter Maydell Date: Tue, 17 Jul 2018 15:20:06 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v4 09/20] intc/arm_gic: Add virtualization enabled IRQ helper functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luc Michel Cc: QEMU Developers , qemu-arm , Sai Pavan Boddu , Edgar Iglesias , Mark Burton , Jan Kiszka On 14 July 2018 at 18:15, Luc Michel wrote: > Add some helper functions to gic_internal.h to get or change the state > of an IRQ. When the current CPU is not a vCPU, the call is forwarded to > the GIC distributor. Otherwise, it acts on the list register matching > the IRQ in the current CPU virtual interface. > > gic_clear_active can have a side effect on the distributor, even in the > vCPU case, when the correponding LR has the HW field set. > > Use those functions in the CPU interface code path to prepare for the > vCPU interface implementation. > > Signed-off-by: Luc Michel Reviewed-by: Peter Maydell thanks -- PMM