From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Chen Gang <gang.chen.5i5j@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] libvixl: a64: Skip "-Wunused-variable" for gcc 5.0.0 or higher
Date: Mon, 13 Oct 2014 17:07:57 +0200 [thread overview]
Message-ID: <CAFEAcA_t7VO5T461RhSXjRZLP6T8Y_zkoBGHU2N95GebocrZ+Q@mail.gmail.com> (raw)
In-Reply-To: <543BE8E2.7090307@redhat.com>
On 13 October 2014 16:59, Eric Blake <eblake@redhat.com> wrote:
> -isystem is a heavy hammer, affecting the entire compilation. Better
> might be just marking the ONE header as being a system header (silence
> various warnings caused by just that header, while still letting the
> rest of the compilation warn). If the header comes from third-party
> sources, this is probably the best approach. It is done by adding:
>
> #if __GNUC__ >= 3
> #pragma GCC system_header
> #endif
>
> to the header that would otherwise trigger warnings.
If we're going to modify the header then we might as well just
disable the specific warning that's being triggered. The only
benefit of -isystem is you can do it in the makefile and leave
the source file untouched.
-- PMM
next prev parent reply other threads:[~2014-10-13 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 14:07 [Qemu-devel] [PATCH v2] libvixl: a64: Skip "-Wunused-variable" for gcc 5.0.0 or higher Chen Gang
2014-10-11 14:13 ` Chen Gang
2014-10-11 21:25 ` Peter Maydell
2014-10-12 0:32 ` Chen Gang
2014-10-12 7:50 ` Peter Maydell
2014-10-12 11:19 ` Chen Gang
2014-10-13 14:59 ` Eric Blake
2014-10-13 15:07 ` Peter Maydell [this message]
2014-10-14 19:58 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-10-14 20:47 ` Chen Gang
2014-10-15 9:55 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_t7VO5T461RhSXjRZLP6T8Y_zkoBGHU2N95GebocrZ+Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=eblake@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).