source fails to compile on msys2

source fails to compile on msys2

[Howard Spoelstra]

[-- Attachment #1: Type: text/plain, Size: 3647 bytes --]

Hello,

It seems the current source fails to compile with up to date msys2.

Source is configured with:
./configure --target-list="ppc-softmmu" --enable-gtk --enable-sdl
--enable-slirp

FAILED: qga/vss-win32/qga-vss.dll.p/install.cpp.obj
"c++" "-m64" "-mcx16" "-Iqga/vss-win32/qga-vss.dll.p" "-Iqga/vss-win32"
"-I../qga/vss-win32" "-I." "-Iqapi" "-Itrace" "-Iui" "-Iui/shader"
"-IC:/msys64/mingw64/include/glib-2.0"
"-IC:/msys64/mingw64/lib/glib-2.0/include" "-fdiagnostics-color=auto"
"-Wall" "-Winvalid-pch" "-Wnon-virtual-dtor" "-Werror" "-std=gnu++11" "-O2"
"-g" "-iquote" "." "-iquote" "C:/msys64/home/hsp/src/qemu-master-clean"
"-iquote" "C:/msys64/home/hsp/src/qemu-master-clean/include" "-iquote"
"C:/msys64/home/hsp/src/qemu-master-clean/tcg/i386" "-D__STDC_LIMIT_MACROS"
"-D__STDC_CONSTANT_MACROS" "-D__STDC_FORMAT_MACROS" "-U_FORTIFY_SOURCE"
"-D_FORTIFY_SOURCE=2" "-fno-pie" "-no-pie" "-D_GNU_SOURCE"
"-D_FILE_OFFSET_BITS=64" "-D_LARGEFILE_SOURCE" "-fno-strict-aliasing"
"-fno-common" "-fwrapv" "-Wundef" "-Wwrite-strings" "-Wtype-limits"
"-Wformat-security" "-Wformat-y2k" "-Winit-self" "-Wignored-qualifiers"
"-Wempty-body" "-Wendif-labels" "-Wexpansion-to-defined"
"-Wimplicit-fallthrough=2" "-Wmissing-format-attribute"
"-Wno-missing-include-dirs" "-Wno-shift-negative-value" "-Wno-psabi"
"-fstack-protector-strong" "-Wno-unknown-pragmas"
"-Wno-delete-non-virtual-dtor" "-Wno-non-virtual-dtor" -MD -MQ
qga/vss-win32/qga-vss.dll.p/install.cpp.obj -MF
"qga/vss-win32/qga-vss.dll.p/install.cpp.obj.d" -o
qga/vss-win32/qga-vss.dll.p/install.cpp.obj "-c"
../qga/vss-win32/install.cpp
In file included from C:/msys64/mingw64/lib/glib-2.0/include/glibconfig.h:9,
                 from C:/msys64/mingw64/include/glib-2.0/glib/gtypes.h:34,
                 from C:/msys64/mingw64/include/glib-2.0/glib/galloca.h:34,
                 from C:/msys64/mingw64/include/glib-2.0/glib.h:32,
                 from
C:/msys64/home/hsp/src/qemu-master-clean/include/glib-compat.h:32,
                 from
C:/msys64/home/hsp/src/qemu-master-clean/include/qemu/osdep.h:144,
                 from ../qga/vss-win32/install.cpp:13:
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1076:21: error: standard
attributes in middle of decl-specifiers
 1076 | # define G_NORETURN [[noreturn]]
      |                     ^
C:/msys64/home/hsp/src/qemu-master-clean/include/qemu/osdep.h:240:8: note:
in expansion of macro 'G_NORETURN'
  240 | extern G_NORETURN
      |        ^~~~~~~~~~
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1076:21: note: standard
attributes must precede the decl-specifiers to apply to the declaration, or
follow them to apply to the type
 1076 | # define G_NORETURN [[noreturn]]
      |                     ^
C:/msys64/home/hsp/src/qemu-master-clean/include/qemu/osdep.h:240:8: note:
in expansion of macro 'G_NORETURN'
  240 | extern G_NORETURN
      |        ^~~~~~~~~~
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1076:21: error: attribute
ignored [-Werror=attributes]
 1076 | # define G_NORETURN [[noreturn]]
      |                     ^
C:/msys64/home/hsp/src/qemu-master-clean/include/qemu/osdep.h:240:8: note:
in expansion of macro 'G_NORETURN'
  240 | extern G_NORETURN
      |        ^~~~~~~~~~
C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1076:21: note: an
attribute that appertains to a type-specifier is ignored
 1076 | # define G_NORETURN [[noreturn]]
      |                     ^
C:/msys64/home/hsp/src/qemu-master-clean/include/qemu/osdep.h:240:8: note:
in expansion of macro 'G_NORETURN'
  240 | extern G_NORETURN
      |        ^~~~~~~~~~
cc1plus.exe: all warnings being treated as errors

Best,
Howard

[-- Attachment #2: Type: text/html, Size: 4717 bytes --]

Re: source fails to compile on msys2

[BALATON Zoltan]

On Wed, 12 Apr 2023, Howard Spoelstra wrote:
> It seems the current source fails to compile with up to date msys2.

See here: https://qemu.weilnetz.de/
I think there are some patches there that aren't upstream. I don't know 
why and also don't know why those binaries are not built from QEMU master.

Regards,
BALATON Zoltan

Re: source fails to compile on msys2

[Peter Maydell]

On Wed, 12 Apr 2023 at 13:05, Howard Spoelstra <hsp.cat7@gmail.com> wrote:
>
> Hello,
>
> It seems the current source fails to compile with up to date msys2.
>
> Source is configured with:
> ./configure --target-list="ppc-softmmu" --enable-gtk --enable-sdl --enable-slirp

Are you using a not-up-to-date version of the QEMU source?

> C:/msys64/home/hsp/src/qemu-master-clean/include/qemu/osdep.h:240:8: note: in expansion of macro 'G_NORETURN'
>   240 | extern G_NORETURN
>       |        ^~~~~~~~~~

In the current source code this line reads "G_NORETURN extern"
(ie the two tokens are swapped), which should fix the compile
issue you're seeing. This was done in commit 5cb993ff131fca
from March.

thanks
-- PMM

Re: source fails to compile on msys2

[Stefan Weil via]

Am 12.04.23 um 14:12 schrieb BALATON Zoltan:

> On Wed, 12 Apr 2023, Howard Spoelstra wrote:
>> It seems the current source fails to compile with up to date msys2.
>
> See here: https://qemu.weilnetz.de/
> I think there are some patches there that aren't upstream. I don't 
> know why and also don't know why those binaries are not built from 
> QEMU master.


My related Git repository is https://repo.or.cz/w/qemu/ar7.git/. I 
merged v8.0.0-rc3 two days ago, and that code builds with no problems 
for Windows.

And yes, my code includes commits which are (still) missing upstream. 
Some of them are for special hardware which was either removed from QEMU 
master or which I think is not interesting for upstream. Others were 
already sent to qemu-devel, so might become part of QEMU master later. 
In addition there are commits for my Windows build environment which 
also uses a higher warning level than QEMU master. But usually the 
differences to the latest tagged QEMU release are small.

Stefan

Re: source fails to compile on msys2

[Howard Spoelstra]

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

Hello Peter,

My source was cloned today. I just cloned again and I still see the tokens
reversed:
git clone https://www.gitlab.com/qemu/qemu qemu-master-clean

/**
 * qemu_build_not_reached()
 *
 * The compiler, during optimization, is expected to prove that a call
 * to this function cannot be reached and remove it.  If the compiler
 * supports QEMU_ERROR, this will be reported at compile time; otherwise
 * this will be reported at link time due to the missing symbol.
 */
extern G_NORETURN
void QEMU_ERROR("code path is reachable")
    qemu_build_not_reached_always(void);
#if defined(__OPTIMIZE__) && !defined(__NO_INLINE__)
#define qemu_build_not_reached()  qemu_build_not_reached_always()
#else
#define qemu_build_not_reached()  g_assert_not_reached()
#endif


The source on gitlab shows the correct order:

/** * qemu_build_not_reached() * * The compiler, during optimization,
is expected to prove that a call * to this function cannot be reached
and remove it.  If the compiler * supports QEMU_ERROR, this will be
reported at compile time; otherwise * this will be reported at link
time due to the missing symbol. */G_NORETURN externvoid
QEMU_ERROR("code path is reachable")
qemu_build_not_reached_always(void);#if defined(__OPTIMIZE__) &&
!defined(__NO_INLINE__)#define qemu_build_not_reached()
qemu_build_not_reached_always()#else#define qemu_build_not_reached()
g_assert_not_reached()#endif

[-- Attachment #2: Type: text/html, Size: 5336 bytes --]

Re: source fails to compile on msys2

[Stefan Weil via]

Am 12.04.23 um 15:13 schrieb Howard Spoelstra:
> Hello Peter,
> 
> My source was cloned today. I just cloned again and I still see the 
> tokens reversed:
> git clone https://www.gitlab.com/qemu/qemu 
> <https://www.gitlab.com/qemu/qemu> qemu-master-clean

The official URL is https://gitlab.com/qemu-project/qemu/.

Regards,
Stefan

Re: source fails to compile on msys2

[Peter Maydell]

On Wed, 12 Apr 2023 at 14:21, Stefan Weil via <qemu-devel@nongnu.org> wrote:
>
> Am 12.04.23 um 15:13 schrieb Howard Spoelstra:
> > Hello Peter,
> >
> > My source was cloned today. I just cloned again and I still see the
> > tokens reversed:
> > git clone https://www.gitlab.com/qemu/qemu
> > <https://www.gitlab.com/qemu/qemu> qemu-master-clean
>
> The official URL is https://gitlab.com/qemu-project/qemu/.

Yep. I have no idea who that other gitlab repo is, but it's
not us, and the repo could contain anything...

https://www.qemu.org/download/ is where to start for the
instructions on how to clone the official QEMU repo.

thanks
-- PMM

Re: source fails to compile on msys2

[Thomas Huth]

On 12/04/2023 15.13, Howard Spoelstra wrote:
> Hello Peter,
> 
> My source was cloned today. I just cloned again and I still see the tokens 
> reversed:
> git clone https://www.gitlab.com/qemu/qemu 

You're using the wrong repository. The official QEMU repo is here:

  https://gitlab.com/qemu-project/qemu.git

  HTH,
   Thomas

Re: source fails to compile on msys2

[Howard Spoelstra]

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Yep, fixed

No idea how I got that wrong ;-)

Best,
Howard

[-- Attachment #2: Type: text/html, Size: 157 bytes --]