From: Peter Maydell <peter.maydell@linaro.org>
To: Joel Stanley <joel@jms.id.au>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
"Jim Mussared" <jim.mussared@gmail.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Steffen Görtz" <contrib@steffen-goertz.de>,
"Julia Suvorova" <jusual@mail.ru>
Subject: Re: [Qemu-devel] [PATCH v5 0/3] arm: Add nRF51 SoC and micro:bit machine
Date: Thu, 16 Aug 2018 15:28:02 +0100 [thread overview]
Message-ID: <CAFEAcA_u+P7SfuvEMOi-+3brahDnq66ACfyRWJU5QSvQ4Fjo_w@mail.gmail.com> (raw)
In-Reply-To: <20180816141303.20518-1-joel@jms.id.au>
On 16 August 2018 at 15:13, Joel Stanley <joel@jms.id.au> wrote:
> v5: Change back to ARMv7M from ARMMProfile
> v4: Fix number of IRQs
> v3: Rebase on Stefan's cortex-m0 series
> v2: Addresses review from Peter and Stefan
>
> Based-on: 20180814162739.11814-1-stefanha@redhat.com
>
> This short series implements a minimal definition of the Nordic
> Semiconductor nRF51, a Cortex-M0 ARM SoC, and the BBC micro:bit, a
> machine that will use this SoC.
Hi Joel; it looks like my review of v4 crossed in the mail
with your sending out v5. I think that my comments on
the v4 patch 3 still applies to v5, though (as does my
reviwed-by tag on patch 1).
thanks
-- PMM
prev parent reply other threads:[~2018-08-16 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 14:13 [Qemu-devel] [PATCH v5 0/3] arm: Add nRF51 SoC and micro:bit machine Joel Stanley
2018-08-16 14:13 ` [Qemu-devel] [PATCH v5 1/3] MAINTAINERS: Add NRF51 entry Joel Stanley
2018-08-16 14:13 ` [Qemu-devel] [PATCH v5 2/3] arm: Add Nordic Semiconductor nRF51 SoC Joel Stanley
2018-08-16 14:24 ` Peter Maydell
2018-08-26 0:48 ` Joel Stanley
2018-08-26 10:57 ` Peter Maydell
2018-08-27 13:19 ` Stefan Hajnoczi
2018-08-16 14:13 ` [Qemu-devel] [PATCH v5 3/3] arm: Add BBC micro:bit machine Joel Stanley
2018-08-16 14:28 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_u+P7SfuvEMOi-+3brahDnq66ACfyRWJU5QSvQ4Fjo_w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=contrib@steffen-goertz.de \
--cc=jim.mussared@gmail.com \
--cc=joel@jms.id.au \
--cc=jusual@mail.ru \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).