From: Peter Maydell <peter.maydell@linaro.org>
To: Claudio Fontana <claudio.fontana@huawei.com>
Cc: Rob Herring <rob.herring@linaro.org>,
"tech@virtualopensystems.com" <tech@virtualopensystems.com>,
Alvise Rigo <a.rigo@virtualopensystems.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt
Date: Mon, 5 Jan 2015 15:36:14 +0000 [thread overview]
Message-ID: <CAFEAcA_uNBu1erT0meWs88Dogs2d5Keu=cf0W43grSPyZjBLMw@mail.gmail.com> (raw)
In-Reply-To: <54731ADE.302@huawei.com>
On 24 November 2014 at 11:47, Claudio Fontana
<claudio.fontana@huawei.com> wrote:
> On 21.11.2014 19:07, Alvise Rigo wrote:
>> Keep a global list with all the functions that need to modify the device
>> tree. Using qemu_add_machine_init_done_notifier we register a notifier
>> that executes all the functions on the list and loads the kernel.
>>
>> Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com>
>
> Peter, could you weigh in about whether this is a good idea or not?
Sorry, I think I must have missed this series first time around.
I'm not convinced -- I don't see any reason why we should treat
the PCI host controller differently from other devices in the
virt board: just generate an appropriate dtb fragment in virt.c.
thanks
-- PMM
next prev parent reply other threads:[~2015-01-05 15:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:07 [Qemu-devel] [RFC v2 0/4] Add Generic PCI host device update Alvise Rigo
2014-11-21 18:07 ` [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt Alvise Rigo
2014-11-24 11:47 ` Claudio Fontana
2015-01-05 15:36 ` Peter Maydell [this message]
2015-01-05 16:14 ` alvise rigo
2015-01-05 16:41 ` Peter Maydell
2015-01-05 17:35 ` alvise rigo
2015-01-05 18:07 ` Peter Maydell
2015-01-06 9:56 ` alvise rigo
2015-01-06 9:18 ` Eric Auger
2015-01-06 9:29 ` alvise rigo
2015-01-06 9:51 ` Peter Maydell
2015-01-06 10:05 ` Eric Auger
2014-11-21 18:07 ` [Qemu-devel] [RFC v2 2/4] hw/arm/virt: find_machine_info: handle NULL value Alvise Rigo
2015-01-05 15:36 ` Peter Maydell
2015-01-05 16:31 ` alvise rigo
2015-01-05 16:42 ` Peter Maydell
2014-11-21 18:07 ` [Qemu-devel] [RFC v2 3/4] hw/pci-host: Add a generic PCI host controller for virtual platforms Alvise Rigo
2014-11-24 10:34 ` Claudio Fontana
2014-11-24 14:57 ` alvise rigo
2014-11-25 10:20 ` Claudio Fontana
2015-01-05 17:13 ` Alexander Graf
2015-01-06 8:47 ` alvise rigo
2015-01-06 11:18 ` Alexander Graf
[not found] ` <1416593261-13751-5-git-send-email-a.rigo@virtualopensystems.com>
2014-11-24 10:38 ` [Qemu-devel] [RFC v2 4/4] hw/arm/virt: Add generic-pci device support Claudio Fontana
2014-11-24 10:47 ` alvise rigo
2014-11-24 15:50 ` [Qemu-devel] [RFC v2 0/4] Add Generic PCI host device update Claudio Fontana
2014-11-25 10:28 ` alvise rigo
2015-01-12 16:26 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_uNBu1erT0meWs88Dogs2d5Keu=cf0W43grSPyZjBLMw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=claudio.fontana@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=rob.herring@linaro.org \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).