From: Peter Maydell <peter.maydell@linaro.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Niek Linnenbank" <nieklinnenbank@gmail.com>,
"Howard Spoelstra" <hsp.cat7@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2] softmmu/vl.c: fix too slow TCG regression
Date: Thu, 27 Feb 2020 17:12:12 +0000 [thread overview]
Message-ID: <CAFEAcA_uShJjZ1iwS5XrP7LDX5Y6JwYNtpF7fJpnzGyS6=urSw@mail.gmail.com> (raw)
In-Reply-To: <20200227161454.32368-1-imammedo@redhat.com>
On Thu, 27 Feb 2020 at 16:15, Igor Mammedov <imammedo@redhat.com> wrote:
>
> Commit a1b18df9a4 moved -m option parsing after configure_accelerators()
> that broke TCG accelerator initialization which accesses global ram_size
> from size_code_gen_buffer() which is equal to 0 at that moment.
>
> Partially revert a1b18df9a4, by returning set_memory_options() to its
> original location and only keep 32-bit host VA check and 'memory-backend'
> size check introduced by fe64d06afc at current place.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2:
> * check if user used -m SZ before comparing ram_size with backend's size.
> Fixes case where qemu exits with error when backend's size doesn't match
> dafault ram_size (i.e. user haven't used -m option at all)
> (Peter Maydell <peter.maydell@linaro.org>)
> * keep order addr space size check for 32-bit host after
> backend size check. So it would be affected by backend's size as well.
Applied to master as a fix for the tcg perf regression, thanks.
-- PMM
prev parent reply other threads:[~2020-02-27 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 16:14 [PATCH v2] softmmu/vl.c: fix too slow TCG regression Igor Mammedov
2020-02-27 16:35 ` Philippe Mathieu-Daudé
2020-02-27 16:37 ` Philippe Mathieu-Daudé
2020-02-27 17:12 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_uShJjZ1iwS5XrP7LDX5Y6JwYNtpF7fJpnzGyS6=urSw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=hsp.cat7@gmail.com \
--cc=imammedo@redhat.com \
--cc=nieklinnenbank@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).