qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: meson.build files are missing copyright/license headers
Date: Mon, 24 Aug 2020 19:46:12 +0100	[thread overview]
Message-ID: <CAFEAcA_u_3P9MQ23zWTUH-aM8Nabbt+PVv+4qOWpEAhiuJq+cg@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CL1Hp-g8gNMpdGgk2d0KCzJfBde9f_mX8TLtewe3-B48g@mail.gmail.com>

On Mon, 24 Aug 2020 at 19:29, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> On Mon, Aug 24, 2020 at 1:44 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>>  It looks like the new meson.build files are missing the usual
>> copyright-and-license header comment. Could somebody add them,
>> please?
>>
>> scripts/ninjatool.py does have a copyright line but is missing
>> the license statement.
>>
>
> Afaik, most makefiles didn't have any, so it falls under the default GPL2+ LICENSE rule.

Yep, but the rule is that new files should have them, even if
old files didn't always.

> If it's a matter of prepending
>
> # SPDX-License-Identifier: GPL-2.0-or-later
>
> On each meson.build file, I can prepare a patch.

Everything needs at least a copyright line (in this case, judging
by existing files in the tree it will probably be something like
"Copyright (c) 2020 Red Hat, Inc." but check with your legal
department what they like ;-)), plus a statement that clearly
defines the license the code is under. We don't mandate SPDX[*],
but it will do the job if you want to use it.

[*] Mostly because nobody's cared enough to say "we should
standardize on this and convert existing files and add the
check to checkpatch that new files have an SPDX line".

thanks
-- PMM


  reply	other threads:[~2020-08-24 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  9:43 meson.build files are missing copyright/license headers Peter Maydell
2020-08-24 18:29 ` Marc-André Lureau
2020-08-24 18:46   ` Peter Maydell [this message]
2020-08-25  5:57     ` Thomas Huth
2020-08-25  9:53       ` Peter Maydell
2020-08-25 13:58         ` Thomas Huth
2020-08-25 14:04           ` Peter Maydell
2020-08-25 14:15             ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_u_3P9MQ23zWTUH-aM8Nabbt+PVv+4qOWpEAhiuJq+cg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).