From: Peter Maydell <peter.maydell@linaro.org>
To: Matt Craighead <mjcraighead@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear other FPSCR bits
Date: Tue, 8 May 2012 16:01:41 +0100 [thread overview]
Message-ID: <CAFEAcA_ungR_ZzjLmcvdgNe7cgsVQFqQTTLCv0Wyq1W-MnBKCw@mail.gmail.com> (raw)
In-Reply-To: <CAEn9PUrWLHTbdfQzaQLt9yWmsVqgnQXzA4ywx0mb_OU9jkwbtw@mail.gmail.com>
On 7 May 2012 03:45, Matt Craighead <mjcraighead@gmail.com> wrote:
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> -#define SET_QC() env->vfp.xregs[ARM_VFP_FPSCR] = CPSR_Q
> +#define SET_QC() env->vfp.xregs[ARM_VFP_FPSCR] |= CPSR_Q
Bug reproduced, fix confirmed,
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
This bug has actually been in the code since 2008...
As a trivial and obvious patch I think I'll put it into a pullreq
for 1.1.
-- PMM
next prev parent reply other threads:[~2012-05-08 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 2:45 [Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear other FPSCR bits Matt Craighead
2012-05-08 15:01 ` Peter Maydell [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-08 15:08 [Qemu-devel] [PULL for-1.1] target-arm queue Peter Maydell
2012-05-08 15:08 ` [Qemu-devel] [PATCH] target-arm: When setting FPSCR.QC, don't clear other FPSCR bits Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_ungR_ZzjLmcvdgNe7cgsVQFqQTTLCv0Wyq1W-MnBKCw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=mjcraighead@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).