From: Peter Maydell <peter.maydell@linaro.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Pavel Fedin <p.fedin@samsung.com>,
Shlomo Pongratz <shlomopongratz@gmail.com>,
Diana Craciun <diana.craciun@freescale.com>
Subject: Re: [Qemu-devel] [RFC v4 5/6] hw/intc/arm_gicv3_its: Implement support for in-kernel ITS emulation
Date: Fri, 29 Jul 2016 15:22:54 +0100 [thread overview]
Message-ID: <CAFEAcA_vJZQeuJHjsCa1sG2cpBRbeNyigw=Y2PyDpS_5=Or4Aw@mail.gmail.com> (raw)
In-Reply-To: <c67f4f5e-3beb-2c59-2f7a-46a370343acc@redhat.com>
On 29 July 2016 at 15:13, Auger Eric <eric.auger@redhat.com> wrote:
> Hi Peter,
> On 29/07/2016 15:35, Peter Maydell wrote:
>> On 6 July 2016 at 10:46, Eric Auger <eric.auger@redhat.com> wrote:
>>> +/**
>>> + *
>>> + * We currently do not use kvm_arm_register_device to provide
>>> + * the kernel with the vITS control frame base address since the
>>> + * KVM_DEV_ARM_VGIC_CTRL_INIT init MUST be called after the
>>> + * KVM_ARM_SET_DEVICE_ADDR and the kvm_arm_register_device
>>> + * infra does not allow this.
>>> + */
>>
>> So the conclusion on the kvm-arm mailing list was that the
>> kernel ought to permit DEVICE_ADDR to be set after INIT,
>> the same way it does for the GIC proper, right?
> Yes this was indeed evoked but eventually what is in next, right now is
> the same implementation where KVM_ARM_SET_DEVICE_ADDR is forbidden once
> init is done:
That's bad and we need to fix it, preferably before it hits master.
thanks
-- PMM
next prev parent reply other threads:[~2016-07-29 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 9:45 [Qemu-devel] [RFC v4 0/6] vITS support Eric Auger
2016-07-06 9:45 ` [Qemu-devel] [RFC v4 1/6] hw/intc/arm_gicv3_its: Implement ITS base class Eric Auger
2016-07-06 9:46 ` [Qemu-devel] [RFC v4 2/6] target-arm: move gicv3_class_name from machine to kvm_arm.h Eric Auger
2016-07-10 20:17 ` Auger Eric
2016-07-06 9:46 ` [Qemu-devel] [RFC v4 3/6] linux-headers: update to 4.7-rc6 + ITS emulation and GSI routing Eric Auger
2016-07-06 9:46 ` [Qemu-devel] [RFC v4 4/6] target-arm/kvm: Pass requester ID to MSI routing functions Eric Auger
2016-07-06 9:46 ` [Qemu-devel] [RFC v4 5/6] hw/intc/arm_gicv3_its: Implement support for in-kernel ITS emulation Eric Auger
2016-07-29 13:35 ` Peter Maydell
2016-07-29 14:13 ` Auger Eric
2016-07-29 14:22 ` Peter Maydell [this message]
2016-07-06 9:46 ` [Qemu-devel] [RFC v4 6/6] arm/virt: Add ITS to the virt board Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_vJZQeuJHjsCa1sG2cpBRbeNyigw=Y2PyDpS_5=Or4Aw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=diana.craciun@freescale.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).