From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZGPE-0003Ya-J5 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 06:17:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZGPD-0002Vp-DY for qemu-devel@nongnu.org; Fri, 26 Feb 2016 06:17:56 -0500 Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:32873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZGPD-0002Vg-9t for qemu-devel@nongnu.org; Fri, 26 Feb 2016 06:17:55 -0500 Received: by mail-vk0-x235.google.com with SMTP id k196so74881749vka.0 for ; Fri, 26 Feb 2016 03:17:55 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <56D0333A.2000605@cn.fujitsu.com> References: <1456484343-7445-1-git-send-email-caoj.fnst@cn.fujitsu.com> <56D0333A.2000605@cn.fujitsu.com> From: Peter Maydell Date: Fri, 26 Feb 2016 11:17:35 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] doc/memory.txt: fix typo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: QEMU Trivial , QEMU Developers On 26 February 2016 at 11:12, Cao jin wrote: > On 02/26/2016 07:03 PM, Peter Maydell wrote: >> Why is this patch touching all these ascii art diagrams? If you want >> to change them, that's a different patch, but I don't see any need to. >> In fact you seem to have lost some of the [] from your version, so your >> change doesn't look like an improvement to me. > well, the diagram seem not aligned so well, so I did the modification. The lines 0 1000 2000 3000 4000 5000 6000 7000 8000 |------|------|------|------|------|------|------|-------| have one stray extra '-' in the 7000..8000 part (and so an extra ' ' before '8000'), both other than that the diagram itself looks correct to me. thanks -- PMM