From: Peter Maydell <peter.maydell@linaro.org>
To: Will Newton <will.newton@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.
Date: Thu, 3 Oct 2013 23:37:13 +0900 [thread overview]
Message-ID: <CAFEAcA_ySaeLvyLGOWD+ctXrB5FFCRRJUiV_j1ChBL_hk6Pdrg@mail.gmail.com> (raw)
In-Reply-To: <CANu=DmiUDQJ4JETXf+J7Jbw4FLn-MOt+Osx_6thqYCtKkXD6SA@mail.gmail.com>
On 3 October 2013 23:31, Will Newton <will.newton@linaro.org> wrote:
> On 3 October 2013 13:59, Peter Maydell <peter.maydell@linaro.org> wrote:
>> This isn't what I meant. If our decoding matches up with the ARM ARM
>> then this instruction pattern should already fall into disas_vfp_insn(),
>> and we shouldn't need an extra check and call. (If it's not correct then
>> we should adjust our decode so it does.)
>
> I'll respin the patch pulling the calls to disas_vfp_insn up a level
> which I think you alluded to in the original review. It still needs an
> additional call to disas_vfp_insn in the ARM case as condition code ==
> 0xf is dealt with separately from the others. Let me know if this is
> not what you were looking for.
Ah, that means the ARM ARM table is incorrect, because it implies
that VSEL is conditional (which it definitely isn't). I need to look
at where the new insns are in the T32/A32 encodings in more
detail, then, which I don't have time for just at the moment.
Pulling the disas_vfp_insn calls out of disas_coproc is a good
idea anyway, though (it should be a separate patch to the one
which adds VSEL).
-- PMM
next prev parent reply other threads:[~2013-10-03 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 12:51 [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction Will Newton
2013-10-03 12:59 ` Peter Maydell
2013-10-03 14:31 ` Will Newton
2013-10-03 14:37 ` Peter Maydell [this message]
2013-10-15 10:31 ` Peter Maydell
2013-10-03 14:34 ` Richard Henderson
2013-10-03 15:10 ` Will Newton
2013-10-03 15:28 ` Richard Henderson
2013-10-03 18:39 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_ySaeLvyLGOWD+ctXrB5FFCRRJUiV_j1ChBL_hk6Pdrg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).