From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkDKn-00089o-OP for qemu-devel@nongnu.org; Mon, 09 Jan 2012 06:24:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkDKj-0006bO-S1 for qemu-devel@nongnu.org; Mon, 09 Jan 2012 06:24:13 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:40869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkDKj-0006bK-M0 for qemu-devel@nongnu.org; Mon, 09 Jan 2012 06:24:09 -0500 Received: by qcsd15 with SMTP id d15so2155274qcs.4 for ; Mon, 09 Jan 2012 03:24:09 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1324857738-7916-1-git-send-email-peter.maydell@linaro.org> References: <1324857738-7916-1-git-send-email-peter.maydell@linaro.org> Date: Mon, 9 Jan 2012 11:24:08 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tcg/arm: Use r6 as TCG_AREG0 to avoid clash with Thumb framepointer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org Ping? (either I forgot to cc you, Andrzej, or the mailing list manager helpfully dropped you off the cc list again. Sorry.) -- PMM On 26 December 2011 00:02, Peter Maydell wrote: > On ARM, in Thumb mode r7 is used for the framepointer; this meant > that we would fail to compile in debug mode because we were using r7 > for TCG_AREG0. Shift to r6 instead to avoid this clash. > (Bug reported as LP:870990.) > > Signed-off-by: Peter Maydell > --- > I did an extremely rough-and-ready benchmark with using a highreg > instead and it didn't seem to make any difference, so I've stuck > with using a lowreg as we do at the moment. > > =C2=A0dyngen-exec.h =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A02 +- > =C2=A0tcg/arm/tcg-target.h | =C2=A0 =C2=A02 +- > =C2=A02 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dyngen-exec.h b/dyngen-exec.h > index 3544372..09be9ea 100644 > --- a/dyngen-exec.h > +++ b/dyngen-exec.h > @@ -31,7 +31,7 @@ > =C2=A0#elif defined(_ARCH_PPC) > =C2=A0#define AREG0 "r27" > =C2=A0#elif defined(__arm__) > -#define AREG0 "r7" > +#define AREG0 "r6" > =C2=A0#elif defined(__hppa__) > =C2=A0#define AREG0 "r17" > =C2=A0#elif defined(__mips__) > diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h > index 48586c3..0035b47 100644 > --- a/tcg/arm/tcg-target.h > +++ b/tcg/arm/tcg-target.h > @@ -78,7 +78,7 @@ typedef enum { > > =C2=A0enum { > =C2=A0 =C2=A0 /* Note: must be synced with dyngen-exec.h */ > - =C2=A0 =C2=A0TCG_AREG0 =3D TCG_REG_R7, > + =C2=A0 =C2=A0TCG_AREG0 =3D TCG_REG_R6, > =C2=A0}; > > =C2=A0static inline void flush_icache_range(unsigned long start, unsigned= long stop) > -- > 1.7.5.4