From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Leif Lindholm <quic_llindhol@quicinc.com>,
Leif Lindholm <leif.lindholm@oss.qualcomm.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Radoslaw Biernacki <rad@semihalf.com>,
qemu-arm@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH v2 4/5] hw/arm: enable secure EL2 timers for virt machine
Date: Fri, 10 Jan 2025 12:53:18 +0000 [thread overview]
Message-ID: <CAFEAcA_yqw2DJ_iPpwYXjsR_h1gAZdOs29b-2ar0QOg4k4D0hQ@mail.gmail.com> (raw)
In-Reply-To: <20241218181511.3575613-5-alex.bennee@linaro.org>
On Wed, 18 Dec 2024 at 18:15, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: qemu-stable@nongnu.org
> ---
> hw/arm/virt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 333eaf67ea..5e3589dc6a 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -873,6 +873,8 @@ static void create_gic(VirtMachineState *vms, MemoryRegion *mem)
> [GTIMER_HYP] = ARCH_TIMER_NS_EL2_IRQ,
> [GTIMER_SEC] = ARCH_TIMER_S_EL1_IRQ,
> [GTIMER_HYPVIRT] = ARCH_TIMER_NS_EL2_VIRT_IRQ,
> + [GTIMER_SEC_PEL2] = ARCH_TIMER_S_EL2_IRQ,
> + [GTIMER_SEC_VEL2] = ARCH_TIMER_S_EL2_VIRT_IRQ,
> };
>
> for (unsigned irq = 0; irq < ARRAY_SIZE(timer_irq); irq++) {
Do these timer interrupts have a defined devicetree binding that
we need to set up in fdt_add_timer_nodes()? How about ACPI?
thanks
-- PMM
next prev parent reply other threads:[~2025-01-10 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 18:15 [PATCH v2 0/5] target/arm: implement SEL2 physical and virtual timers Alex Bennée
2024-12-18 18:15 ` [PATCH v2 1/5] target/arm: document the architectural names of our GTIMERs Alex Bennée
2024-12-18 18:15 ` [PATCH v2 2/5] target/arm: ensure cntvoff_el2 also used for EL2 virt timer Alex Bennée
2024-12-18 18:15 ` [PATCH v2 3/5] target/arm: implement SEL2 physical and virtual timers Alex Bennée
2025-01-09 11:18 ` Philippe Mathieu-Daudé
2025-01-09 11:25 ` Daniel Wielandt
2025-01-10 12:57 ` Peter Maydell
2024-12-18 18:15 ` [PATCH v2 4/5] hw/arm: enable secure EL2 timers for virt machine Alex Bennée
2025-01-10 12:53 ` Peter Maydell [this message]
2025-01-22 11:20 ` Alex Bennée
2024-12-18 18:15 ` [PATCH v2 5/5] hw/arm: enable secure EL2 timers for sbsa machine Alex Bennée
2025-01-10 12:53 ` Peter Maydell
2025-01-09 10:40 ` [PATCH v2 0/5] target/arm: implement SEL2 physical and virtual timers Alex Bennée
2025-01-09 10:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_yqw2DJ_iPpwYXjsR_h1gAZdOs29b-2ar0QOg4k4D0hQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=leif.lindholm@oss.qualcomm.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).