From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Jackson Donaldson <jcksn@duck.com>,
Jackson Donaldson <jackson88044@gmail.com>
Subject: Re: [PATCH] hw/misc/max78000_gcr: Do not ignore address_space_write() errors
Date: Tue, 7 Oct 2025 09:27:48 +0100 [thread overview]
Message-ID: <CAFEAcA_ytH+AwTr9LAZBP2nbSTod0FkfuexbewW=T7Pbb3nkmw@mail.gmail.com> (raw)
In-Reply-To: <20251007024006.43166-1-philmd@linaro.org>
On Tue, 7 Oct 2025 at 03:40, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Convert max78000_gcr_ops[] to take MemTxAttrs and return MemTxResult,
> allowing the write() path to return error on failure.
*Should* it return a MEMTX error on this failure, though?
This is a question of what the hardware behaviour is,
and there's no reference to the datasheet in this
commit message...
thanks
-- PMM
next prev parent reply other threads:[~2025-10-07 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 2:40 [PATCH] hw/misc/max78000_gcr: Do not ignore address_space_write() errors Philippe Mathieu-Daudé
2025-10-07 8:27 ` Peter Maydell [this message]
2025-10-07 13:48 ` Philippe Mathieu-Daudé
2025-10-07 14:47 ` Philippe Mathieu-Daudé
2025-10-07 14:55 ` Peter Maydell
2025-10-07 15:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_ytH+AwTr9LAZBP2nbSTod0FkfuexbewW=T7Pbb3nkmw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=jackson88044@gmail.com \
--cc=jcksn@duck.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).