Re: [PATCH v3 0/3] Initial support for One-Time Programmable Memory (OTP) in BCM2835

[Peter Maydell <peter.maydell@linaro.org>]

On Sun, 19 May 2024 at 10:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
>
> All BCM2835 boards have on-board OTP memory with 66 32-bit rows. Usually,
> its contents are accessible via mailbox commands.
>
> [Changes in v3]
>
> - Forgot to replace constant with macro in one particular spot.
>
> [Changes in v2]
>
> - Replace read/write with get/set in bcm2835_otp.c.
> - Use impl instead of valid in bcm2835_otp.c.
> - Replace all constant values with macros defined in bcm2835_otp.h.
> - Change memory region size of OTP device to 0x80.
> - After further testing on a real Raspberry Pi 3, I noticed a few things
> contrary to my initial assumptions:
> -- The customer OTP lock bit is bit 6 of row 32, NOT bit 30 of row 30. This is
> currently undocumented to my knowledge.
> -- The above lock indeed applies to the private key as well.
>
> Rayhan Faizel (3):
>   hw/nvram: Add BCM2835 OTP device
>   hw/arm: Connect OTP device to BCM2835
>   hw/misc: Implement mailbox properties for customer OTP and device
>     specific private keys



Applied to target-arm.next, thanks.

-- PMM