From: Kevin Townsend <kevin.townsend@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device
Date: Mon, 27 Sep 2021 19:47:13 +0200 [thread overview]
Message-ID: <CAFPHj6OXYgerTxDhXyxxWnb4CS33N-+2RVntKauD+rBPqUMvqg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8gY5q=qtaR8brf+JfHNh=Xt2EzMvGv8g94AFRNm+Q=RA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
Hi Peter,
Thanks for the updated review.
On Mon, 27 Sept 2021 at 18:39, Peter Maydell <peter.maydell@linaro.org>
wrote:
> I thought we'd agreed to implement the whole of the auto-increment
> logic, not just for specific registers ?
>
The problem I have here is ... how many bytes are we willing to buffer?
There's no
reason I can't request 512 registers, for example. Should we limit the
buffer length
to a single 'full' set of register values?
Kevin
[-- Attachment #2: Type: text/html, Size: 938 bytes --]
next prev parent reply other threads:[~2021-09-27 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 9:32 [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device Kevin Townsend
2021-09-27 16:38 ` Peter Maydell
2021-09-27 17:47 ` Kevin Townsend [this message]
2021-09-27 18:50 ` Peter Maydell
2021-09-28 10:35 ` Kevin Townsend
2021-09-28 12:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFPHj6OXYgerTxDhXyxxWnb4CS33N-+2RVntKauD+rBPqUMvqg@mail.gmail.com \
--to=kevin.townsend@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).