From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47728C433EF for ; Mon, 27 Sep 2021 17:50:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1370F60F92 for ; Mon, 27 Sep 2021 17:50:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1370F60F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUulQ-0005qq-9K for qemu-devel@archiver.kernel.org; Mon, 27 Sep 2021 13:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUuiu-0003ip-GM for qemu-devel@nongnu.org; Mon, 27 Sep 2021 13:47:29 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:35449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUuis-0006Ki-Rj for qemu-devel@nongnu.org; Mon, 27 Sep 2021 13:47:28 -0400 Received: by mail-wm1-x32a.google.com with SMTP id z184-20020a1c7ec1000000b003065f0bc631so1316024wmc.0 for ; Mon, 27 Sep 2021 10:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=csS98ekpAJUh5o5O+bLeK+YStOBmd5/EZyjT7Wp5o/M=; b=NALxMt5Ik1S27HEdQ/FUadV2mDralzct9CHOXbF74wATYoepktuAxJ19L9CfgVgiKO KvZB64OeID/gI0D9c75FNgHq4MEf9rsCO+5rY4IwW25wDm5Pk06sZEYrxcwn+9o9opNe QU7vfiMyrFEhRjPMXn7WU6bL1Nu2wzlNDgCffWd0k46fOhjlnjbzmF3TO7Ztcx2NbpkP 6VHnMfi1tsCl5a53CdJN6Jzc3UzaHbxBdKNg+9IDgqRQPviv7CpdjAS1RU1+hjGdArRl 9zKJh1ZBCMaVYBjtd+pnPrR/ZBzogCjdMMCDBDbalR3RP6QVKX4heVka4t6adKiwMQ3X TNvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=csS98ekpAJUh5o5O+bLeK+YStOBmd5/EZyjT7Wp5o/M=; b=QEQZicFjYaZK3hTGHThnPjTvDRLcZb1AQV9DFMoEof3rN30hzL2e0ER3XwFgBPBo7f k3MQNl2e8dD3JAwLvyUj1cJuiuoqaYYRTuXvVQRbDR2ZEQcS7HGbcnDnepKPtKD2moIO PRyIzSCm5+brki04PkkEcCF0oLk3v1NVJMZGw+5jksCDk2WXKIPW3ZQBKItNPXQ+aHqf UlDZ07Obw77VBM3DbTQWQkhz4WXhOWYPQRW3o2K3FU9Nv1DiGb84szehRBrVCIafEfOy y3kQQX6cyYINkyVhpCflCxVE/SbBzpwJfdQWF3qlQw0TRVg3nPHbjwWktzRtWMjUElrm XuFA== X-Gm-Message-State: AOAM532tNVjYhGzU8PNhZMqUsvXwrsnrCHVV05KRMd/cs/jc5MMWumpL WxO9T3cIuqqnXz+VdTVxF/On9kWcETr77z7fGiFe/g== X-Google-Smtp-Source: ABdhPJzNcQX1BYiwtbluahkynXPju4ofsjTOAJddJEMbOPdN4Vm0g4Yic3QOUNRTrpxPPL9XUK9ybES95S4/fhWtIyc= X-Received: by 2002:a05:600c:3b1b:: with SMTP id m27mr328971wms.15.1632764844453; Mon, 27 Sep 2021 10:47:24 -0700 (PDT) MIME-Version: 1.0 References: <20210921093227.18592-1-kevin.townsend@linaro.org> In-Reply-To: From: Kevin Townsend Date: Mon, 27 Sep 2021 19:47:13 +0200 Message-ID: Subject: Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device To: Peter Maydell Content-Type: multipart/alternative; boundary="0000000000008e41a305ccfdb0c0" Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=kevin.townsend@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000008e41a305ccfdb0c0 Content-Type: text/plain; charset="UTF-8" Hi Peter, Thanks for the updated review. On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: > I thought we'd agreed to implement the whole of the auto-increment > logic, not just for specific registers ? > The problem I have here is ... how many bytes are we willing to buffer? There's no reason I can't request 512 registers, for example. Should we limit the buffer length to a single 'full' set of register values? Kevin --0000000000008e41a305ccfdb0c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Peter,

T= hanks for the updated review.

On Mon, 27 Sept 2021 at 18:39, Peter= Maydell <peter.maydell@lina= ro.org> wrote:
I thought we'd agreed to implement the whole of the auto-incremen= t
logic, not just for specific registers ?

The problem I have here is ... how many bytes are we willing to buffer? T= here's no
reason I can't request 512 registers, for examp= le. Should we limit the buffer length
to a single 'full' = set of register values?

Kevin
--0000000000008e41a305ccfdb0c0--