From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A159C433DF for ; Thu, 18 Jun 2020 02:42:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 285C621927 for ; Thu, 18 Jun 2020 02:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LTOD3/+F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 285C621927 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlkVB-0008Gv-Cp for qemu-devel@archiver.kernel.org; Wed, 17 Jun 2020 22:42:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlkUA-0007jN-0f for qemu-devel@nongnu.org; Wed, 17 Jun 2020 22:41:02 -0400 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]:41045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlkU8-0000IE-1C for qemu-devel@nongnu.org; Wed, 17 Jun 2020 22:41:01 -0400 Received: by mail-ua1-x943.google.com with SMTP id a10so1473091uan.8 for ; Wed, 17 Jun 2020 19:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2QGBwbLSnWJPzMhG7hmlgpEaJ1aqmaYfDLod2fS/lu4=; b=LTOD3/+FKlGr4xTd5eeF54DJ8/oHDZPZ2awCM+1qCswJaVb5D4aZ0XH0GJ+ixrjBT3 0oQzYzX3+zysVqJI5Niu7k70qAzvaSUeoWUfXUOdbXE8VVT6LYgctNqT+HtgejD0jKAU PjZwwV4IjRBx+zKa5o602q3tIoMBxp0d232ZLCTnuoVKxfCBu/OqvG1cQVcxuFmo8+CF jr0IOUkdrCvuevLbzbPqdmWPCqNliCvXOLbioVgS7m3/+QHNSsan0qErewe7vNGahPI6 bUojgl1OXLrxF2xqEq8WWYE63IRjMpf1Hhiw0ztvpgPdfbHxnvemnuKI3L57WnIy+RH3 NYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2QGBwbLSnWJPzMhG7hmlgpEaJ1aqmaYfDLod2fS/lu4=; b=VYW4/K28lu+2O6xsAc8J/5ltdW5rfsEPK91bFmqLhkQm9AIBD7Ey1VR0ahqUqcvdnk niSoJ2Y/aQ5AwB3iyy4cWpzyKce8EE+G7TlBC+L9iJoXhZsdWzQKh8m0k4Y6aM7YNd2o D7esxPY0RX3aGVk4Q3rZt+0i473SlgZW2IQuNWSaTQOGrKrhj9xZym9LvJBZChZFrQC3 EdYW3p8Rgl685ulaWxZAxhDXlrBxWbYZfr2y7WOMAZhAZlrJ0KQ6Z4rFdf/5DIS18o1p G0Z0gHQsiBCld7FQ+4M0WDMola+iw5No8Ciw4eLrOk3FqIVDnydoctTxwwpclYUfRCEq vI8w== X-Gm-Message-State: AOAM530nh+cCTeuSaILBj/n4352Mx4w9dyIFeDkz6lMzrGEKqVwIGj0z OValc/TpjjhnS1SLJSPpf7eFax16+Zkg29EL+FHkQQ== X-Google-Smtp-Source: ABdhPJwFhPq9fkEpjQo+0QJTKCmVvyvrvE690rY/dKP92QzxLWK5JZF1W+QPFTxW7+O6HyjDIGn9LSy976Y0MY6xoyk= X-Received: by 2002:ab0:70c9:: with SMTP id r9mr1474785ual.15.1592448057350; Wed, 17 Jun 2020 19:40:57 -0700 (PDT) MIME-Version: 1.0 References: <20200611223016.259837-1-hskinnemoen@google.com> <20200611223016.259837-12-hskinnemoen@google.com> <69a4b9c8-0ae0-96e2-8b46-cc89c9acbc9a@kaod.org> In-Reply-To: From: Havard Skinnemoen Date: Wed, 17 Jun 2020 19:40:45 -0700 Message-ID: Subject: Re: [PATCH v2 11/12] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj To: Joel Stanley Cc: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Peter Maydell , qemu-arm , QEMU Developers , Avi Fishman , CS20 KFTing Content-Type: multipart/alternative; boundary="000000000000c8f88e05a852b4c7" Received-SPF: pass client-ip=2607:f8b0:4864:20::943; envelope-from=hskinnemoen@google.com; helo=mail-ua1-x943.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, PDS_OTHER_BAD_TLD=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000c8f88e05a852b4c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 17, 2020 at 6:35 PM Joel Stanley wrote: > On Wed, 17 Jun 2020 at 16:42, C=C3=A9dric Le Goater wrote: > > > > On 6/12/20 12:30 AM, Havard Skinnemoen wrote: > > > This allows these NPCM7xx-based boards to boot from a flash image, e.= g. > > > one built with OpenBMC. For example like this: > > > > > > IMAGE=3D${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc > > > > could you put the image on some site when ready ? > > They are built as part of OpenBMC CI: > > > https://openpower.xyz/job/openbmc-build/distro=3Dubuntu,label=3Dbuilder,t= arget=3Dgsj/lastSuccessfulBuild/artifact/deploy/images/gsj/ Cool, I didn't know that! Trying to boot that image reminds me of a couple of issues I ran into. 1. This error: spi_master spi0: /ahb/fiu@fb000000/spi-nor@0 has no valid 'spi-max-frequency' property (-22) should be fixed by https://github.com/Nuvoton-Israel/linux/commit/c9185ea65bec8ba7b617080c6278= eb3e36db4eb4 but it looks like it hasn't propagated into the openbmc repo yet. 2. npcm7xx_ether_probe crashes the kernel, presumably because there's no emac model in qemu yet. I worked around it by disabling that driver, but it shouldn't be necessary once the emac model is done. 3. IIRC, after getting past (1) and (2), it turned out the MTD partition layout didn't match the device tree, so I had to adjust some offsets in the openbmc build. I was planning to post that to the openbmc list after making sure I'm cleared to contribute. Havard --000000000000c8f88e05a852b4c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jun 17, 2020 at 6:35 PM Joel Stan= ley <joel@jms.id.au> wrote:
=
On Wed, 17 Jun 2020 at 16:42, C=C3=A9dric Le Goater <clg@kaod.org>= ; wrote:
>
> On 6/12/20 12:30 AM, Havard Skinnemoen wrote:
> > This allows these NPCM7xx-based boards to boot from a flash image= , e.g.
> > one built with OpenBMC. For example like this:
> >
> > IMAGE=3D${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc
>
> could you put the image on some site when ready ?

They are built as part of OpenBMC CI:

https://openpower.xyz/jo= b/openbmc-build/distro=3Dubuntu,label=3Dbuilder,target=3Dgsj/lastSuccessful= Build/artifact/deploy/images/gsj/

Cool,= I didn't know that!

Trying to boot that image= reminds me of a couple of issues I ran into.

1. T= his error:

spi_master spi0: /ahb/fiu@fb000000/spi-= nor@0 has no valid 'spi-max-frequency' property (-22)=C2=A0

should be fixed by=C2=A0https://= github.com/Nuvoton-Israel/linux/commit/c9185ea65bec8ba7b617080c6278eb3e36db= 4eb4 but it looks like it hasn't propagated into the openbmc repo y= et.

2.=C2=A0npcm7xx_ether_probe crashes the kernel= , presumably because there's no emac model in qemu yet. I worked around= it by disabling that driver, but it shouldn't be necessary once the em= ac model is done.

3. IIRC, after getting past (1) = and (2), it turned out the MTD partition layout didn't match the device= tree, so I had to adjust some offsets in the openbmc build. I was planning= to post that to the openbmc list after making sure I'm cleared to cont= ribute.

Havard
--000000000000c8f88e05a852b4c7--