From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMnpJ-0007PF-F5 for qemu-devel@nongnu.org; Sat, 05 Nov 2011 17:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RMnpH-0003Ne-R4 for qemu-devel@nongnu.org; Sat, 05 Nov 2011 17:30:57 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:53117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMnpH-0003NY-LK for qemu-devel@nongnu.org; Sat, 05 Nov 2011 17:30:55 -0400 Received: by ggnp2 with SMTP id p2so16722ggn.4 for ; Sat, 05 Nov 2011 14:30:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1320293963-14629-1-git-send-email-jordan.l.justen@intel.com> <1320338977.4420.648.camel@jljusten-desk2> Date: Sat, 5 Nov 2011 14:30:54 -0700 Message-ID: From: Jordan Justen Content-Type: multipart/mixed; boundary=20cf3011e19161af7104b103894f Subject: Re: [Qemu-devel] [PATCH v7 0/2] PC system flash support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: Stefan Hajnoczi , qemu-devel --20cf3011e19161af7104b103894f Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: qemu-devel On Fri, Nov 4, 2011 at 22:37, Zhi Yong Wu wrote: > On Sat, Nov 5, 2011 at 12:11 AM, Jordan Justen wrote= : >> On Fri, Nov 4, 2011 at 04:34, Zhi Yong Wu wrote: >>> BTW: what is the relationship between -bios and -pflash? >> >> Previously the QEMU/KVM PC system had no pflash support. =A0You could >> specify a pflash drive, but it would not appear in the VM. >> >> Also, previously the -bios flag would cause the specified binary to be >> loaded by QEMU, and then it was put into a memory region to be used >> for the firmware. >> >> After this change, the pflash drive is used for firmware. =A0So, it > This pflash drive is created with -pflash option, right? -pflash can be used, but I think it is just a short cut. -pflash /path/to/file is similar to: -drive if=3Dpflash,file=3D/path/to/file And, after this change, -bios /path/to/file is similar to: -drive if=3Dpflash,file=3D/path/to/file,readonly=3Don >> should be able to support qcow2, since qemu drives support the >> different formats. I confirmed that you can use a qcow2 image with -bios after this change. >> For backward compatibility, this change makes the -bios parameter be >> another way to specify the pflash drive. =A0If -bios is used, then a >> read-only pflash drive is created. > Sorry, i don't fully understand this. How about -bios and -pflash are > both specified. In this case the -pflash will be used, and -bios will be ignored. I use -bios to create a pflash drive only if no pflash drive exists already. I think this should be okay, since -pflash has no use in the QEMU PC system before this patch, so it is unlikely that both -pflash and -bios will be used previously. >>> If your patch is applied to my source tree, can you know how to use -pf= lash? > Sorry, i made a mistake. I wanted to ask you how to use -pflash if > your patch is not applied. I don't think you can use pflash in a PC system when my patch is not applied. I think without the patch qemu will create the pflash drive internally, but it will not be hooked to a device that the emulated PC system can see. I attached a log of me interacting with the pflash device under the EFI shell on OVMF *with* the patch applied. Thanks, -Jordan --20cf3011e19161af7104b103894f Content-Type: text/plain; charset=US-ASCII; name="ovmf-flash-example-annotated.txt" Content-Disposition: attachment; filename="ovmf-flash-example-annotated.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gun3iq6z0 Tm90ZXMgYmVsb3cgcmVmZXIgdG8gcXVvdGVkIGl0ZW0ganVzdCBhYm92ZS4KCj4gRGV2aWNlIG1h cHBpbmcgdGFibGUKPiAgIGJsazAgOkZsb3BweSAtIEFsaWFzIChudWxsKQo+ICAgICAgICAgUGNp Um9vdCgweDApL1BjaSgweDEsMHgwKS9GbG9wcHkoMHgwKQo+ICAgYmxrMSA6RmxvcHB5IC0gQWxp YXMgKG51bGwpCj4gICAgICAgICBQY2lSb290KDB4MCkvUGNpKDB4MSwweDApL0Zsb3BweSgweDEp Cj4gICBibGsyIDpCbG9ja0RldmljZSAtIEFsaWFzIChudWxsKQo+ICAgICAgICAgUGNpUm9vdCgw eDApL1BjaSgweDEsMHgxKS9BdGEoU2Vjb25kYXJ5LE1hc3RlciwweDApCj4KPgo+IFByZXNzIEVT QyBpbiA1IHNlY29uZHMgdG8gc2tpcCBzdGFydHVwLm5zaCwgYW55IG90aGVyIGtleSB0byBjb250 aW51ZS4KPiBQcmVzcyBFU0MgaW4gNCBzZWNvbmRzIHRvIHNraXAgc3RhcnR1cC5uc2gsIGFueSBv dGhlciBrZXkgdG8gY29udGludWUuCgpFRkkgc2hlbGwgc3RhcnRlZAoKPiBTaGVsbD4gbWVtIGZm ZmUwIDMyCj4gICBNZW1vcnkgQWRkcmVzcyAwMDAwMDAwMDAwMEZGRkUwIDIwIEJ5dGVzCj4gICAw MDBGRkZFMDogRUIgQzMgOTAgOTAgOTAgOTAgOTAgOTAtMDAgMDAgMDAgMDAgNTYgNTQgNDYgMDAg ICouLi4uLi4uLi4uLi5WVEYuKgo+ICAgMDAwRkZGRjA6IDkwIDkwIEVCIEFDIDkwIDkwIDkwIDkw LTkwIDkwIDkwIDkwIDkwIDkwIDkwIDkwICAqLi4uLi4uLi4uLi4uLi4uLioKCkR1bXAgZmlybXdh cmUgcmFuZ2UgaW4gbGVnYWN5IEYwMDAgc2VnbWVudAoKPiBTaGVsbD4gbWVtIGZmZmZmZmUwIDMy Cj4gICBNZW1vcnkgQWRkcmVzcyAwMDAwMDAwMEZGRkZGRkUwIDIwIEJ5dGVzCj4gICBGRkZGRkZF MDogRUIgQzMgOTAgOTAgOTAgOTAgOTAgOTAtMDAgMDAgMDAgMDAgNTYgNTQgNDYgMDAgICouLi4u Li4uLi4uLi5WVEYuKgo+ICAgRkZGRkZGRjA6IDkwIDkwIEVCIEFDIDkwIDkwIDkwIDkwLTkwIDkw IDkwIDkwIDkwIDkwIDkwIDkwICAqLi4uLi4uLi4uLi4uLi4uLioKCkR1bXAgZmlybXdhcmUgcmFu Z2UgYXQgdG9wIG9mIDRHQi4KCj4gU2hlbGw+IG1lbSBmZmYwMDAwMCAzMgo+ICAgTWVtb3J5IEFk ZHJlc3MgMDAwMDAwMDBGRkYwMDAwMCAyMCBCeXRlcwo+ICAgRkZGMDAwMDA6IDAxIDAwIDAwIDAw IDAwIDAwIDAwIDAwLTAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwICAqLi4uLi4uLi4uLi4uLi4uLioK PiAgIEZGRjAwMDEwOiA3OCBFNSA4QyA4QyAzRCA4QSAxQyA0Ri05OSAzNSA4OSA2MSA4NSBDMyAy RCBEMyAgKnguLi49Li5PLjUuYS4uLS4qCgpEdW1wIHN0YXJ0IG9mIE9WTUYgZmxhc2ggaW1hZ2Uu ICBUaGUgZmlyc3QgMTYgYnl0ZXMgYXJlCnJlc2VydmVkLCBhbmQgdGhlcmVmb3JlIHdlIGNhbiBw cm9ncmFtIHRoZW0gd2l0aG91dCBhCm5lZ2F0aXZlIHNpZGUgZWZmZWN0LiAgTm90aWNlIEkgaGF2 ZSBwcmV2aW91c2x5IHByb2dyYW1tZWQKdGhlIGZpcnN0IGJ5dGUgZnJvbSAwMCB0byAwMS4KCj4g U2hlbGw+IG1tIC1tbWlvIC13IDEgLW4gZmZmMDAwMDAKPiBNTUlPICAweDAwMDAwMDAwRkZGMDAw MDAgOiAweDAxCgpSZWFkIHRoZSBkYXRhIGluIHRoZSBmaXJzdCBieXRlIG9mIHRoZSByb20uCgo+ IFNoZWxsPiBtbSAtbW1pbyAtdyAxIC1uIGZmZjAwMDAwIDcwCgpSZXF1ZXN0IHRvIHJlYWQgdGhl IHBmbGFzaF9jZmkwMSBzdGF0dXMgcmVnaXN0ZXIuCigweDcwIGlzIHRoZSBjb21tYW5kIHdyaXR0 ZW4gdG8gYWRkcmVzcyAweGZmZjAwMDAwLikKCj4gU2hlbGw+IG1tIC1tbWlvIC13IDEgLW4gZmZm MDAwMDAKPiBNTUlPICAweDAwMDAwMDAwRkZGMDAwMDAgOiAweDAwCgpSZWFkIHRoZSBzdGF0dXMg cmVnaXN0ZXIgYnkgcmVhZGluZyBhZGRyZXNzIDB4ZmZmMDAwMDAuCgo+IFNoZWxsPiBtbSAtbW1p byAtdyAxIC1uIGZmZjAwMDAwIGZmCgpQdXQgdGhlIHBmbGFzaF9jZmkwMSBiYWNrIGludG8gcmVh ZC1kYXRhIG1vZGUuCigweGZmIGlzIHRoZSBjb21tYW5kIGZvciBwdXR0aW5nIHRoZSBmbGFzaCBp bnRvIHJlYWQgbW9kZS4pCgo+IFNoZWxsPiBtbSAtbW1pbyAtdyAxIC1uIGZmZjAwMDAwCj4gTU1J TyAgMHgwMDAwMDAwMEZGRjAwMDAwIDogMHgwMQoKTm90aWNlIHdlIHJlYWQgdGhlIHByb3BlciBk YXRhIGFnYWluLi4uICAweDAxLgoKPiBTaGVsbD4gbW0gLW1taW8gLXcgMSAtbiBmZmYwMDAwMQo+ IE1NSU8gIDB4MDAwMDAwMDBGRkYwMDAwMSA6IDB4MDAKCk5vdyByZWFkIHRoZSBkYXRhIGF0IDB4 ZmZmMDAwMDEuICBJdCBpcyAweDAwLgoKPiBTaGVsbD4gbW0gLW1taW8gLXcgMSAtbiBmZmYwMDAw MSAxMAoKUHV0IHRoZSBwZmxhc2hfY2ZpMDEgaW50byBwcm9ncmFtbWluZyBtb2RlLgoKPiBTaGVs bD4gbW0gLW1taW8gLXcgMSAtbiBmZmYwMDAwMSBhYgoKUHJvZ3JhbSB0aGUgZGF0YSBhdCAweGZm ZjAwMDAxLiAgRGF0YSBpcyAweGFiLgoKPiBTaGVsbD4gbW0gLW1taW8gLXcgMSAtbiBmZmYwMDAw MSBmZgoKUHV0IHRoZSBwZmxhc2hfY2ZpMDEgYmFjayBpbnRvIHJlYWQtZGF0YSBtb2RlLgoKPiBT aGVsbD4gbW0gLW1taW8gLXcgMSAtbiBmZmYwMDAwMQo+IE1NSU8gIDB4MDAwMDAwMDBGRkYwMDAw MSA6IDB4QUIKCjB4YWIgd2FzIHByb2dyYW1tZWQgaW50byAweGZmZjAwMDAxLgoKPiBTaGVsbD4g bW0gLW1taW8gLXcgMSAtbiBmZmYwMDAwMSA3MAoKUmVxdWVzdCB0byByZWFkIHRoZSBzdGF0dXMg cmVnaXN0ZXIuCgo+IFNoZWxsPiBtbSAtbW1pbyAtdyAxIC1uIGZmZjAwMDAxCj4gTU1JTyAgMHgw MDAwMDAwMEZGRjAwMDAxIDogMHg4MAoKYml0NyAoMHg4MCkgaW5kaWNhdGVzIGRldmljZSBpcyBy ZWFkeS4KCj4gU2hlbGw+IG1tIC1tbWlvIC13IDEgLW4gZmZmMDAwMDEgZmYKCkJhY2sgdG8gcmVh ZC1kYXRhIG1vZGUgYWdhaW4uCgo+IFNoZWxsPiBtbSAtbW1pbyAtdyAxIC1uIGZmZjAwMDAxCj4g TU1JTyAgMHgwMDAwMDAwMEZGRjAwMDAxIDogMHhBQgoKVGhlIHByb3BlciBkYXRhIGlzIHN0aWxs IHJldHVybmVkLgoKPiBTaGVsbD4gcmVzZXQgLXMKClNodXRkb3duIHRoZSBzeXN0ZW0uLi4KCg== --20cf3011e19161af7104b103894f--