* Failing QEMU iotests
@ 2021-11-17 10:07 Thomas Huth
2021-11-17 10:59 ` Hanna Reitz
2021-11-17 18:13 ` John Snow
0 siblings, 2 replies; 10+ messages in thread
From: Thomas Huth @ 2021-11-17 10:07 UTC (permalink / raw)
To: QEMU Developers, Qemu-block
Cc: Kevin Wolf, Daniel P. Berrange, Hanna Reitz, John Snow
Hi!
I think it has been working fine for me a couple of weeks ago,
but when I now run:
make check SPEED=slow
I'm getting a couple of failing iotests... not sure whether
these are known issues already, so I thought I'd summarize them
here:
*** First one is 045 in raw mode: ***
TEST iotest-raw: 045 [fail]
QEMU -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" -nodefaults -display none -accel qtest
QEMU_IMG -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
QEMU_IO -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache writeback --aio threads -f raw
QEMU_NBD -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- raw
IMGPROTO -- file
PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmphlexdrlt
GDB_OPTIONS --
VALGRIND_QEMU --
PRINT_QEMU_OUTPUT --
--- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
+++ 045.out.bad
@@ -1,5 +1,77 @@
-...........
+......EE.EE
+======================================================================
+ERROR: test_add_fd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in test_add_fd
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
+======================================================================
+ERROR: test_closefd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 165, in test_closefd
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
+======================================================================
+ERROR: test_getfd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 153, in test_getfd
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
+======================================================================
+ERROR: test_getfd_invalid_fdname (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 158, in test_getfd_invalid_fdname
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
----------------------------------------------------------------------
Ran 11 tests
-OK
+FAILED (errors=4)
*** Second failure is in 206 in qcow2 mode: ***
TEST iotest-qcow2: 206 [fail]
QEMU -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" -nodefaults -display none -accel qtest
QEMU_IMG -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
QEMU_IO -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache writeback --aio threads -f qcow2
QEMU_NBD -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2
IMGPROTO -- file
PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmpqg73ug_s
GDB_OPTIONS --
VALGRIND_QEMU --
PRINT_QEMU_OUTPUT --
--- /home/thuth/devel/qemu/tests/qemu-iotests/206.out
+++ 206.out.bad
@@ -99,55 +99,19 @@
{"execute": "blockdev-create", "arguments": {"job-id": "job0", "options": {"driver": "qcow2", "encrypt": {"cipher-alg": "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg": "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg": "md5", "key-secret": "keysec0"}, "file": {"driver": "file", "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}}
{"return": {}}
+Job failed: Unsupported cipher algorithm twofish-128 with ctr mode
{"execute": "job-dismiss", "arguments": {"id": "job0"}}
{"return": {}}
image: TEST_IMG
file format: IMGFMT
virtual size: 32 MiB (33554432 bytes)
-encrypted: yes
cluster_size: 65536
Format specific information:
compat: 1.1
compression type: zlib
lazy refcounts: false
refcount bits: 16
- encrypt:
- ivgen alg: plain64
- hash alg: sha1
- cipher alg: twofish-128
- uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
- format: luks
- cipher mode: ctr
- slots:
- [0]:
- active: true
- iters: XXX
- key offset: 4096
- stripes: 4000
- [1]:
- active: false
- key offset: 69632
- [2]:
- active: false
- key offset: 135168
- [3]:
- active: false
- key offset: 200704
- [4]:
- active: false
- key offset: 266240
- [5]:
- active: false
- key offset: 331776
- [6]:
- active: false
- key offset: 397312
- [7]:
- active: false
- key offset: 462848
- payload offset: 528384
- master key iters: XXX
corrupt: false
extended l2: false
*** Third one is in 297, both raw and qcow2 mode: ***
--- /home/thuth/devel/qemu/tests/qemu-iotests/297.out
+++ 297.out.bad
@@ -1,2 +1,21 @@
=== pylint ===
+************* Module image-fleecing
+tests/image-fleecing:34:24: C0326: Exactly one space required after comma
+patterns = [('0x5d', '0', '64k'),
+ ^ (bad-whitespace)
+tests/image-fleecing:35:25: C0326: Exactly one space required after comma
+ ('0xd5', '1M', '64k'),
+ ^ (bad-whitespace)
+tests/image-fleecing:36:26: C0326: Exactly one space required after comma
+ ('0xdc', '32M', '64k'),
+ ^ (bad-whitespace)
+tests/image-fleecing:39:25: C0326: Exactly one space required after comma
+overwrite = [('0xab', '0', '64k'), # Full overwrite
+ ^ (bad-whitespace)
+tests/image-fleecing:48:32: C0326: Exactly one space required after comma
+remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left [1]
+ ^ (bad-whitespace)
+tests/image-fleecing:49:27: C0326: Exactly one space required after comma
+ ('0xdc', '32M', '32k'), # Left-end of partial-right [2]
+ ^ (bad-whitespace)
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 10:07 Failing QEMU iotests Thomas Huth
@ 2021-11-17 10:59 ` Hanna Reitz
2021-11-17 12:50 ` Thomas Huth
2021-11-17 18:13 ` John Snow
1 sibling, 1 reply; 10+ messages in thread
From: Hanna Reitz @ 2021-11-17 10:59 UTC (permalink / raw)
To: Thomas Huth, QEMU Developers, Qemu-block
Cc: Kevin Wolf, Daniel P. Berrange, John Snow
On 17.11.21 11:07, Thomas Huth wrote:
>
> Hi!
>
> I think it has been working fine for me a couple of weeks ago,
> but when I now run:
>
> make check SPEED=slow
>
> I'm getting a couple of failing iotests... not sure whether
> these are known issues already, so I thought I'd summarize them
> here:
Thanks!
> *** First one is 045 in raw mode: ***
>
> TEST iotest-raw: 045 [fail]
> QEMU --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> -nodefaults -display none -accel qtest
> QEMU_IMG --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
> writeback --aio threads -f raw
> QEMU_NBD --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- raw
> IMGPROTO -- file
> PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
> TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmphlexdrlt
> GDB_OPTIONS --
> VALGRIND_QEMU --
> PRINT_QEMU_OUTPUT --
>
> --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
> +++ 045.out.bad
> @@ -1,5 +1,77 @@
> -...........
> +......EE.EE
> +======================================================================
> +ERROR: test_add_fd (__main__.TestSCMFd)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in
> test_add_fd
> + self._send_fd_by_SCM()
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> _send_fd_by_SCM
> + ret = self.vm.send_fd_scm(file_path=image0)
> + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> 229, in send_fd_scm
> + self._qmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
> in send_fd_scm
> + self._aqmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
> 149, in _wrapper
> + return func(proto, *args, **kwargs)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> 644, in send_fd_scm
> + sock = sock._sock # pylint: disable=protected-access
> +AttributeError: 'socket' object has no attribute '_sock'
> +
> +======================================================================
> +ERROR: test_closefd (__main__.TestSCMFd)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 165, in
> test_closefd
> + self._send_fd_by_SCM()
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> _send_fd_by_SCM
> + ret = self.vm.send_fd_scm(file_path=image0)
> + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> 229, in send_fd_scm
> + self._qmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
> in send_fd_scm
> + self._aqmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
> 149, in _wrapper
> + return func(proto, *args, **kwargs)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> 644, in send_fd_scm
> + sock = sock._sock # pylint: disable=protected-access
> +AttributeError: 'socket' object has no attribute '_sock'
> +
> +======================================================================
> +ERROR: test_getfd (__main__.TestSCMFd)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 153, in
> test_getfd
> + self._send_fd_by_SCM()
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> _send_fd_by_SCM
> + ret = self.vm.send_fd_scm(file_path=image0)
> + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> 229, in send_fd_scm
> + self._qmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
> in send_fd_scm
> + self._aqmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
> 149, in _wrapper
> + return func(proto, *args, **kwargs)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> 644, in send_fd_scm
> + sock = sock._sock # pylint: disable=protected-access
> +AttributeError: 'socket' object has no attribute '_sock'
> +
> +======================================================================
> +ERROR: test_getfd_invalid_fdname (__main__.TestSCMFd)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 158, in
> test_getfd_invalid_fdname
> + self._send_fd_by_SCM()
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> _send_fd_by_SCM
> + ret = self.vm.send_fd_scm(file_path=image0)
> + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> 229, in send_fd_scm
> + self._qmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
> in send_fd_scm
> + self._aqmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
> 149, in _wrapper
> + return func(proto, *args, **kwargs)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> 644, in send_fd_scm
> + sock = sock._sock # pylint: disable=protected-access
> +AttributeError: 'socket' object has no attribute '_sock'
> +
> ----------------------------------------------------------------------
> Ran 11 tests
>
> -OK
> +FAILED (errors=4)
Sounds like something for John. O:)
>
> *** Second failure is in 206 in qcow2 mode: ***
>
> TEST iotest-qcow2: 206 [fail]
> QEMU --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> -nodefaults -display none -accel qtest
> QEMU_IMG --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
> writeback --aio threads -f qcow2
> QEMU_NBD --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- qcow2
> IMGPROTO -- file
> PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
> TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmpqg73ug_s
> GDB_OPTIONS --
> VALGRIND_QEMU --
> PRINT_QEMU_OUTPUT --
>
> --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out
> +++ 206.out.bad
> @@ -99,55 +99,19 @@
>
> {"execute": "blockdev-create", "arguments": {"job-id": "job0",
> "options": {"driver": "qcow2", "encrypt": {"cipher-alg":
> "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg":
> "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg":
> "md5", "key-secret": "keysec0"}, "file": {"driver": "file",
> "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}}
> {"return": {}}
> +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode
> {"execute": "job-dismiss", "arguments": {"id": "job0"}}
> {"return": {}}
>
> image: TEST_IMG
> file format: IMGFMT
> virtual size: 32 MiB (33554432 bytes)
> -encrypted: yes
> cluster_size: 65536
> Format specific information:
> compat: 1.1
> compression type: zlib
> lazy refcounts: false
> refcount bits: 16
> - encrypt:
> - ivgen alg: plain64
> - hash alg: sha1
> - cipher alg: twofish-128
> - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
> - format: luks
> - cipher mode: ctr
> - slots:
> - [0]:
> - active: true
> - iters: XXX
> - key offset: 4096
> - stripes: 4000
> - [1]:
> - active: false
> - key offset: 69632
> - [2]:
> - active: false
> - key offset: 135168
> - [3]:
> - active: false
> - key offset: 200704
> - [4]:
> - active: false
> - key offset: 266240
> - [5]:
> - active: false
> - key offset: 331776
> - [6]:
> - active: false
> - key offset: 397312
> - [7]:
> - active: false
> - key offset: 462848
> - payload offset: 528384
> - master key iters: XXX
> corrupt: false
> extended l2: false
I doubt this worked a couple of weeks ago, but it’s definitely one that
we should just get around to fixing. :/
>
> *** Third one is in 297, both raw and qcow2 mode: ***
>
> --- /home/thuth/devel/qemu/tests/qemu-iotests/297.out
> +++ 297.out.bad
> @@ -1,2 +1,21 @@
> === pylint ===
> +************* Module image-fleecing
> +tests/image-fleecing:34:24: C0326: Exactly one space required after
> comma
> +patterns = [('0x5d', '0', '64k'),
> + ^ (bad-whitespace)
> +tests/image-fleecing:35:25: C0326: Exactly one space required after
> comma
> + ('0xd5', '1M', '64k'),
> + ^ (bad-whitespace)
> +tests/image-fleecing:36:26: C0326: Exactly one space required after
> comma
> + ('0xdc', '32M', '64k'),
> + ^ (bad-whitespace)
> +tests/image-fleecing:39:25: C0326: Exactly one space required after
> comma
> +overwrite = [('0xab', '0', '64k'), # Full overwrite
> + ^ (bad-whitespace)
> +tests/image-fleecing:48:32: C0326: Exactly one space required after
> comma
> +remainder = [('0xd5', '0x108000', '32k'), # Right-end of
> partial-left [1]
> + ^ (bad-whitespace)
> +tests/image-fleecing:49:27: C0326: Exactly one space required after
> comma
> + ('0xdc', '32M', '32k'), # Left-end of
> partial-right [2]
> + ^ (bad-whitespace)
This could be because your pylint is too old. At least for the python/
tests we at least require 2.8.0
(https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html)
and bad-whitespace was removed in 2.6.
Hanna
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 10:59 ` Hanna Reitz
@ 2021-11-17 12:50 ` Thomas Huth
2021-11-17 14:46 ` Daniel P. Berrangé
2021-11-17 18:06 ` John Snow
0 siblings, 2 replies; 10+ messages in thread
From: Thomas Huth @ 2021-11-17 12:50 UTC (permalink / raw)
To: Hanna Reitz, QEMU Developers, Qemu-block
Cc: Kevin Wolf, Daniel P. Berrange, John Snow
On 17/11/2021 11.59, Hanna Reitz wrote:
> On 17.11.21 11:07, Thomas Huth wrote:
>>
>> Hi!
>>
>> I think it has been working fine for me a couple of weeks ago,
>> but when I now run:
>>
>> make check SPEED=slow
>>
>> I'm getting a couple of failing iotests... not sure whether
>> these are known issues already, so I thought I'd summarize them
>> here:
...
>> --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out
>> +++ 206.out.bad
>> @@ -99,55 +99,19 @@
>>
>> {"execute": "blockdev-create", "arguments": {"job-id": "job0", "options":
>> {"driver": "qcow2", "encrypt": {"cipher-alg": "twofish-128",
>> "cipher-mode": "ctr", "format": "luks", "hash-alg": "sha1", "iter-time":
>> 10, "ivgen-alg": "plain64", "ivgen-hash-alg": "md5", "key-secret":
>> "keysec0"}, "file": {"driver": "file", "filename":
>> "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}}
>> {"return": {}}
>> +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode
>> {"execute": "job-dismiss", "arguments": {"id": "job0"}}
>> {"return": {}}
>>
>> image: TEST_IMG
>> file format: IMGFMT
>> virtual size: 32 MiB (33554432 bytes)
>> -encrypted: yes
>> cluster_size: 65536
>> Format specific information:
>> compat: 1.1
>> compression type: zlib
>> lazy refcounts: false
>> refcount bits: 16
>> - encrypt:
>> - ivgen alg: plain64
>> - hash alg: sha1
>> - cipher alg: twofish-128
>> - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
>> - format: luks
>> - cipher mode: ctr
>> - slots:
>> - [0]:
>> - active: true
>> - iters: XXX
>> - key offset: 4096
>> - stripes: 4000
>> - [1]:
>> - active: false
>> - key offset: 69632
>> - [2]:
>> - active: false
>> - key offset: 135168
>> - [3]:
>> - active: false
>> - key offset: 200704
>> - [4]:
>> - active: false
>> - key offset: 266240
>> - [5]:
>> - active: false
>> - key offset: 331776
>> - [6]:
>> - active: false
>> - key offset: 397312
>> - [7]:
>> - active: false
>> - key offset: 462848
>> - payload offset: 528384
>> - master key iters: XXX
>> corrupt: false
>> extended l2: false
>
> I doubt this worked a couple of weeks ago, but it’s definitely one that we
> should just get around to fixing. :/
Hm, maybe I've did the successful run on a different system last time ... I
even slightly remember now having seen this before in the past on my current
system, so yes, likely not something new.
>> +++ 297.out.bad
>> @@ -1,2 +1,21 @@
>> === pylint ===
>> +************* Module image-fleecing
>> +tests/image-fleecing:34:24: C0326: Exactly one space required after comma
>> +patterns = [('0x5d', '0', '64k'),
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:35:25: C0326: Exactly one space required after comma
>> + ('0xd5', '1M', '64k'),
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:36:26: C0326: Exactly one space required after comma
>> + ('0xdc', '32M', '64k'),
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:39:25: C0326: Exactly one space required after comma
>> +overwrite = [('0xab', '0', '64k'), # Full overwrite
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:48:32: C0326: Exactly one space required after comma
>> +remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left [1]
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:49:27: C0326: Exactly one space required after comma
>> + ('0xdc', '32M', '32k'), # Left-end of partial-right [2]
>> + ^ (bad-whitespace)
>
> This could be because your pylint is too old. At least for the python/
> tests we at least require 2.8.0
> (https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html) and
> bad-whitespace was removed in 2.6.
Thanks, updating pylint fixed this problem, indeed!
But maybe the iotests should check the pylint version before using it?
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 12:50 ` Thomas Huth
@ 2021-11-17 14:46 ` Daniel P. Berrangé
2021-11-17 18:06 ` John Snow
1 sibling, 0 replies; 10+ messages in thread
From: Daniel P. Berrangé @ 2021-11-17 14:46 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, Hanna Reitz, John Snow, QEMU Developers, Qemu-block
On Wed, Nov 17, 2021 at 01:50:12PM +0100, Thomas Huth wrote:
> On 17/11/2021 11.59, Hanna Reitz wrote:
> > On 17.11.21 11:07, Thomas Huth wrote:
> > >
> > > Hi!
> > >
> > > I think it has been working fine for me a couple of weeks ago,
> > > but when I now run:
> > >
> > > make check SPEED=slow
> > >
> > > I'm getting a couple of failing iotests... not sure whether
> > > these are known issues already, so I thought I'd summarize them
> > > here:
> ...
> > > --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out
> > > +++ 206.out.bad
> > > @@ -99,55 +99,19 @@
> > >
> > > {"execute": "blockdev-create", "arguments": {"job-id": "job0",
> > > "options": {"driver": "qcow2", "encrypt": {"cipher-alg":
> > > "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg":
> > > "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg":
> > > "md5", "key-secret": "keysec0"}, "file": {"driver": "file",
> > > "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}}
> > > {"return": {}}
> > > +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode
> > > {"execute": "job-dismiss", "arguments": {"id": "job0"}}
> > > {"return": {}}
> > >
> > > image: TEST_IMG
> > > file format: IMGFMT
> > > virtual size: 32 MiB (33554432 bytes)
> > > -encrypted: yes
> > > cluster_size: 65536
> > > Format specific information:
> > > compat: 1.1
> > > compression type: zlib
> > > lazy refcounts: false
> > > refcount bits: 16
> > > - encrypt:
> > > - ivgen alg: plain64
> > > - hash alg: sha1
> > > - cipher alg: twofish-128
> > > - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
> > > - format: luks
> > > - cipher mode: ctr
> > > - slots:
> > > - [0]:
> > > - active: true
> > > - iters: XXX
> > > - key offset: 4096
> > > - stripes: 4000
> > > - [1]:
> > > - active: false
> > > - key offset: 69632
> > > - [2]:
> > > - active: false
> > > - key offset: 135168
> > > - [3]:
> > > - active: false
> > > - key offset: 200704
> > > - [4]:
> > > - active: false
> > > - key offset: 266240
> > > - [5]:
> > > - active: false
> > > - key offset: 331776
> > > - [6]:
> > > - active: false
> > > - key offset: 397312
> > > - [7]:
> > > - active: false
> > > - key offset: 462848
> > > - payload offset: 528384
> > > - master key iters: XXX
> > > corrupt: false
> > > extended l2: false
> >
> > I doubt this worked a couple of weeks ago, but it’s definitely one that
> > we should just get around to fixing. :/
>
> Hm, maybe I've did the successful run on a different system last time ... I
> even slightly remember now having seen this before in the past on my current
> system, so yes, likely not something new.
Triggered by me switching QEMU to prefer GNUTLS for crypto by default
in 6.1, as it doesn't bother to support obscure crypto algs that no
one uses in practice for LUKS.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 12:50 ` Thomas Huth
2021-11-17 14:46 ` Daniel P. Berrangé
@ 2021-11-17 18:06 ` John Snow
1 sibling, 0 replies; 10+ messages in thread
From: John Snow @ 2021-11-17 18:06 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, Hanna Reitz, Daniel P. Berrange, QEMU Developers,
Qemu-block
[-- Attachment #1: Type: text/plain, Size: 2532 bytes --]
On Wed, Nov 17, 2021 at 7:50 AM Thomas Huth <thuth@redhat.com> wrote:
> On 17/11/2021 11.59, Hanna Reitz wrote:
> > On 17.11.21 11:07, Thomas Huth wrote:
>
> >> +++ 297.out.bad
> >> @@ -1,2 +1,21 @@
> >> === pylint ===
> >> +************* Module image-fleecing
> >> +tests/image-fleecing:34:24: C0326: Exactly one space required after
> comma
> >> +patterns = [('0x5d', '0', '64k'),
> >> + ^ (bad-whitespace)
> >> +tests/image-fleecing:35:25: C0326: Exactly one space required after
> comma
> >> + ('0xd5', '1M', '64k'),
> >> + ^ (bad-whitespace)
> >> +tests/image-fleecing:36:26: C0326: Exactly one space required after
> comma
> >> + ('0xdc', '32M', '64k'),
> >> + ^ (bad-whitespace)
> >> +tests/image-fleecing:39:25: C0326: Exactly one space required after
> comma
> >> +overwrite = [('0xab', '0', '64k'), # Full overwrite
> >> + ^ (bad-whitespace)
> >> +tests/image-fleecing:48:32: C0326: Exactly one space required after
> comma
> >> +remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left
> [1]
> >> + ^ (bad-whitespace)
> >> +tests/image-fleecing:49:27: C0326: Exactly one space required after
> comma
> >> + ('0xdc', '32M', '32k'), # Left-end of partial-right
> [2]
> >> + ^ (bad-whitespace)
> >
> > This could be because your pylint is too old. At least for the python/
> > tests we at least require 2.8.0
> > (https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html)
> and
> > bad-whitespace was removed in 2.6.
>
> Thanks, updating pylint fixed this problem, indeed!
>
> But maybe the iotests should check the pylint version before using it?
>
>
Ideally, yes ... sorry, it's been a lot of work to try and get the python
testing for this stuff in order.
FWIW, the GitLab CI jobs for check-python-pipenv and check-python-tox now
basically run "iotest 297", and those jobs will use virtual environments to
force a supportable version of pylint/mypy/etc. These targets are the ones
I put the most effort into, and those are the ones that "just work".
It's on my list to, one way or another, drop 297 and use the python testing
infra to cover this instead, but I have some ground to cover for
usability/convenience before I can pitch it.
(At the risk of sounding like I am task offloading, if you send a patch to
add version checking to 297, I can review it.)
--js
[-- Attachment #2: Type: text/html, Size: 3734 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 10:07 Failing QEMU iotests Thomas Huth
2021-11-17 10:59 ` Hanna Reitz
@ 2021-11-17 18:13 ` John Snow
2021-11-17 19:45 ` Thomas Huth
1 sibling, 1 reply; 10+ messages in thread
From: John Snow @ 2021-11-17 18:13 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, Hanna Reitz, Daniel P. Berrange, QEMU Developers,
Qemu-block
[-- Attachment #1: Type: text/plain, Size: 2805 bytes --]
On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com> wrote:
>
> Hi!
>
> I think it has been working fine for me a couple of weeks ago,
> but when I now run:
>
> make check SPEED=slow
>
> I'm getting a couple of failing iotests... not sure whether
> these are known issues already, so I thought I'd summarize them
> here:
>
> *** First one is 045 in raw mode: ***
>
> TEST iotest-raw: 045 [fail]
> QEMU --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> -nodefaults -display none -accel qtest
> QEMU_IMG --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
> writeback --aio threads -f raw
> QEMU_NBD --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- raw
> IMGPROTO -- file
> PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
> TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmphlexdrlt
> GDB_OPTIONS --
> VALGRIND_QEMU --
> PRINT_QEMU_OUTPUT --
>
> --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
> +++ 045.out.bad
> @@ -1,5 +1,77 @@
> -...........
> +......EE.EE
> +======================================================================
> +ERROR: test_add_fd (__main__.TestSCMFd)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in
> test_add_fd
> + self._send_fd_by_SCM()
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> _send_fd_by_SCM
> + ret = self.vm.send_fd_scm(file_path=image0)
> + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229,
> in send_fd_scm
> + self._qmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in
> send_fd_scm
> + self._aqmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149,
> in _wrapper
> + return func(proto, *args, **kwargs)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644,
> in send_fd_scm
> + sock = sock._sock # pylint: disable=protected-access
> +AttributeError: 'socket' object has no attribute '_sock'
>
Well, that's not good.
Can you tell me some details about what system produced this failure?
The python version used to run the test would be good, as well as distro
release, kernel version, etc.
If you can reproduce it, I might want to give you a test branch of the
python code to produce some extra debugging information to help me
understand what's gone wrong here. Get in touch on IRC when you have some
spare time if you'd like to interactively debug it.
--js
[-- Attachment #2: Type: text/html, Size: 3605 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 18:13 ` John Snow
@ 2021-11-17 19:45 ` Thomas Huth
2021-11-17 19:59 ` John Snow
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2021-11-17 19:45 UTC (permalink / raw)
To: John Snow
Cc: Kevin Wolf, Hanna Reitz, Daniel P. Berrange, QEMU Developers,
Qemu-block
On 17/11/2021 19.13, John Snow wrote:
>
>
> On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
>
>
> Hi!
>
> I think it has been working fine for me a couple of weeks ago,
> but when I now run:
>
> make check SPEED=slow
>
> I'm getting a couple of failing iotests... not sure whether
> these are known issues already, so I thought I'd summarize them
> here:
>
> *** First one is 045 in raw mode: ***
>
> TEST iotest-raw: 045 [fail]
> QEMU --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> -nodefaults -display none -accel qtest
> QEMU_IMG --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
> writeback --aio threads -f raw
> QEMU_NBD --
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- raw
> IMGPROTO -- file
> PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
> TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmphlexdrlt
> GDB_OPTIONS --
> VALGRIND_QEMU --
> PRINT_QEMU_OUTPUT --
>
> --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
> +++ 045.out.bad
> @@ -1,5 +1,77 @@
> -...........
> +......EE.EE <http://EE.EE>
> +======================================================================
> +ERROR: test_add_fd (__main__.TestSCMFd)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in
> test_add_fd
> + self._send_fd_by_SCM()
> + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> _send_fd_by_SCM
> + ret = self.vm.send_fd_scm(file_path=image0)
> + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> 229, in send_fd_scm
> + self._qmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
> in send_fd_scm
> + self._aqmp.send_fd_scm(fd)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149,
> in _wrapper
> + return func(proto, *args, **kwargs)
> + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> 644, in send_fd_scm
> + sock = sock._sock # pylint: disable=protected-access
> +AttributeError: 'socket' object has no attribute '_sock'
>
>
> Well, that's not good.
>
> Can you tell me some details about what system produced this failure?
> The python version used to run the test would be good, as well as distro
> release, kernel version, etc.
>
> If you can reproduce it, I might want to give you a test branch of the
> python code to produce some extra debugging information to help me
> understand what's gone wrong here. Get in touch on IRC when you have some
> spare time if you'd like to interactively debug it.
As you likely saw in Hanna's mail a little bit later, the problem was the
old version of pylint. I did still have version 2.2 installed - after
upgrading, the problem went away.
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 19:45 ` Thomas Huth
@ 2021-11-17 19:59 ` John Snow
2021-11-17 21:32 ` Thomas Huth
0 siblings, 1 reply; 10+ messages in thread
From: John Snow @ 2021-11-17 19:59 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, Hanna Reitz, Daniel P. Berrange, QEMU Developers,
Qemu-block
[-- Attachment #1: Type: text/plain, Size: 3662 bytes --]
On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <thuth@redhat.com> wrote:
> On 17/11/2021 19.13, John Snow wrote:
> >
> >
> > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com
> > <mailto:thuth@redhat.com>> wrote:
> >
> >
> > Hi!
> >
> > I think it has been working fine for me a couple of weeks ago,
> > but when I now run:
> >
> > make check SPEED=slow
> >
> > I'm getting a couple of failing iotests... not sure whether
> > these are known issues already, so I thought I'd summarize them
> > here:
> >
> > *** First one is 045 in raw mode: ***
> >
> > TEST iotest-raw: 045 [fail]
> > QEMU --
> >
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> > -nodefaults -display none -accel qtest
> > QEMU_IMG --
> > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> > QEMU_IO --
> > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
> > writeback --aio threads -f raw
> > QEMU_NBD --
> > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> > IMGFMT -- raw
> > IMGPROTO -- file
> > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
> > TEST_DIR --
> /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> > SOCK_DIR -- /tmp/tmphlexdrlt
> > GDB_OPTIONS --
> > VALGRIND_QEMU --
> > PRINT_QEMU_OUTPUT --
> >
> > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
> > +++ 045.out.bad
> > @@ -1,5 +1,77 @@
> > -...........
> > +......EE.EE <http://EE.EE>
> >
> +======================================================================
> > +ERROR: test_add_fd (__main__.TestSCMFd)
> >
> +----------------------------------------------------------------------
> > +Traceback (most recent call last):
> > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in
> > test_add_fd
> > + self._send_fd_by_SCM()
> > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> > _send_fd_by_SCM
> > + ret = self.vm.send_fd_scm(file_path=image0)
> > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> > 229, in send_fd_scm
> > + self._qmp.send_fd_scm(fd)
> > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line
> 138,
> > in send_fd_scm
> > + self._aqmp.send_fd_scm(fd)
> > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
> 149,
> > in _wrapper
> > + return func(proto, *args, **kwargs)
> > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> > 644, in send_fd_scm
> > + sock = sock._sock # pylint: disable=protected-access
> > +AttributeError: 'socket' object has no attribute '_sock'
> >
> >
> > Well, that's not good.
> >
> > Can you tell me some details about what system produced this failure?
> > The python version used to run the test would be good, as well as distro
> > release, kernel version, etc.
> >
> > If you can reproduce it, I might want to give you a test branch of the
> > python code to produce some extra debugging information to help me
> > understand what's gone wrong here. Get in touch on IRC when you have
> some
> > spare time if you'd like to interactively debug it.
>
> As you likely saw in Hanna's mail a little bit later, the problem was the
> old version of pylint. I did still have version 2.2 installed - after
> upgrading, the problem went away.
>
>
upgrading pylint made *this* problem in *045* go away and not just the
failure in *297*, are you positive?
[-- Attachment #2: Type: text/html, Size: 5108 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 19:59 ` John Snow
@ 2021-11-17 21:32 ` Thomas Huth
2021-11-17 22:25 ` John Snow
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2021-11-17 21:32 UTC (permalink / raw)
To: John Snow
Cc: Kevin Wolf, Hanna Reitz, Daniel P. Berrange, QEMU Developers,
Qemu-block
On 17/11/2021 20.59, John Snow wrote:
>
>
> On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
>
> On 17/11/2021 19.13, John Snow wrote:
> >
> >
> > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>
> > <mailto:thuth@redhat.com <mailto:thuth@redhat.com>>> wrote:
> >
> >
> > Hi!
> >
> > I think it has been working fine for me a couple of weeks ago,
> > but when I now run:
> >
> > make check SPEED=slow
> >
> > I'm getting a couple of failing iotests... not sure whether
> > these are known issues already, so I thought I'd summarize them
> > here:
> >
> > *** First one is 045 in raw mode: ***
> >
> > TEST iotest-raw: 045 [fail]
> > QEMU --
> >
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> > -nodefaults -display none -accel qtest
> > QEMU_IMG --
> > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> > QEMU_IO --
> > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
> > writeback --aio threads -f raw
> > QEMU_NBD --
> > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> > IMGFMT -- raw
> > IMGPROTO -- file
> > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
> > TEST_DIR --
> /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> > SOCK_DIR -- /tmp/tmphlexdrlt
> > GDB_OPTIONS --
> > VALGRIND_QEMU --
> > PRINT_QEMU_OUTPUT --
> >
> > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
> > +++ 045.out.bad
> > @@ -1,5 +1,77 @@
> > -...........
> > +......EE.EE <http://EE.EE> <http://EE.EE <http://EE.EE>>
> >
> +======================================================================
> > +ERROR: test_add_fd (__main__.TestSCMFd)
> >
> +----------------------------------------------------------------------
> > +Traceback (most recent call last):
> > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in
> > test_add_fd
> > + self._send_fd_by_SCM()
> > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
> > _send_fd_by_SCM
> > + ret = self.vm.send_fd_scm(file_path=image0)
> > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> > 229, in send_fd_scm
> > + self._qmp.send_fd_scm(fd)
> > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line
> 138,
> > in send_fd_scm
> > + self._aqmp.send_fd_scm(fd)
> > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py",
> line 149,
> > in _wrapper
> > + return func(proto, *args, **kwargs)
> > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> > 644, in send_fd_scm
> > + sock = sock._sock # pylint: disable=protected-access
> > +AttributeError: 'socket' object has no attribute '_sock'
> >
> >
> > Well, that's not good.
> >
> > Can you tell me some details about what system produced this failure?
> > The python version used to run the test would be good, as well as distro
> > release, kernel version, etc.
> >
> > If you can reproduce it, I might want to give you a test branch of the
> > python code to produce some extra debugging information to help me
> > understand what's gone wrong here. Get in touch on IRC when you have
> some
> > spare time if you'd like to interactively debug it.
>
> As you likely saw in Hanna's mail a little bit later, the problem was the
> old version of pylint. I did still have version 2.2 installed - after
> upgrading, the problem went away.
>
>
> upgrading pylint made *this* problem in *045* go away and not just the
> failure in *297*, are you positive?
Ah, no, of course not, I just mixed them up :-/
(For the records, as already discussed on IRC: It's Python 2.6.8 from RHEL8
where the problem occurred)
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Failing QEMU iotests
2021-11-17 21:32 ` Thomas Huth
@ 2021-11-17 22:25 ` John Snow
0 siblings, 0 replies; 10+ messages in thread
From: John Snow @ 2021-11-17 22:25 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, Hanna Reitz, Daniel P. Berrange, QEMU Developers,
Qemu-block
[-- Attachment #1: Type: text/plain, Size: 5265 bytes --]
On Wed, Nov 17, 2021 at 4:33 PM Thomas Huth <thuth@redhat.com> wrote:
> On 17/11/2021 20.59, John Snow wrote:
> >
> >
> > On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <thuth@redhat.com
> > <mailto:thuth@redhat.com>> wrote:
> >
> > On 17/11/2021 19.13, John Snow wrote:
> > >
> > >
> > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com
> > <mailto:thuth@redhat.com>
> > > <mailto:thuth@redhat.com <mailto:thuth@redhat.com>>> wrote:
> > >
> > >
> > > Hi!
> > >
> > > I think it has been working fine for me a couple of weeks ago,
> > > but when I now run:
> > >
> > > make check SPEED=slow
> > >
> > > I'm getting a couple of failing iotests... not sure whether
> > > these are known issues already, so I thought I'd summarize
> them
> > > here:
> > >
> > > *** First one is 045 in raw mode: ***
> > >
> > > TEST iotest-raw: 045 [fail]
> > > QEMU --
> > >
> >
> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
> > > -nodefaults -display none -accel qtest
> > > QEMU_IMG --
> > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
> > > QEMU_IO --
> > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io"
> --cache
> > > writeback --aio threads -f raw
> > > QEMU_NBD --
> > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
> > > IMGFMT -- raw
> > > IMGPROTO -- file
> > > PLATFORM -- Linux/x86_64 thuth
> 4.18.0-305.19.1.el8_4.x86_64
> > > TEST_DIR --
> > /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
> > > SOCK_DIR -- /tmp/tmphlexdrlt
> > > GDB_OPTIONS --
> > > VALGRIND_QEMU --
> > > PRINT_QEMU_OUTPUT --
> > >
> > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
> > > +++ 045.out.bad
> > > @@ -1,5 +1,77 @@
> > > -...........
> > > +......EE.EE <http://EE.EE> <http://EE.EE <http://EE.EE>>
> > >
> >
> +======================================================================
> > > +ERROR: test_add_fd (__main__.TestSCMFd)
> > >
> >
> +----------------------------------------------------------------------
> > > +Traceback (most recent call last):
> > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line
> 148, in
> > > test_add_fd
> > > + self._send_fd_by_SCM()
> > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line
> 144, in
> > > _send_fd_by_SCM
> > > + ret = self.vm.send_fd_scm(file_path=image0)
> > > + File
> "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
> > > 229, in send_fd_scm
> > > + self._qmp.send_fd_scm(fd)
> > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py",
> line
> > 138,
> > > in send_fd_scm
> > > + self._aqmp.send_fd_scm(fd)
> > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py",
> > line 149,
> > > in _wrapper
> > > + return func(proto, *args, **kwargs)
> > > + File
> "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
> > > 644, in send_fd_scm
> > > + sock = sock._sock # pylint: disable=protected-access
> > > +AttributeError: 'socket' object has no attribute '_sock'
> > >
> > >
> > > Well, that's not good.
> > >
> > > Can you tell me some details about what system produced this
> failure?
> > > The python version used to run the test would be good, as well as
> distro
> > > release, kernel version, etc.
> > >
> > > If you can reproduce it, I might want to give you a test branch
> of the
> > > python code to produce some extra debugging information to help me
> > > understand what's gone wrong here. Get in touch on IRC when you
> have
> > some
> > > spare time if you'd like to interactively debug it.
> >
> > As you likely saw in Hanna's mail a little bit later, the problem
> was the
> > old version of pylint. I did still have version 2.2 installed - after
> > upgrading, the problem went away.
> >
> >
> > upgrading pylint made *this* problem in *045* go away and not just the
> > failure in *297*, are you positive?
>
> Ah, no, of course not, I just mixed them up :-/
>
>
I was able to repro, I have a fix on the way but I am doing additional
testing.
I still have a fix prepared for some device-crash-test behaviors, but I
found ... another bug that's even more annoying, so there is more
development and testing to do there.
(New problem is: device-crash-test does not set a timeout for QMP
connections, so if the binary dies entirely before it dials out to connect
to the QMP library in python at all, we will just hang waiting forever. I
don't think this is specific to the Async QMP library, either -- it's a
problem in machine.py. The iotests users all set a timeout, FWIW, but this
is still less than ideal ...)
[-- Attachment #2: Type: text/html, Size: 7757 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-11-17 22:27 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17 10:07 Failing QEMU iotests Thomas Huth
2021-11-17 10:59 ` Hanna Reitz
2021-11-17 12:50 ` Thomas Huth
2021-11-17 14:46 ` Daniel P. Berrangé
2021-11-17 18:06 ` John Snow
2021-11-17 18:13 ` John Snow
2021-11-17 19:45 ` Thomas Huth
2021-11-17 19:59 ` John Snow
2021-11-17 21:32 ` Thomas Huth
2021-11-17 22:25 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).