From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6919C433F5 for ; Wed, 17 Nov 2021 20:01:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ADF761BE1 for ; Wed, 17 Nov 2021 20:01:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1ADF761BE1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnR7g-0005u5-VR for qemu-devel@archiver.kernel.org; Wed, 17 Nov 2021 15:01:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnR5l-0004N4-8d for qemu-devel@nongnu.org; Wed, 17 Nov 2021 14:59:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:31362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnR5i-0002SB-BX for qemu-devel@nongnu.org; Wed, 17 Nov 2021 14:59:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637179173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/LEnvswbltrXOPW0aj6zIgLwCVa3Lon58I/mB6Q8ryk=; b=bOt4ys8hH0vVE6QTyjmsoS0FZxow2p54j14Lggvh9G+reuvM6NgASgPaU50wH6SEojtALt fXsjQAeHhdNn1YHSdt/fk9D6LZJWUeIpoCRr4yGmdDbc+jFuxGXxVVJ9TwP8P/b5l8v3iq 4KrKJ89j3ZBNC7OG4gmu4R1NbfkQhf0= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-G5-ZvjQdOBizbjPyQHTRag-1; Wed, 17 Nov 2021 14:59:29 -0500 X-MC-Unique: G5-ZvjQdOBizbjPyQHTRag-1 Received: by mail-vk1-f197.google.com with SMTP id m25-20020a056122215900b002fac70f81c1so1904028vkd.5 for ; Wed, 17 Nov 2021 11:59:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/LEnvswbltrXOPW0aj6zIgLwCVa3Lon58I/mB6Q8ryk=; b=g+PiBEN1k4hb3U3kl++rFpvlQbUc6l6YAjyKomUwDpPxSbJQOD5NWJSisynNp0kY5k eA9dEhTa8+veZV8kNryBYvshByspRtK7aFIB1UDzkQgB9cchYS6CbIG6zYOZTzzII/Ei urfsdzlz4u7/cIJ9jJDck+YbAOQxIeNETLG37ZiGKvqmt7e1SWq22m51rngqwbKYasgS P7kXZpcc+NRUDTCZbYvmnQBDH8xZRXLotbp8PKc1WqfLkC8NoUc97Wln8Yjy93DbKsUB 419DGjqkZY0Ew7RP/hCkanN2VoG7AOehBaKmYVPM/Q1030VbMH3g2S6wGZvXGOladJ9b 6fQA== X-Gm-Message-State: AOAM530zLY3hxSwExsF6JyRLnMBvZqwFgiYdNsvwPiBZNNKoyfKLHbKP IYVtqeHWnlYpaRxXk96L7KdF/23e2nrOVYJaVrJNVDPSzWifhqH+cTZwEZk6LxC1xV1D64gA3Dz pdlzHrKAvJNbTgvJiRn122WhKpgXKWzw= X-Received: by 2002:a67:cf45:: with SMTP id f5mr12591246vsm.31.1637179169303; Wed, 17 Nov 2021 11:59:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJyw/UrWk1COShZ5mS4sakks80XRAvk5ANd0M3EnqM33y8QkxU27sFG+hXyChi5ZUBNpx3WQbCG2tap9+hWEel4= X-Received: by 2002:a67:cf45:: with SMTP id f5mr12591205vsm.31.1637179169095; Wed, 17 Nov 2021 11:59:29 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: John Snow Date: Wed, 17 Nov 2021 14:59:18 -0500 Message-ID: Subject: Re: Failing QEMU iotests To: Thomas Huth Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000ced5a305d1017a06" Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.701, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Hanna Reitz , "Daniel P. Berrange" , QEMU Developers , Qemu-block Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000ced5a305d1017a06 Content-Type: text/plain; charset="UTF-8" On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth wrote: > On 17/11/2021 19.13, John Snow wrote: > > > > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth > > wrote: > > > > > > Hi! > > > > I think it has been working fine for me a couple of weeks ago, > > but when I now run: > > > > make check SPEED=slow > > > > I'm getting a couple of failing iotests... not sure whether > > these are known issues already, so I thought I'd summarize them > > here: > > > > *** First one is 045 in raw mode: *** > > > > TEST iotest-raw: 045 [fail] > > QEMU -- > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > > -nodefaults -display none -accel qtest > > QEMU_IMG -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > > QEMU_IO -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > > writeback --aio threads -f raw > > QEMU_NBD -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > > IMGFMT -- raw > > IMGPROTO -- file > > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > > TEST_DIR -- > /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > > SOCK_DIR -- /tmp/tmphlexdrlt > > GDB_OPTIONS -- > > VALGRIND_QEMU -- > > PRINT_QEMU_OUTPUT -- > > > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > > +++ 045.out.bad > > @@ -1,5 +1,77 @@ > > -........... > > +......EE.EE > > > +====================================================================== > > +ERROR: test_add_fd (__main__.TestSCMFd) > > > +---------------------------------------------------------------------- > > +Traceback (most recent call last): > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in > > test_add_fd > > + self._send_fd_by_SCM() > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > > _send_fd_by_SCM > > + ret = self.vm.send_fd_scm(file_path=image0) > > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > > 229, in send_fd_scm > > + self._qmp.send_fd_scm(fd) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line > 138, > > in send_fd_scm > > + self._aqmp.send_fd_scm(fd) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line > 149, > > in _wrapper > > + return func(proto, *args, **kwargs) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > > 644, in send_fd_scm > > + sock = sock._sock # pylint: disable=protected-access > > +AttributeError: 'socket' object has no attribute '_sock' > > > > > > Well, that's not good. > > > > Can you tell me some details about what system produced this failure? > > The python version used to run the test would be good, as well as distro > > release, kernel version, etc. > > > > If you can reproduce it, I might want to give you a test branch of the > > python code to produce some extra debugging information to help me > > understand what's gone wrong here. Get in touch on IRC when you have > some > > spare time if you'd like to interactively debug it. > > As you likely saw in Hanna's mail a little bit later, the problem was the > old version of pylint. I did still have version 2.2 installed - after > upgrading, the problem went away. > > upgrading pylint made *this* problem in *045* go away and not just the failure in *297*, are you positive? --000000000000ced5a305d1017a06 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Nov 17, 2021 at 2:45 PM Thoma= s Huth <thuth@redhat.com> wro= te:
On 17/11/202= 1 19.13, John Snow wrote:
>
>
> On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com
> <mailto:thuth= @redhat.com>> wrote:
>
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Hi!
>
>=C2=A0 =C2=A0 =C2=A0I think it has been working fine for me a couple of= weeks ago,
>=C2=A0 =C2=A0 =C2=A0but when I now run:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 make check SPEED=3Dslow
>
>=C2=A0 =C2=A0 =C2=A0I'm getting a couple of failing iotests... not = sure whether
>=C2=A0 =C2=A0 =C2=A0these are known issues already, so I thought I'= d summarize them
>=C2=A0 =C2=A0 =C2=A0here:
>
>=C2=A0 =C2=A0 =C2=A0*** First one is 045 in raw mode: ***
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 TEST=C2=A0 =C2=A0iotest-raw: 045 [fail]
>=C2=A0 =C2=A0 =C2=A0QEMU=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --
>=C2=A0 =C2=A0 =C2=A0"/home/thuth/tmp/qemu-build/tests/qemu-iotests= /../../qemu-system-x86_64"
>=C2=A0 =C2=A0 =C2=A0-nodefaults -display none -accel qtest
>=C2=A0 =C2=A0 =C2=A0QEMU_IMG=C2=A0 =C2=A0 =C2=A0 --
>=C2=A0 =C2=A0 =C2=A0"/home/thuth/tmp/qemu-build/tests/qemu-iotests= /../../qemu-img"
>=C2=A0 =C2=A0 =C2=A0QEMU_IO=C2=A0 =C2=A0 =C2=A0 =C2=A0--
>=C2=A0 =C2=A0 =C2=A0"/home/thuth/tmp/qemu-build/tests/qemu-iotests= /../../qemu-io" --cache
>=C2=A0 =C2=A0 =C2=A0writeback --aio threads -f raw
>=C2=A0 =C2=A0 =C2=A0QEMU_NBD=C2=A0 =C2=A0 =C2=A0 --
>=C2=A0 =C2=A0 =C2=A0"/home/thuth/tmp/qemu-build/tests/qemu-iotests= /../../qemu-nbd"
>=C2=A0 =C2=A0 =C2=A0IMGFMT=C2=A0 =C2=A0 =C2=A0 =C2=A0 -- raw
>=C2=A0 =C2=A0 =C2=A0IMGPROTO=C2=A0 =C2=A0 =C2=A0 -- file
>=C2=A0 =C2=A0 =C2=A0PLATFORM=C2=A0 =C2=A0 =C2=A0 -- Linux/x86_64 thuth = 4.18.0-305.19.1.el8_4.x86_64
>=C2=A0 =C2=A0 =C2=A0TEST_DIR=C2=A0 =C2=A0 =C2=A0 -- /home/thuth/tmp/qem= u-build/tests/qemu-iotests/scratch
>=C2=A0 =C2=A0 =C2=A0SOCK_DIR=C2=A0 =C2=A0 =C2=A0 -- /tmp/tmphlexdrlt >=C2=A0 =C2=A0 =C2=A0GDB_OPTIONS=C2=A0 =C2=A0--
>=C2=A0 =C2=A0 =C2=A0VALGRIND_QEMU --
>=C2=A0 =C2=A0 =C2=A0PRINT_QEMU_OUTPUT --
>
>=C2=A0 =C2=A0 =C2=A0--- /home/thuth/devel/qemu/tests/qemu-iotests/045.o= ut
>=C2=A0 =C2=A0 =C2=A0+++ 045.out.bad
>=C2=A0 =C2=A0 =C2=A0@@ -1,5 +1,77 @@
>=C2=A0 =C2=A0 =C2=A0-...........
>=C2=A0 =C2=A0 =C2=A0+......EE.EE <http://EE.EE>
>=C2=A0 =C2=A0 =C2=A0+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
>=C2=A0 =C2=A0 =C2=A0+ERROR: test_add_fd (__main__.TestSCMFd)
>=C2=A0 =C2=A0 =C2=A0+--------------------------------------------------= --------------------
>=C2=A0 =C2=A0 =C2=A0+Traceback (most recent call last):
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 File "/home/thuth/devel/qemu/tests/qem= u-iotests/045", line 148, in
>=C2=A0 =C2=A0 =C2=A0test_add_fd
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 self._send_fd_by_SCM()
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 File "/home/thuth/devel/qemu/tests/qem= u-iotests/045", line 144, in
>=C2=A0 =C2=A0 =C2=A0_send_fd_by_SCM
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 ret =3D self.vm.send_fd_scm(file_pat= h=3Dimage0)
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 File "/home/thuth/devel/qemu/python/qe= mu/machine/machine.py", line
>=C2=A0 =C2=A0 =C2=A0229, in send_fd_scm
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 self._qmp.send_fd_scm(fd)
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 File "/home/thuth/devel/qemu/python/qe= mu/aqmp/legacy.py", line 138,
>=C2=A0 =C2=A0 =C2=A0in send_fd_scm
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 self._aqmp.send_fd_scm(fd)
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 File "/home/thuth/devel/qemu/python/qe= mu/aqmp/protocol.py", line 149,
>=C2=A0 =C2=A0 =C2=A0in _wrapper
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 return func(proto, *args, **kwargs)<= br> >=C2=A0 =C2=A0 =C2=A0+=C2=A0 File "/home/thuth/devel/qemu/python/qe= mu/aqmp/qmp_client.py", line
>=C2=A0 =C2=A0 =C2=A0644, in send_fd_scm
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 sock =3D sock._sock=C2=A0 # pylint: = disable=3Dprotected-access
>=C2=A0 =C2=A0 =C2=A0+AttributeError: 'socket' object has no att= ribute '_sock'
>
>
> Well, that's not good.
>
> Can you tell me some details about what system produced this failure?<= br> > The python version used to run the test would be good, as well as dist= ro
> release, kernel version, etc.
>
> If you can reproduce it, I might want to give you a test branch of the=
> python code to produce some extra debugging information to help me > understand what's gone wrong here. Get in touch on IRC when you ha= ve some
> spare time if you'd like to interactively debug it.

As you likely saw in Hanna's mail a little bit later, the problem was t= he
old version of pylint. I did still have version 2.2 installed - after
upgrading, the problem went away.


upgrading pylint made *this* problem i= n *045* go away and not just the failure in *297*, are you positive?
--000000000000ced5a305d1017a06--