From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Michael Roth <michael.roth@amd.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments
Date: Fri, 1 Oct 2021 14:55:20 -0400 [thread overview]
Message-ID: <CAFn=p-YWF3PyZw=EUgFrym5EqSFDPmYJnoHh84msmJfiY2tzfQ@mail.gmail.com> (raw)
In-Reply-To: <87h7e0vnr9.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Fri, Oct 1, 2021 at 10:11 AM Markus Armbruster <armbru@redhat.com> wrote:
> John Snow <jsnow@redhat.com> writes:
>
> > Pylint informs us we're not using these arguments. Oops, it's
> > right. Correct the error message and remove the remaining unused
> > parameter.
> >
> > Fix test output now that the error message is improved.
> > Fixes: e151941d1b
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> In v3, the blank line was where it belongs:
>
> Fix test output now that the error message is improved.
>
> Fixes: e151941d1b
> Signed-off-by: John Snow <jsnow@redhat.com>
>
> The change looks accidental. Can tidy up in my tree.
>
Yes please, thank you :)
[-- Attachment #2: Type: text/html, Size: 1282 bytes --]
next prev parent reply other threads:[~2021-10-01 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 20:57 [PATCH v4 00/13] qapi: static typing conversion, pt5b John Snow
2021-09-30 20:57 ` [PATCH v4 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning John Snow
2021-09-30 20:57 ` [PATCH v4 02/13] qapi/gen: use dict.items() to iterate over _modules John Snow
2021-09-30 20:57 ` [PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments John Snow
2021-10-01 14:11 ` Markus Armbruster
2021-10-01 18:55 ` John Snow [this message]
2021-09-30 20:57 ` [PATCH v4 04/13] qapi: Add spaces after symbol declaration for consistency John Snow
2021-09-30 20:57 ` [PATCH v4 05/13] qapi/parser: remove FIXME comment from _append_body_line John Snow
2021-09-30 20:57 ` [PATCH v4 06/13] qapi/parser: clarify _end_section() logic John Snow
2021-09-30 20:57 ` [PATCH v4 07/13] qapi/parser: Introduce NullSection John Snow
2021-09-30 20:57 ` [PATCH v4 08/13] qapi/parser: add import cycle workaround John Snow
2021-09-30 20:57 ` [PATCH v4 09/13] qapi/parser: add type hint annotations (QAPIDoc) John Snow
2021-09-30 20:57 ` [PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related types John Snow
2021-09-30 20:57 ` [PATCH v4 11/13] qapi/parser: enable mypy checks John Snow
2021-09-30 20:57 ` [PATCH v4 12/13] qapi/parser: Silence too-few-public-methods warning John Snow
2021-09-30 20:57 ` [PATCH v4 13/13] qapi/parser: enable pylint checks John Snow
2021-10-01 14:11 ` [PATCH v4 00/13] qapi: static typing conversion, pt5b Markus Armbruster
2021-10-02 6:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-YWF3PyZw=EUgFrym5EqSFDPmYJnoHh84msmJfiY2tzfQ@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).