From: John Snow <jsnow@redhat.com>
To: dinglimin <dinglimin@cmss.chinamobile.com>
Cc: thuth@redhat.com, alex.bennee@linaro.org, qemu-devel@nongnu.org,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] vmstate-static-checker:remove this redundant return
Date: Thu, 13 Oct 2022 18:36:29 -0400 [thread overview]
Message-ID: <CAFn=p-Yw3mjzfV-WaaX+D4zVGrPQ_zcrVXf9U2+7TRuBuLNEog@mail.gmail.com> (raw)
In-Reply-To: <20220928090312.2537-1-dinglimin@cmss.chinamobile.com>
On Wed, Sep 28, 2022 at 5:06 AM dinglimin
<dinglimin@cmss.chinamobile.com> wrote:
>
> Jump statements, such as return and continue let you
> change the default flow of program execution,
> but jump statements that direct the control flow to
> the original direction are just a waste of keystrokes.
>
> Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com>
> ---
> scripts/vmstate-static-checker.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/vmstate-static-checker.py b/scripts/vmstate-static-checker.py
> index b369388360..dfeee8231a 100755
> --- a/scripts/vmstate-static-checker.py
> +++ b/scripts/vmstate-static-checker.py
> @@ -367,7 +367,6 @@ def check_machine_type(s, d):
> if s["Name"] != d["Name"]:
> print("Warning: checking incompatible machine types:", end=' ')
> print("\"" + s["Name"] + "\", \"" + d["Name"] + "\"")
> - return
>
>
> def main():
> --
> 2.30.0.windows.2
>
This can go through the trivial branch.
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2022-10-13 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:03 [PATCH] vmstate-static-checker:remove this redundant return dinglimin
2022-10-13 22:36 ` John Snow [this message]
2022-10-22 21:19 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-Yw3mjzfV-WaaX+D4zVGrPQ_zcrVXf9U2+7TRuBuLNEog@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dinglimin@cmss.chinamobile.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).