From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>,
Qemu-block <qemu-block@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
v.sementsov-og@ya.ru, yuriy.vasiliev@virtuozzo.com
Subject: Re: [PATCH v2 1/3] qapi: rename BlockDirtyBitmapMergeSource to BlockDirtyBitmapOrStr
Date: Tue, 22 Mar 2022 21:31:55 -0400 [thread overview]
Message-ID: <CAFn=p-ZLmQDPHk5yYQN6gHDDOxQ3KxKAoOjAg_c--ZX5CiwSZA@mail.gmail.com> (raw)
In-Reply-To: <20220316211840.cq7m3ji4m2y6drgi@redhat.com>
On Wed, Mar 16, 2022 at 5:18 PM Eric Blake <eblake@redhat.com> wrote:
>
> On Tue, Mar 15, 2022 at 12:32:24AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> >
> > Rename the type to be reused. Old name is "what is it for". To be
> > natively reused for other needs, let's name it exactly "what is it".
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <v.sementsov-og@ya.ru>
> > ---
> > block/monitor/bitmap-qmp-cmds.c | 6 +++---
> > include/block/block_int-global-state.h | 2 +-
> > qapi/block-core.json | 6 +++---
> > qemu-img.c | 8 ++++----
> > 4 files changed, 11 insertions(+), 11 deletions(-)
>
> The type name does not affect QAPI interface stability, so this is safe.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Sounds right.
Acked-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2022-03-23 1:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 21:32 [PATCH v2 for-7.1 0/3] qapi: nbd-export: select bitmap by node/name pair Vladimir Sementsov-Ogievskiy
2022-03-14 21:32 ` [PATCH v2 1/3] qapi: rename BlockDirtyBitmapMergeSource to BlockDirtyBitmapOrStr Vladimir Sementsov-Ogievskiy
2022-03-16 21:18 ` Eric Blake
2022-03-23 1:31 ` John Snow [this message]
2022-03-14 21:32 ` [PATCH v2 2/3] qapi: nbd-export: allow select bitmaps by node/name pair Vladimir Sementsov-Ogievskiy
2022-03-16 21:28 ` Eric Blake
2022-03-21 11:50 ` Vladimir Sementsov-Ogievskiy
2022-03-21 13:30 ` Eric Blake
2022-04-08 20:27 ` Vladimir Sementsov-Ogievskiy
2022-04-22 20:04 ` Eric Blake
2022-03-14 21:32 ` [PATCH v2 3/3] iotests/223: check new possibility of exporting bitmaps by node/name Vladimir Sementsov-Ogievskiy
2022-03-16 22:01 ` Eric Blake
2022-03-14 21:45 ` [PATCH v2 for-7.1 0/3] qapi: nbd-export: select bitmap by node/name pair Vladimir Sementsov-Ogievskiy
2022-04-22 20:09 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-ZLmQDPHk5yYQN6gHDDOxQ3KxKAoOjAg_c--ZX5CiwSZA@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@mail.ru \
--cc=v.sementsov-og@ya.ru \
--cc=vsementsov@virtuozzo.com \
--cc=yuriy.vasiliev@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).