From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, crosa@redhat.com,
kwolf@redhat.com, hreitz@redhat.com
Subject: Re: [PATCH v5 01/16] python: fix superfluous-parens pylint error
Date: Mon, 20 Feb 2023 15:37:30 -0500 [thread overview]
Message-ID: <CAFn=p-ZS5dis8Q2DWcFrXAEJuj0ek0K0fJ8Whdk9mh=djLAmPg@mail.gmail.com> (raw)
In-Reply-To: <20230215132547.1620575-2-vsementsov@yandex-team.ru>
On Wed, Feb 15, 2023 at 8:26 AM Vladimir Sementsov-Ogievskiy
<vsementsov@yandex-team.ru> wrote:
>
> Now make check-dev called in python/ directory fails due to this error.
> Let's fix it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: John Snow <jsnow@redhat.com>
I've got a similar patch queued already in jsnow/python, I'll send the PR soon.
--js
> ---
> python/qemu/qmp/protocol.py | 2 +-
> python/qemu/qmp/qmp_client.py | 2 +-
> tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py
> index 6d3d739daa..22e60298d2 100644
> --- a/python/qemu/qmp/protocol.py
> +++ b/python/qemu/qmp/protocol.py
> @@ -207,7 +207,7 @@ class AsyncProtocol(Generic[T]):
> logger = logging.getLogger(__name__)
>
> # Maximum allowable size of read buffer
> - _limit = (64 * 1024)
> + _limit = 64 * 1024
>
> # -------------------------
> # Section: Public interface
> diff --git a/python/qemu/qmp/qmp_client.py b/python/qemu/qmp/qmp_client.py
> index b5772e7f32..9d73ae6e7a 100644
> --- a/python/qemu/qmp/qmp_client.py
> +++ b/python/qemu/qmp/qmp_client.py
> @@ -198,7 +198,7 @@ async def run(self, address='/tmp/qemu.socket'):
> logger = logging.getLogger(__name__)
>
> # Read buffer limit; 10MB like libvirt default
> - _limit = (10 * 1024 * 1024)
> + _limit = 10 * 1024 * 1024
>
> # Type alias for pending execute() result items
> _PendingT = Union[Message, ExecInterruptedError]
> diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> index fc9c4b4ef4..dda55fad28 100755
> --- a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> +++ b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> @@ -84,7 +84,7 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
> e['vm'] = 'SRC'
> for e in self.vm_b_events:
> e['vm'] = 'DST'
> - events = (self.vm_a_events + self.vm_b_events)
> + events = self.vm_a_events + self.vm_b_events
> events = [(e['timestamp']['seconds'],
> e['timestamp']['microseconds'],
> e['vm'],
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-02-20 20:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 13:25 [PATCH v5 00/16] iotests: use vm.cmd() Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 01/16] python: fix superfluous-parens pylint error Vladimir Sementsov-Ogievskiy
2023-02-20 20:37 ` John Snow [this message]
2023-02-15 13:25 ` [PATCH v5 02/16] python: fix broad-exception-raised " Vladimir Sementsov-Ogievskiy
2023-02-20 20:38 ` John Snow
2023-02-15 13:25 ` [PATCH v5 03/16] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 04/16] qmp_shell.py: _fill_completion() use .command() instead of .cmd() Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 05/16] scripts/cpu-x86-uarch-abi.py: " Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 07/16] python/qemu: rename command() to cmd() Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 08/16] python/machine.py: upgrade vm.cmd() method Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 09/16] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 10/16] iotests: add some missed checks of qmp result Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 11/16] iotests: refactor some common qmp result checks into generic pattern Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 12/16] iotests: drop some occasional semicolons Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 13/16] iotests: drop some extra ** in qmp() call Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 14/16] iotests.py: pause_job(): drop return value Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 15/16] tests/vm/basevm.py: use cmd() instead of qmp() Vladimir Sementsov-Ogievskiy
2023-02-15 13:25 ` [PATCH v5 16/16] python: use vm.cmd() instead of vm.qmp() where appropriate Vladimir Sementsov-Ogievskiy
2023-04-21 11:59 ` [PATCH v5 00/16] iotests: use vm.cmd() Vladimir Sementsov-Ogievskiy
2023-06-13 15:48 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-ZS5dis8Q2DWcFrXAEJuj0ek0K0fJ8Whdk9mh=djLAmPg@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).