From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDCC2C433EF for ; Fri, 13 May 2022 14:15:56 +0000 (UTC) Received: from localhost ([::1]:49692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npW5D-0008QY-St for qemu-devel@archiver.kernel.org; Fri, 13 May 2022 10:15:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npW2A-0005IT-GH for qemu-devel@nongnu.org; Fri, 13 May 2022 10:12:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:46355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npW25-0001SG-Tx for qemu-devel@nongnu.org; Fri, 13 May 2022 10:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652451157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mm5m1OOG1CkbU2nDBLtgIqKXJMsHWwAruqxzFrEDzc0=; b=MM8pCn56o9efan4Fau26J+m4pGFPTQKbNXeG9JedgcgsS4u0psow/iwZRLsIj+sNbD6BsQ B0EdE/ZSV/8GLRC4UOmXP20MXN7z3IMTdRGchGqnxtISt1aK0Bs+Bvc5b6HePTSC1s6qjY ZNTYiKfN1RbOhTDYexQnC7VLU+80prU= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-DiPF2X-uP7KWRd1VEAD0GA-1; Fri, 13 May 2022 10:12:36 -0400 X-MC-Unique: DiPF2X-uP7KWRd1VEAD0GA-1 Received: by mail-ua1-f70.google.com with SMTP id c19-20020ab023d3000000b003627f7c63d4so3817252uan.13 for ; Fri, 13 May 2022 07:12:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mm5m1OOG1CkbU2nDBLtgIqKXJMsHWwAruqxzFrEDzc0=; b=qWxBcQxhUBQ8PdTQp7KklOLw5ECL5sDNL2VMl3yFx9MGWzJ3aisRy8mYyALPU9lE5d f788tZGQEujlXK5izGwUmM4wmCs+NfnL44j1EZath9hFveTu6/bovp0HRdHq+7894/FS zvX/r8MRbG/5ym02Sr0iZf1RUOJyOCZgz6PrxD8OQ98rlBa8/DWaIb97S+tX+aKnh3y9 GFnPX/nyHnrA0sR0KphNyMzr49c/xsAZnN+v6098dQcHwmZhTc+4vMKhh69iZ2K6NjSK smLyl7olAEWvDSiPTKbd7XARFZukuaJSi9BMuNgFb/E0C/6aRjvD8Xzwyp0s9HmrKmnz sWEg== X-Gm-Message-State: AOAM530xND1EgFdC+WNZIZ+MYLa03Ss1KtdaCjrImvCePTjQBscG97uz pWqk+hWAGsnE/QoxyOKtMUguj55FkEkd+coBxMiEaLg+sT+66oC+DRoHevzEnvksUi+xwYYnkBg WtvGMRFt4BCnBzFK0eItLUwC1AZNhafo= X-Received: by 2002:a1f:ce46:0:b0:34e:b018:c8a4 with SMTP id e67-20020a1fce46000000b0034eb018c8a4mr2239722vkg.26.1652451155720; Fri, 13 May 2022 07:12:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRN8QU8EM+3rdq7UJiCrqzlujo2qBsA8RF6rh959JEfeHoJk5nMtP3pvOAmoLtv4UF/2uhX5iD/tXOGeEUFn0= X-Received: by 2002:a1f:ce46:0:b0:34e:b018:c8a4 with SMTP id e67-20020a1fce46000000b0034eb018c8a4mr2239709vkg.26.1652451155479; Fri, 13 May 2022 07:12:35 -0700 (PDT) MIME-Version: 1.0 References: <20220513000609.197906-1-jsnow@redhat.com> <20220513000609.197906-7-jsnow@redhat.com> In-Reply-To: From: John Snow Date: Fri, 13 May 2022 10:12:24 -0400 Message-ID: Subject: Re: [RFC PATCH 6/9] tests: add check-venv as a dependency of check and check-block To: Paolo Bonzini Cc: qemu-devel , Qemu-block , Cleber Rosa , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Hanna Reitz , Thomas Huth , Daniel Berrange , Kevin Wolf , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Content-Type: multipart/alternative; boundary="00000000000021a52a05dee54474" Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000021a52a05dee54474 Content-Type: text/plain; charset="UTF-8" On Fri, May 13, 2022, 4:41 AM Paolo Bonzini wrote: > On 5/13/22 02:06, John Snow wrote: > > meson, create the python venv for block tests. > > +.PHONY: check-block > > +check-block: check-venv > > + @echo # Without some rule, this doesn't run at all. Why? > > + > > + > > # Consolidated targets > > > > .PHONY: check check-clean get-vm-images > > -check: > > +check: check-venv > > + @echo # ??? > > > > I think you need instead: > > # The do-meson-check and do-meson-bench targets are defined in > Makefile.mtest > do-meson-check do-meson-bench: check-venv > > and I would even add "all" to the targets that create the virtual > environment. > > Paolo > Great, thanks! I'll try that out today. --00000000000021a52a05dee54474 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, May 13, 2022, 4:41 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
On 5/13/22 02:06, John Snow wrote:
>=C2=A0 =C2=A0meson, create the python venv for block tests.
> +.PHONY: check-block
> +check-block: check-venv
> +=C2=A0 =C2=A0 =C2=A0@echo=C2=A0 # Without some rule, this doesn't= run at all. Why?
> +
> +
>=C2=A0 =C2=A0# Consolidated targets
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0.PHONY: check check-clean get-vm-images
> -check:
> +check: check-venv
> +=C2=A0 =C2=A0 =C2=A0@echo # ???
>=C2=A0 =C2=A0

I think you need instead:

# The do-meson-check and do-meson-bench targets are defined in Makefile.mte= st
do-meson-check do-meson-bench: check-venv

and I would even add "all" to the targets that create the virtual= environment.

Paolo

Great, thanks! I'll try that out today.

--00000000000021a52a05dee54474--