From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Fiona Ebner <f.ebner@proxmox.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] hw/ide/ahci: trace ncq write command as write instead of read
Date: Fri, 17 Feb 2023 15:12:11 -0500 [thread overview]
Message-ID: <CAFn=p-Zx_mSWjiF_uCv5wztm8novucQn-F644wnNVBjxnMkiuA@mail.gmail.com> (raw)
In-Reply-To: <3bfcd5cf-7564-6462-d1e6-65011e8bbe47@linaro.org>
On Fri, Feb 17, 2023 at 7:27 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> On 17/2/23 11:31, Fiona Ebner wrote:
> > Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
>
> Oops
Seconding the whoops.
>
> > Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> > ---
> >
> > Or should it be sorted alphabetically below execute_ncq_command_unsup?
>
> No, there is no convention...
>
> > I felt read and write belong close together and this reflects the
> > positions in the code.
>
> probably for this reason.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks!
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2023-02-17 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 10:31 [PATCH] hw/ide/ahci: trace ncq write command as write instead of read Fiona Ebner
2023-02-17 12:26 ` Philippe Mathieu-Daudé
2023-02-17 20:12 ` John Snow [this message]
2023-02-17 12:59 ` Alex Bennée
2023-02-20 8:12 ` Philippe Mathieu-Daudé
2023-02-20 19:04 ` John Snow
2023-02-21 11:32 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-Zx_mSWjiF_uCv5wztm8novucQn-F644wnNVBjxnMkiuA@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).