From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E241AC433F5 for ; Tue, 26 Oct 2021 18:14:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A279E60C4B for ; Tue, 26 Oct 2021 18:14:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A279E60C4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfQy4-0000JM-OK for qemu-devel@archiver.kernel.org; Tue, 26 Oct 2021 14:14:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfQmG-0002mk-Kg for qemu-devel@nongnu.org; Tue, 26 Oct 2021 14:02:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfQmD-0005eq-W5 for qemu-devel@nongnu.org; Tue, 26 Oct 2021 14:02:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635271339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RM2yRONY7GuPgPxTeaHdfNlqDcImWnb/nLUyNeRD77A=; b=DZXlPDIT4hbHjUgrBFOUNouXs9mMvK33sImFjTiCPGu5ELvEvFKVWzTPzbinT7Vo/lw86S hUkBYzZH0lrTEZngHPXIuZxBdX6tuwbDJxx7CpohZTBFrgLlvk78C6Oq5mz92vaAnQzDXj S0TWLFvv81NLzY3mmEbv2IRjJc8UtPs= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-wq6poSPyNVWucB9cBDNIig-1; Tue, 26 Oct 2021 14:02:15 -0400 X-MC-Unique: wq6poSPyNVWucB9cBDNIig-1 Received: by mail-ua1-f72.google.com with SMTP id e5-20020ab04985000000b002cad81164cbso8675632uad.10 for ; Tue, 26 Oct 2021 11:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RM2yRONY7GuPgPxTeaHdfNlqDcImWnb/nLUyNeRD77A=; b=LoqnXwwznI0YhTrW0gZaC4yZKfsOZpk/mYBfQrLHl+LvxheAMp71OP1ejzzahI7E9y l5lR3h1ktcD9XsU9LQ05VgLkMgzvYt3jWkCHAsRLuhchEovMt+UhLbpzeqYxwwc7K/rn SNGz/ZQ3jjTD2TPbm23sI8DURqzCNuJfpN7I/7sR2HjYiBhqLDvTjrd+tzJop6co7StV YbW/aGn+1Cu8rx9inFt2m0XU4mDQgjzoJLA1aM3bA4nSJFbAtj/kFYDFYAL3AAJHNy+c 82W3V8LK3iuk/dkKEbHlvPJa8r0EHLqQ9EKlDieCeA9RGE9di7Hq6HEzw8WLULo5E/BT RPwA== X-Gm-Message-State: AOAM530samq3lEK9wVwQjvJPqsyP9yZ7UlHND6t3zS745ZjGxWbvE1Ez wGPcUo8IWVcWa4HwM4A5luvOxX5JFK479YO3UYRNmX48wErB0RBwEzYTrMbEfz8H3xP82cflFVR +jN5ndAIItMSjlnnk9V/xT0qnjDy5rOM= X-Received: by 2002:ab0:759a:: with SMTP id q26mr2984188uap.128.1635271334938; Tue, 26 Oct 2021 11:02:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDdeMajR9yFElJ2CvJkglKKaeCMsJfkjE30xXVinfvoM80qD143iNzJdIzIdJvgJQLeSfUaErtTinQHAQd35w= X-Received: by 2002:ab0:759a:: with SMTP id q26mr2984160uap.128.1635271334658; Tue, 26 Oct 2021 11:02:14 -0700 (PDT) MIME-Version: 1.0 References: <20211019144918.3159078-1-jsnow@redhat.com> <20211019144918.3159078-11-jsnow@redhat.com> <6ab178e6-2fde-e681-cff2-834f132562a6@redhat.com> In-Reply-To: <6ab178e6-2fde-e681-cff2-834f132562a6@redhat.com> From: John Snow Date: Tue, 26 Oct 2021 14:02:04 -0400 Message-ID: Subject: Re: [PATCH v2 10/15] iotests/297: split test into sub-cases To: Hanna Reitz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000003976d05cf4547db" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-devel , qemu-block@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000003976d05cf4547db Content-Type: text/plain; charset="UTF-8" On Tue, Oct 26, 2021 at 6:29 AM Hanna Reitz wrote: > On 19.10.21 16:49, John Snow wrote: > > Take iotest 297's main() test function and split it into two sub-cases > > that can be skipped individually. We can also drop custom environment > > setup from the pylint test as it isn't needed. > > > > Signed-off-by: John Snow > > --- > > tests/qemu-iotests/297 | 63 ++++++++++++++++++++++++++---------------- > > 1 file changed, 39 insertions(+), 24 deletions(-) > > Reviewed-by: Hanna Reitz > > (while heavily scratching myself to ease the itch to turn this into a > unit test now) > > (I strongly considered it, but didn't want to add yet-more-rewrites into this series. If the ultimate fate is to sunset this particular iotest, I didn't see a big benefit to doing it.) --00000000000003976d05cf4547db Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Oct 26, 2021 at 6:29 AM Hanna= Reitz <hreitz@redhat.com> w= rote:
On 19.10.2= 1 16:49, John Snow wrote:
> Take iotest 297's main() test function and split it into two sub-c= ases
> that can be skipped individually. We can also drop custom environment<= br> > setup from the pylint test as it isn't needed.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>=C2=A0 =C2=A0tests/qemu-iotests/297 | 63 ++++++++++++++++++++++++++----= ------------
>=C2=A0 =C2=A01 file changed, 39 insertions(+), 24 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

(while heavily scratching myself to ease the itch to turn this into a
unit test now)


(I strongly considered it, but didn= 9;t want to add yet-more-rewrites into this series. If the ultimate fate is= to sunset this particular iotest, I didn't see a big benefit to doing = it.)
--00000000000003976d05cf4547db--