From: John Snow <jsnow@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel Berrange" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PULL 22/22] python, iotests: replace qmp with aqmp
Date: Tue, 9 Nov 2021 12:15:12 -0500 [thread overview]
Message-ID: <CAFn=p-aTczmhQw2wqc+Tmy_ce--oN3vVZ4RhsALD6zDB3QW0yQ@mail.gmail.com> (raw)
In-Reply-To: <0c924833-c3eb-4fc2-823b-6a0ece658533@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Tue, Nov 9, 2021 at 9:07 AM Thomas Huth <thuth@redhat.com> wrote:
> On 01/11/2021 18.30, John Snow wrote:
> > Swap out the synchronous QEMUMonitorProtocol from qemu.qmp with the sync
> > wrapper from qemu.aqmp instead.
> >
> > Add an escape hatch in the form of the environment variable
> > QEMU_PYTHON_LEGACY_QMP which allows you to cajole QEMUMachine into using
> > the old implementation, proving that both implementations work
> > concurrently.
>
> Hi John,
>
> seems like this patch broke our device-crash-test script. If I now run
> "scripts/device-crash-test -q" I get lots of error messages... could you
> please have a look?
>
> Thomas
>
I'm on it, thanks for the report and sorry for the inconvenience.
--js
[-- Attachment #2: Type: text/html, Size: 1170 bytes --]
next prev parent reply other threads:[~2021-11-09 17:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:29 [PULL 00/22] Python patches John Snow
2021-11-01 17:29 ` [PULL 01/22] iotests/297: Move pylint config into pylintrc John Snow
2021-11-01 17:29 ` [PULL 02/22] iotests/297: Split mypy configuration out into mypy.ini John Snow
2021-11-01 17:29 ` [PULL 03/22] iotests/297: Add get_files() function John Snow
2021-11-01 17:29 ` [PULL 04/22] iotests/297: Create main() function John Snow
2021-11-01 17:29 ` [PULL 05/22] iotests/297: Don't rely on distro-specific linter binaries John Snow
2021-11-01 17:29 ` [PULL 06/22] iotests/297: Split run_linters apart into run_pylint and run_mypy John Snow
2021-11-01 17:29 ` [PULL 07/22] iotests/297: refactor run_[mypy|pylint] as generic execution shim John Snow
2021-11-01 17:29 ` [PULL 08/22] iotests/297: Change run_linter() to raise an exception on failure John Snow
2021-11-01 17:29 ` [PULL 09/22] iotests/297: update tool availability checks John Snow
2021-11-01 17:29 ` [PULL 10/22] iotests/297: split test into sub-cases John Snow
2021-11-01 17:29 ` [PULL 11/22] iotests: split linters.py out from 297 John Snow
2021-11-01 17:29 ` [PULL 12/22] iotests/linters: Add entry point for linting via Python CI John Snow
2021-11-01 17:29 ` [PULL 13/22] iotests/linters: Add workaround for mypy bug #9852 John Snow
2021-11-01 17:29 ` [PULL 14/22] python: Add iotest linters to test suite John Snow
2021-11-01 17:29 ` [PULL 15/22] python/machine: remove has_quit argument John Snow
2021-11-01 17:30 ` [PULL 16/22] python/machine: Handle QMP errors on close more meticulously John Snow
2021-11-01 17:30 ` [PULL 17/22] python/aqmp: Remove scary message John Snow
2021-11-01 17:30 ` [PULL 18/22] iotests: Accommodate async QMP Exception classes John Snow
2021-11-01 17:30 ` [PULL 19/22] iotests: Conditionally silence certain AQMP errors John Snow
2021-11-01 17:30 ` [PULL 20/22] iotests/300: avoid abnormal shutdown race condition John Snow
2021-11-01 17:30 ` [PULL 21/22] python/aqmp: Create sync QMP wrapper for iotests John Snow
2021-11-01 17:30 ` [PULL 22/22] python, iotests: replace qmp with aqmp John Snow
2021-11-09 14:07 ` Thomas Huth
2021-11-09 17:15 ` John Snow [this message]
2021-11-02 9:52 ` [PULL 00/22] Python patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-aTczmhQw2wqc+Tmy_ce--oN3vVZ4RhsALD6zDB3QW0yQ@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).