From: John Snow <jsnow@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] mkvenv: pass first missing package to diagnose()
Date: Thu, 25 May 2023 16:50:31 -0400 [thread overview]
Message-ID: <CAFn=p-aU8O+o21_TNX8v7Nd83XNsSiK3U8Zy6vHSrg2=a7RUFg@mail.gmail.com> (raw)
In-Reply-To: <20230519082454.1102010-1-pbonzini@redhat.com>
On Fri, May 19, 2023 at 4:25 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> If sphinx is present but the theme is not, mkvenv will print an
> inaccurate diagnostic:
>
> ERROR: Could not find a version that satisfies the requirement sphinx-rtd-theme>=0.5.0 (from versions: none)
> ERROR: No matching distribution found for sphinx-rtd-theme>=0.5.0
>
> 'sphinx>=1.6.0' not found:
> • Python package 'sphinx' version '5.3.0' was found, but isn't suitable.
> • mkvenv was configured to operate offline and did not check PyPI.
>
> Instead, ignore the packages that were found to be present, and report
> an error based on the first absent package.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Late to the party, but ACK.
prev parent reply other threads:[~2023-05-25 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 8:24 [PATCH] mkvenv: pass first missing package to diagnose() Paolo Bonzini
2023-05-25 20:50 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-aU8O+o21_TNX8v7Nd83XNsSiK3U8Zy6vHSrg2=a7RUFg@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).