From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com, peter.maydell@linaro.org
Subject: Re: [PATCH 4/7] docs/interop/bitmaps: Clean up a reference to qemu-qmp-ref
Date: Thu, 1 Feb 2024 16:45:41 -0500 [thread overview]
Message-ID: <CAFn=p-aUAS7cxRsOm7DCtjYFxDgt82F3OnA5Kao-e8ujCvihww@mail.gmail.com> (raw)
In-Reply-To: <20240120095327.666239-5-armbru@redhat.com>
On Sat, Jan 20, 2024 at 4:53 AM Markus Armbruster <armbru@redhat.com> wrote:
>
> docs/interop/bitmaps.rst uses references like
>
> `qemu-qmp-ref <qemu-qmp-ref.html>`_
> `query-block <qemu-qmp-ref.html#index-query_002dblock>`_
>
> to refer to and into docs/interop/qemu-qmp-ref.rst.
>
> Clean up the former: use :doc:`qemu-qmp-ref`.
>
> I don't know how to clean up the latter.
It used to have anchors that seemed to have semi-stable names, but I
guess that's not really true anymore.
Now it's just stuff like `qapidoc-423`. Well, neat...
No, I think this requires the Real Fix :tm: now...
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/interop/bitmaps.rst | 4 ++--
> qapi/introspect.json | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/interop/bitmaps.rst b/docs/interop/bitmaps.rst
> index c731be2f01..ddf8947d54 100644
> --- a/docs/interop/bitmaps.rst
> +++ b/docs/interop/bitmaps.rst
> @@ -167,8 +167,8 @@ Basic QMP Usage
>
> The primary interface to manipulating bitmap objects is via the QMP
> interface. If you are not familiar, see the :doc:`qmp-spec` for the
> -protocol, and `qemu-qmp-ref <qemu-qmp-ref.html>`_ for a full
> -reference of all QMP commands.
> +protocol, and :doc:`qemu-qmp-ref` for a full reference of all QMP
> +commands.
>
> Supported Commands
> ~~~~~~~~~~~~~~~~~~
> diff --git a/qapi/introspect.json b/qapi/introspect.json
> index ebc4e199d2..8df1ce85ed 100644
> --- a/qapi/introspect.json
> +++ b/qapi/introspect.json
> @@ -260,8 +260,8 @@
> # Additional SchemaInfo members for meta-type 'alternate'.
> #
> # @members: the alternate type's members, in no particular order. The
> -# members' wire encoding is distinct, see :doc:`qapi-code-gen`
> -# section Alternate types.
> +# members' wire encoding is distinct, see
> +# :doc:`/devel/qapi-code-gen` section Alternate types.
> #
> # On the wire, this can be any of the members.
> #
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-02-01 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 9:53 [PATCH 0/7] qapi qmp: Documentation fixes Markus Armbruster
2024-01-20 9:53 ` [PATCH 1/7] docs/devel/qapi-code-gen: Fix missing ':' in tagged section docs Markus Armbruster
2024-01-20 9:53 ` [PATCH 2/7] docs: Replace dangling references to docs/interop/qmp-intro.txt Markus Armbruster
2024-01-20 9:53 ` [PATCH 3/7] qapi: Fix dangling references to docs/devel/qapi-code-gen.txt Markus Armbruster
2024-01-20 9:53 ` [PATCH 4/7] docs/interop/bitmaps: Clean up a reference to qemu-qmp-ref Markus Armbruster
2024-02-01 21:45 ` John Snow [this message]
2024-02-01 21:47 ` John Snow
2024-01-20 9:53 ` [PATCH 5/7] qapi: Fix mangled "Returns" sections in documentation Markus Armbruster
2024-01-20 9:53 ` [PATCH 6/7] qapi: Indent tagged doc comment sections properly Markus Armbruster
2024-01-20 9:53 ` [PATCH 7/7] qapi: Fix malformed "Since:" section tags (again) Markus Armbruster
2024-01-20 23:21 ` Philippe Mathieu-Daudé
2024-01-25 19:48 ` [PATCH 0/7] qapi qmp: Documentation fixes Eric Blake
2024-01-26 6:08 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-aUAS7cxRsOm7DCtjYFxDgt82F3OnA5Kao-e8ujCvihww@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).