From: John Snow <jsnow@redhat.com>
To: Peter Krempa <pkrempa@redhat.com>
Cc: qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>,
qemu-block@nongnu.org, Pavel Hrdina <phrdina@redhat.com>
Subject: Re: [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing
Date: Tue, 10 Jun 2025 15:54:54 -0400 [thread overview]
Message-ID: <CAFn=p-aYMQb-StChaph_m-2qXY_1AW4PTx_ZkAOE1bTLchq=Hw@mail.gmail.com> (raw)
In-Reply-To: <aEgnsqTpcX0Fp3vx@angien.pipo.sk>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Tue, Jun 10, 2025 at 8:40 AM Peter Krempa <pkrempa@redhat.com> wrote:
> On Wed, Mar 19, 2025 at 17:28:06 +0100, Peter Krempa wrote:
> > New python doesn't like '\l' escapes from the 'dot' language.
> >
> > While at it improve usability of the script by employing proper argument
> > parsing.
> >
> > v2:
> > - use mutually exclusive group instead of hardcoding it (Pavel)
> >
> > Peter Krempa (3):
> > scripts: render_block_graph: Fix invalid escape sequence warning with
> > python 3.12
> > scripts: render_block_graph: Implement proper argument parser
> > scripts: render_block_graph: Avoid backtrace on error from virsh
>
> Ping :)
Ah darn, guess that's me.
Tempted to just say "LGTM!" but lemme give it the once over here ... If you
don't hear back within a day or two just ping my email box directly to nag
me, please-and-thank-you.
--js
[-- Attachment #2: Type: text/html, Size: 1395 bytes --]
prev parent reply other threads:[~2025-06-10 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 16:28 [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing Peter Krempa
2025-03-19 16:28 ` [PATCH v2 1/3] scripts: render_block_graph: Fix invalid escape sequence warning with python 3.12 Peter Krempa
2025-03-19 16:28 ` [PATCH v2 2/3] scripts: render_block_graph: Implement proper argument parser Peter Krempa
2025-03-19 16:28 ` [PATCH v2 3/3] scripts: render_block_graph: Avoid backtrace on error from virsh Peter Krempa
2025-03-19 16:53 ` [PATCH v2 0/3] scripts: render_block_graph: Fix with new python and improve argument parsing Pavel Hrdina
2025-06-10 12:40 ` Peter Krempa
2025-06-10 19:54 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-aYMQb-StChaph_m-2qXY_1AW4PTx_ZkAOE1bTLchq=Hw@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=phrdina@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).