qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] mtest2make: clean up and make dependencies more precise
@ 2025-11-17 16:31 Paolo Bonzini
  2025-11-17 16:31 ` [PATCH 1/3] mtest2make: cleanup mtest-suites variables Paolo Bonzini
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Paolo Bonzini @ 2025-11-17 16:31 UTC (permalink / raw)
  To: qemu-devel; +Cc: jsnow

You probably have never thought much about scripts/mtest2make.py, and in
fact it has seen only a hendful of commits in the last few years.
The idea is pretty simple: gather the list of testsuites and their
dependencies, and turn a "make check-*" invocation into calling "ninja"
first and "meson test" second.  On top of that, it magically turns
SPEED=thorough into invoking up to three suites named XYZ, XYZ-slow
and XYZ-thorough.

But even this incospicuous script can harbor a bug, or rather an "I
didn't really think too much about it" situation.  Dependencies are added
to suite XYZ independent of the speed that is used in the meson.build
file: add a dependency to a func-thorough test and "make check-func"
will build it at any requested speed.

Fixing this is a one line change, but it is easiest with a small cleanup
on the front, which is patch 1.  This (at least to me) makes the generated
Makefile.mtest file a little bit easier to read, which is also nice
to have.

Paolo


Paolo Bonzini (3):
  mtest2make: cleanup mtest-suites variables
  mtest2make: add dependencies to the "speed-qualified" suite
  mtest2make: do not repeat the same speed over and over

 Makefile              |  4 +++-
 scripts/mtest2make.py | 43 ++++++++++++++++++-------------------------
 2 files changed, 21 insertions(+), 26 deletions(-)

-- 
2.51.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-11-18  7:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-17 16:31 [PATCH 0/3] mtest2make: clean up and make dependencies more precise Paolo Bonzini
2025-11-17 16:31 ` [PATCH 1/3] mtest2make: cleanup mtest-suites variables Paolo Bonzini
2025-11-17 16:31 ` [PATCH 2/3] mtest2make: add dependencies to the "speed-qualified" suite Paolo Bonzini
2025-11-17 16:31 ` [PATCH 3/3] mtest2make: do not repeat the same speed over and over Paolo Bonzini
2025-11-17 19:31 ` [PATCH 0/3] mtest2make: clean up and make dependencies more precise John Snow
2025-11-17 20:46 ` Alex Bennée
2025-11-18  7:00   ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).