From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0672CC4338F for ; Tue, 3 Aug 2021 17:35:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94F8560F41 for ; Tue, 3 Aug 2021 17:35:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94F8560F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAyKN-0006WW-Q0 for qemu-devel@archiver.kernel.org; Tue, 03 Aug 2021 13:35:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAyJY-0005bz-KP for qemu-devel@nongnu.org; Tue, 03 Aug 2021 13:34:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29263) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAyJV-00087X-Kt for qemu-devel@nongnu.org; Tue, 03 Aug 2021 13:34:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628012087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jfSvV2qRbURV5ggFhVZl3g9nvoixoxU3L70MCEaqY6w=; b=bvfNT/MmFgwBHOYsM4fNM39UzpRGIChpFdQQvDv5UpS/bmhy1YV8JNqkrJ5jIQDGwgRbTS 74UPxxTmzZx4f7Brb9q/ep1S75F/n/vp5ArOD7tZqzyzafdq2RAf/Qe4WRLlYN6VCIdmTv DzDkCgUhf2a3TNPNnwe1fcyTALIKLIE= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-jjNwpbWnPvCvW1MMAlGuSA-1; Tue, 03 Aug 2021 13:34:45 -0400 X-MC-Unique: jjNwpbWnPvCvW1MMAlGuSA-1 Received: by mail-oi1-f197.google.com with SMTP id c6-20020aca35060000b029025c5504f461so8913953oia.22 for ; Tue, 03 Aug 2021 10:34:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jfSvV2qRbURV5ggFhVZl3g9nvoixoxU3L70MCEaqY6w=; b=PSOXeOWB1svPLXVygqztjnSSE+WiuIUTb011PhnlUarX5maxw2aZy8FQeJKkvKNT5V Tjogap5L4SQVN19YN0YeQofcknVphcT1ElpIErRbJPzZqyEw3MtvSoKKXktaImN3gLnY b1zvWVx6YOz3F2vdMupl66nXmusQBej48KMDD/3plhPh7pMU6twj1x7U+O0uc55qNOUy OVqxq6aCTP91Xebe2CcABMwgJ2EZuUG9kDvLsFnMnYp+82h3CgMOVpxHkRE4IlG9WIPR +8xhhGHWDy1Io0RoyIeB2tLW1xG+GpTQX2W0Ap+eg8q6GVf+YMP3S1jjP8Iju7b8Vkw8 zIAw== X-Gm-Message-State: AOAM5335QArnSZ2oWwYYRF9n75JzFzB0vjm1NXQwGH+5Sl4H9MBkLkCf hGY6UiXSn193JStoeR769K2tLVN58bmZdHOd7N95tC4x9fx+vX2PW5tkq2g3M/UEvk0z5H6WHgE F4f6dZW9ayumdn5OFXj14JktBtOftEw8= X-Received: by 2002:a9d:2782:: with SMTP id c2mr16408483otb.323.1628012083866; Tue, 03 Aug 2021 10:34:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYRFSFUpBrJ/1vmdaOCeZnuoI6uHAM/UrRHS5azD9QQlYyedjfd7EwpNAs6UhvsLfYHJknFTo4BdDHiukr24Y= X-Received: by 2002:a9d:2782:: with SMTP id c2mr16408470otb.323.1628012083693; Tue, 03 Aug 2021 10:34:43 -0700 (PDT) MIME-Version: 1.0 References: <20210717003253.457418-1-jsnow@redhat.com> <20210717003253.457418-3-jsnow@redhat.com> <20210803160129.e63u5lylorivgjov@redhat.com> In-Reply-To: <20210803160129.e63u5lylorivgjov@redhat.com> From: John Snow Date: Tue, 3 Aug 2021 13:34:32 -0400 Message-ID: Subject: Re: [PATCH v2 02/24] python/aqmp: add error classes To: Eric Blake Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000f0623b05c8ab1900" Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Stefan Hajnoczi , Markus Armbruster , Wainer dos Santos Moschetta , qemu-devel , "Niteesh G . S ." , Willian Rampazzo , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000f0623b05c8ab1900 Content-Type: text/plain; charset="UTF-8" Got it. I was *just* about to send a refreshed version of this patchset because I found a new bug while on my way to making a sync compatibility shim for iotests -- Do you have more feedback cooking, or should I hit the send button? --js On Tue, Aug 3, 2021 at 12:02 PM Eric Blake wrote: > On Fri, Jul 16, 2021 at 08:32:31PM -0400, John Snow wrote: > > Signed-off-by: John Snow > > --- > > python/qemu/aqmp/__init__.py | 4 +++ > > python/qemu/aqmp/error.py | 50 ++++++++++++++++++++++++++++++++++++ > > 2 files changed, 54 insertions(+) > > create mode 100644 python/qemu/aqmp/error.py > > > +++ b/python/qemu/aqmp/error.py > > @@ -0,0 +1,50 @@ > > > + > > +class ProtocolError(AQMPError): > > + """ > > + Abstract error class for protocol failures. > > + > > + Semantically, these errors are generally the fault of either the > > + protocol server or as a result of a bug in this this library. > > duplicate 'this' > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > > --000000000000f0623b05c8ab1900 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Got it. I was *just* about to send a refreshed versio= n of this patchset because I found a new bug while on my way to making a sy= nc compatibility shim for iotests -- Do you have more feedback cooking, or = should I hit the send button?

--js
=
On Tue= , Aug 3, 2021 at 12:02 PM Eric Blake <eblake@redhat.com> wrote:
On Fri, Jul 16, 2021 at 08:32:31PM -0400, John Snow wro= te:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>=C2=A0 python/qemu/aqmp/__init__.py |=C2=A0 4 +++
>=C2=A0 python/qemu/aqmp/error.py=C2=A0 =C2=A0 | 50 ++++++++++++++++++++= ++++++++++++++++
>=C2=A0 2 files changed, 54 insertions(+)
>=C2=A0 create mode 100644 python/qemu/aqmp/error.py

> +++ b/python/qemu/aqmp/error.py
> @@ -0,0 +1,50 @@

> +
> +class ProtocolError(AQMPError):
> +=C2=A0 =C2=A0 """
> +=C2=A0 =C2=A0 Abstract error class for protocol failures.
> +
> +=C2=A0 =C2=A0 Semantically, these errors are generally the fault of e= ither the
> +=C2=A0 =C2=A0 protocol server or as a result of a bug in this this li= brary.

duplicate 'this'

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0+1-919-301-3266
Virtualization:=C2=A0 qemu.org | libvirt.org

--000000000000f0623b05c8ab1900--