Re: [PATCH 11/22] python: add vendored qemu.qmp package

[John Snow <jsnow@redhat.com>]

On Wed, Nov 19, 2025 at 4:29 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 17/11/2025 19.51, John Snow wrote:
> > In anticipation of deleting the python/qemu/qmp source from the tree,
> > add a vendored version of the qemu.qmp package to ensure that "make
> > check" can be run in isolated build environments, offline.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   python/scripts/vendor.py                      |   2 ++
> >   python/wheels/qemu_qmp-0.0.5-py3-none-any.whl | Bin 0 -> 72263 bytes
> >   2 files changed, 2 insertions(+)
> >   create mode 100644 python/wheels/qemu_qmp-0.0.5-py3-none-any.whl
> >
> > diff --git a/python/scripts/vendor.py b/python/scripts/vendor.py
> > index 33ac7a45de0..36cd27046e7 100755
> > --- a/python/scripts/vendor.py
> > +++ b/python/scripts/vendor.py
> > @@ -43,6 +43,8 @@ def main() -> int:
> >       packages = {
> >           "meson==1.9.0":
> >           "45e51ddc41e37d961582d06e78c48e0f9039011587f3495c4d6b0781dad92357",
> > +        "qemu.qmp==0.0.5":
> > +        "e05782d6df5844b34e0d2f7c68693525da074deef7b641c1401dda6e4e3d6303",
> >       }
>
> I wonder why I did not have to add pycotap here when I added a wheel for
> that...?

It's only a script we run manually - it doesn't break anything to skip
over it. It just helps to have a script available that can do the
vendoring for you and verify the checksums. Ease of convenience for
future maintainers, etc.

>
> Anyway, for your patch, FWIW:
> Acked-by: Thomas Huth <thuth@redhat.com>
>