From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Eric Blake <eblake@redhat.com>,
Michael Roth <michael.roth@amd.com>,
Konstantin Kostiuk <kkostiuk@redhat.com>
Subject: Re: [PATCH 01/12] qapi: Drop stray Arguments: line from qmp_capabilities docs
Date: Fri, 22 Mar 2024 11:24:13 -0400 [thread overview]
Message-ID: <CAFn=p-axf_Vy7aBPMBycY4ymOWLq6bgg06yy97GVgp3shAyBFA@mail.gmail.com> (raw)
In-Reply-To: <20240322140910.328840-2-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Fri, Mar 22, 2024, 10:09 AM Markus Armbruster <armbru@redhat.com> wrote:
> Reported-by: John Snow <jsnow@redhat.com>
> Fixes: 119ebac1feb2 (qapi-schema: use generated marshaller for
> 'qmp_capabilities')
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
Reviewed-by: John Snow <jsnow@redhat.com>
---
> qapi/control.json | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/qapi/control.json b/qapi/control.json
> index f404daef60..6bdbf077c2 100644
> --- a/qapi/control.json
> +++ b/qapi/control.json
> @@ -11,8 +11,6 @@
> #
> # Enable QMP capabilities.
> #
> -# Arguments:
> -#
> # @enable: An optional list of QMPCapability values to enable. The
> # client must not enable any capability that is not mentioned in
> # the QMP greeting message. If the field is not provided, it
> --
> 2.44.0
>
>
[-- Attachment #2: Type: text/html, Size: 1639 bytes --]
next prev parent reply other threads:[~2024-03-22 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 14:08 [PATCH 00/12] qapi: Fairly trivial documentation work Markus Armbruster
2024-03-22 14:08 ` [PATCH 01/12] qapi: Drop stray Arguments: line from qmp_capabilities docs Markus Armbruster
2024-03-22 15:24 ` John Snow [this message]
2024-03-22 14:09 ` [PATCH 02/12] qapi: Expand a few awkward abbreviations in documentation Markus Armbruster
2024-03-22 14:09 ` [PATCH 03/12] qapi: Tidy up block-latency-histogram-set documentation some more Markus Armbruster
2024-03-22 14:09 ` [PATCH 04/12] qapi: Tidy up indentation of add_client's example Markus Armbruster
2024-03-25 5:49 ` Markus Armbruster
2024-03-22 14:09 ` [PATCH 05/12] qapi: Fix argument markup in drive-mirror documentation Markus Armbruster
2024-03-22 14:09 ` [PATCH 06/12] qapi: Fix typo in request-ebpf documentation Markus Armbruster
2024-03-22 14:09 ` [PATCH 07/12] qapi: Fix abbreviation punctuation in doc comments Markus Armbruster
2024-03-22 14:09 ` [PATCH 08/12] qapi: Start sentences with a capital letter, end them with a period Markus Armbruster
2024-03-22 14:09 ` [PATCH 09/12] qapi: Don't repeat member type in its documentation text Markus Armbruster
2024-03-22 14:09 ` [PATCH 10/12] qapi: Refill doc comments to conform to current conventions Markus Armbruster
2024-03-22 14:09 ` [PATCH 11/12] qapi: Correct documentation indentation and whitespace Markus Armbruster
2024-03-22 14:09 ` [PATCH 12/12] qga/qapi-schema: Refill doc comments to conform to current conventions Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-axf_Vy7aBPMBycY4ymOWLq6bgg06yy97GVgp3shAyBFA@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).