From: John Snow <jsnow@redhat.com>
To: "Niteesh G. S." <niteesh.gs@gmail.com>
Cc: Cleber Rosa <crosa@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v2 0/6] python: AQMP-TUI Prototype
Date: Wed, 21 Jul 2021 16:03:20 -0400 [thread overview]
Message-ID: <CAFn=p-b=Q9_BFQpnb5yXEjUcU0WJLSXyUS9EquHNWGs6XZ6UCQ@mail.gmail.com> (raw)
In-Reply-To: <CAN6ztm8yqX=VZON3is8ni5a5kXr7xQrdNubA6Pj+p0fUGadOEA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]
On Wed, Jul 21, 2021 at 2:09 PM Niteesh G. S. <niteesh.gs@gmail.com> wrote:
> On Wed, Jul 21, 2021 at 12:39 AM John Snow <jsnow@redhat.com> wrote:
>
>> On Wed, Jul 14, 2021 at 3:07 PM Niteesh G. S. <niteesh.gs@gmail.com>
>> wrote:
>>
>> Why not?
>>
> I have already updated the status of this
> https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg04059.html
>
Sorry, I missed this.
Thanks Niteesh, a few general comments that don't relate directly to the
>> code:
>>
>> 1. It would be nice to be able to highlight/copy-paste things out of the
>> history window, I seemingly can't right now.
>>
>> 2. It would be nice if the mouse scroll wheel worked on the history panel.
>>
>> 3. A greeting message like the old qmp-shell might be nice to see. It
>> would be good if it explained how to quit the program (esc, ctrl^c) and
>> send messages (alt+enter).
>>
>> 4. Some control hints or reminder text in the footer might be nice, for
>> how to quit, send a message, etc.
>>
>
> I'll update the status here as I start working on them one by one.
>
>
OK - They don't need to go into this series, these are just some
observations. All of these items seem like good candidates for standalone
follow-up patches to happen in another series that follows this one.
> For the next revision, I may ask you to start looking into making sure
>> that mypy and pylint pass without exemptions. Do the best you can, and get
>> as far as you are able. You can leave the warnings disabled for V3, but I'd
>> like you to start taking a look now so that you know where the trouble
>> spots are.
>>
>
> Sure.
>
>
I'll be on PTO for the next three business days, returning 2021-07-27 -- If
you get blocked on other tasks, try adding mypy type hints using this
downtime.
Thanks again,
--js
[-- Attachment #2: Type: text/html, Size: 4236 bytes --]
prev parent reply other threads:[~2021-07-21 20:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 22:07 [PATCH v2 0/6] python: AQMP-TUI Prototype G S Niteesh Babu
2021-07-13 22:07 ` [PATCH v2 1/6] python: disable pylint errors for aqmp-tui G S Niteesh Babu
2021-07-13 22:07 ` [PATCH v2 2/6] python: Add dependencies for AQMP TUI G S Niteesh Babu
2021-07-13 22:07 ` [PATCH v2 3/6] python/aqmp-tui: Add AQMP TUI draft G S Niteesh Babu
2021-07-20 17:57 ` John Snow
2021-07-20 18:01 ` Niteesh G. S.
2021-07-20 19:04 ` John Snow
2021-07-21 20:22 ` Niteesh G. S.
2021-07-13 22:07 ` [PATCH v2 4/6] python: add optional pygments dependency G S Niteesh Babu
2021-07-13 22:07 ` [PATCH v2 5/6] python/aqmp-tui: add syntax highlighting G S Niteesh Babu
2021-07-13 22:07 ` [PATCH v2 6/6] python: add entry point for aqmp-tui G S Niteesh Babu
2021-07-14 19:06 ` [PATCH v2 0/6] python: AQMP-TUI Prototype Niteesh G. S.
2021-07-20 19:08 ` John Snow
2021-07-21 18:08 ` Niteesh G. S.
2021-07-21 20:03 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-b=Q9_BFQpnb5yXEjUcU0WJLSXyUS9EquHNWGs6XZ6UCQ@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=niteesh.gs@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).