* [PATCH] Windows installer: keep dependency cache
@ 2023-01-03 22:13 Arthur Sengileyev
2023-01-06 21:53 ` John Snow
2023-01-07 15:56 ` Bin Meng
0 siblings, 2 replies; 3+ messages in thread
From: Arthur Sengileyev @ 2023-01-03 22:13 UTC (permalink / raw)
To: arthur.sengileyev; +Cc: sw, jsnow, crosa, qemu-devel, qemu-trivial
It should be possible to reuse cache built by previous iteration
processing next executables. Already processed dependencies are
already skipped later based on dll name.
Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
---
scripts/nsis.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/nsis.py b/scripts/nsis.py
index 03ed7608a2..a2e52df556 100644
--- a/scripts/nsis.py
+++ b/scripts/nsis.py
@@ -91,12 +91,13 @@ def main():
print("Searching '%s' for the dependent dlls ..." % search_path)
dlldir = os.path.join(destdir + prefix, "dll")
os.mkdir(dlldir)
+ depscache = set()
for exe in glob.glob(os.path.join(destdir + prefix, "*.exe")):
signcode(exe)
# find all dll dependencies
- deps = set(find_deps(exe, search_path, set()))
+ deps = set(find_deps(exe, search_path, depscache))
deps.remove(exe)
# copy all dlls to the DLLDIR
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Windows installer: keep dependency cache
2023-01-03 22:13 [PATCH] Windows installer: keep dependency cache Arthur Sengileyev
@ 2023-01-06 21:53 ` John Snow
2023-01-07 15:56 ` Bin Meng
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2023-01-06 21:53 UTC (permalink / raw)
To: Arthur Sengileyev; +Cc: sw, crosa, qemu-devel, qemu-trivial
On Tue, Jan 3, 2023 at 5:13 PM Arthur Sengileyev
<arthur.sengileyev@gmail.com> wrote:
>
> It should be possible to reuse cache built by previous iteration
> processing next executables. Already processed dependencies are
> already skipped later based on dll name.
>
> Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
> ---
> scripts/nsis.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/nsis.py b/scripts/nsis.py
> index 03ed7608a2..a2e52df556 100644
> --- a/scripts/nsis.py
> +++ b/scripts/nsis.py
> @@ -91,12 +91,13 @@ def main():
> print("Searching '%s' for the dependent dlls ..." % search_path)
> dlldir = os.path.join(destdir + prefix, "dll")
> os.mkdir(dlldir)
> + depscache = set()
>
> for exe in glob.glob(os.path.join(destdir + prefix, "*.exe")):
> signcode(exe)
>
> # find all dll dependencies
> - deps = set(find_deps(exe, search_path, set()))
> + deps = set(find_deps(exe, search_path, depscache))
> deps.remove(exe)
>
> # copy all dlls to the DLLDIR
> --
> 2.39.0
>
ACK for python changes, which seem sane. I've not used the NSIS script
before, though, so I won't grant RB/TB here.
--js
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Windows installer: keep dependency cache
2023-01-03 22:13 [PATCH] Windows installer: keep dependency cache Arthur Sengileyev
2023-01-06 21:53 ` John Snow
@ 2023-01-07 15:56 ` Bin Meng
1 sibling, 0 replies; 3+ messages in thread
From: Bin Meng @ 2023-01-07 15:56 UTC (permalink / raw)
To: Arthur Sengileyev; +Cc: sw, jsnow, crosa, qemu-devel, qemu-trivial
On Wed, Jan 4, 2023 at 6:54 AM Arthur Sengileyev
<arthur.sengileyev@gmail.com> wrote:
>
> It should be possible to reuse cache built by previous iteration
> processing next executables. Already processed dependencies are
s/processing/to process
> already skipped later based on dll name.
>
> Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
> ---
> scripts/nsis.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/nsis.py b/scripts/nsis.py
> index 03ed7608a2..a2e52df556 100644
> --- a/scripts/nsis.py
> +++ b/scripts/nsis.py
> @@ -91,12 +91,13 @@ def main():
> print("Searching '%s' for the dependent dlls ..." % search_path)
> dlldir = os.path.join(destdir + prefix, "dll")
> os.mkdir(dlldir)
> + depscache = set()
nits: I would use deps_cache as the name
>
> for exe in glob.glob(os.path.join(destdir + prefix, "*.exe")):
> signcode(exe)
>
> # find all dll dependencies
> - deps = set(find_deps(exe, search_path, set()))
> + deps = set(find_deps(exe, search_path, depscache))
> deps.remove(exe)
>
> # copy all dlls to the DLLDIR
> --
Otherwise LGTM
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-07 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-03 22:13 [PATCH] Windows installer: keep dependency cache Arthur Sengileyev
2023-01-06 21:53 ` John Snow
2023-01-07 15:56 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).