From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4CCBC433EF for ; Thu, 24 Mar 2022 20:51:47 +0000 (UTC) Received: from localhost ([::1]:43318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXUQs-0001ao-TQ for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 16:51:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXUP8-0000m0-2b for qemu-devel@nongnu.org; Thu, 24 Mar 2022 16:49:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41098) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXUP6-0006yg-G9 for qemu-devel@nongnu.org; Thu, 24 Mar 2022 16:49:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648154995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yYeKXwFMf0JKme00Uu1Ea9X1/schybPG2ezIP832Ing=; b=N3zlg8lhiMpjb7zDK6bRGiZnrGTdXlOoSsmpMtbSju7MoAT7iihVSP26Oj487NZlzLNT6X SDosnGL908yKVBXnZ3I9otUv+Sy4L1WgxiMjqhuYrUjfv6k/5U6YcWmguDVzg8ApFy+/uO bHghOS1p0nVGj2ZD7ntjNjf/Qrvwwak= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-228-MJJHKm6fNAmBXA_Wr14CBA-1; Thu, 24 Mar 2022 16:49:54 -0400 X-MC-Unique: MJJHKm6fNAmBXA_Wr14CBA-1 Received: by mail-vs1-f70.google.com with SMTP id d3-20020a67c483000000b0032562b5ff34so592252vsk.12 for ; Thu, 24 Mar 2022 13:49:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yYeKXwFMf0JKme00Uu1Ea9X1/schybPG2ezIP832Ing=; b=KgZac9SJOg67r++F1kZv01YysTXdvFHkC2cEd3d+yfE1SOWV+mXEVLDhJUcBBbzvQ3 nq++Be/obQ2F+Z8L8ffNO4i35oPP71vwbVsLedK4araJ+OFSAI0lL59IrQTIFcFiESfA qKz+0zCrkgdMxzKZJYiacYDn90aDxLOpHdQTKMj9v2MWvosBqLSqr34rNTkCkVd8G00N 2wT6bFb3/OipGCr32jfnf8koOXAbnhKFi7Q0T3Sl0p1OesOlVLXzIGcfBTgXF3RGfw1t vcHlqAKeog7LTZv/MonvAvGOaoBM7ZcFXaOrv3CZE4YcNhB5Ao2o0icrbBuqzVx3M3/Q GSmA== X-Gm-Message-State: AOAM533u0ZHaoWE1DzOLDFDb+iblQm5u8iTOnalOfdtiAs3vmHN8vHp9 EFUfyCXIwkBxsVJDaLqHqqFM8p7ZsYlyy0K3HSnZxGKtXSWyOC3fEydV4n6MHOvd9c2zU7XL3qa l/qTadRjfLBc91uOal0WBanP95O1h7p8= X-Received: by 2002:a05:6122:887:b0:332:699e:7e67 with SMTP id 7-20020a056122088700b00332699e7e67mr3461510vkf.35.1648154993882; Thu, 24 Mar 2022 13:49:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+PaPbLObOFWHtC09GOfnON01/1DA10xztQAf8NhWSxS2qqdmK5MZrAR2IN/KjdifCX2EtdYwrUlTh6JYHkBY= X-Received: by 2002:a05:6122:887:b0:332:699e:7e67 with SMTP id 7-20020a056122088700b00332699e7e67mr3461498vkf.35.1648154993657; Thu, 24 Mar 2022 13:49:53 -0700 (PDT) MIME-Version: 1.0 References: <20220324175015.232794-1-victortoso@redhat.com> <20220324175015.232794-5-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-5-victortoso@redhat.com> From: John Snow Date: Thu, 24 Mar 2022 16:49:42 -0400 Message-ID: Subject: Re: [PATCH 04/14] qapi: fix example of BLOCK_JOB_PENDING event To: Victor Toso Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000eea45c05dafcfcc8" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Blake , qemu-devel , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000eea45c05dafcfcc8 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 24, 2022, 1:50 PM Victor Toso wrote: > * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING > * Argument device -> id > > Signed-off-by: Victor Toso > --- > qapi/block-core.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 5b6c069dd9..ea96e1b009 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5226,8 +5226,8 @@ > # > # Example: > # > -# <- { "event": "BLOCK_JOB_WAITING", > -# "data": { "device": "drive0", "type": "mirror" }, > +# <- { "event": "BLOCK_JOB_PENDING", > +# "data": { "type": "mirror", "id": "backup_1" }, > # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > # > ## > -- > 2.35.1 > Ow, how'd I get away with this? It was just always wrong and we never noticed? Cool. Reviewed-by: John Snow (Whoa, this is from 2018? It feels like it was from way before then.) > --000000000000eea45c05dafcfcc8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Mar 24, 2022, 1:50 PM Victor = Toso <victort= oso@redhat.com> wrote:
* Eve= nt's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING
* Argument device -> id

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
=C2=A0qapi/block-core.json | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5b6c069dd9..ea96e1b009 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5226,8 +5226,8 @@
=C2=A0#
=C2=A0# Example:
=C2=A0#
-# <- { "event": "BLOCK_JOB_WAITING",
-#=C2=A0 =C2=A0 =C2=A0 "data": { "device": "drive0= ", "type": "mirror" },
+# <- { "event": "BLOCK_JOB_PENDING",
+#=C2=A0 =C2=A0 =C2=A0 "data": { "type": "mirror&q= uot;, "id": "backup_1" },
=C2=A0#=C2=A0 =C2=A0 =C2=A0 "timestamp": { "seconds": 1= 265044230, "microseconds": 450486 } }
=C2=A0#
=C2=A0##
--
2.35.1

Ow, how= 'd I get away with this? It was just always wrong and we never noticed?=

Cool.

Reviewed-by: John = Snow <jsnow@redhat.com>
=

(Whoa, this is from 2018? It feels like it was from way= before then.)
--000000000000eea45c05dafcfcc8--