From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA6ECC76196 for ; Wed, 12 Apr 2023 01:28:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmPH9-000409-4y; Tue, 11 Apr 2023 21:27:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmPH4-0003zg-O8 for qemu-devel@nongnu.org; Tue, 11 Apr 2023 21:27:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmPH2-0003DT-BI for qemu-devel@nongnu.org; Tue, 11 Apr 2023 21:27:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681262867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=52dKt1oQ4xluuTs2qhKvt9UzIKMNaJpci5gnofT/QUQ=; b=HdXM65WVq2Cz+B7ywJP27VBcI23GIPSNuPhCtIUZN8Wx+NDCTikhbwSpMWPR7erNSUXcG+ eUdDIZlf6nXRzerZXwCh3klrmX9AK8Y8BhNHJQYCn+ZzvhbbdB4ICZ7q//uSuD8o7ls0DY YxGRs28EI+NQ7smxR7if6/uIJLYueLU= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-oEZfZQcgMm2eEktTjzvjHA-1; Tue, 11 Apr 2023 21:27:45 -0400 X-MC-Unique: oEZfZQcgMm2eEktTjzvjHA-1 Received: by mail-pj1-f71.google.com with SMTP id j19-20020a17090a841300b00246f53c6eecso460641pjn.1 for ; Tue, 11 Apr 2023 18:27:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681262864; x=1683854864; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=52dKt1oQ4xluuTs2qhKvt9UzIKMNaJpci5gnofT/QUQ=; b=HAdpB7b/J3tat4K8vzKmueljSShKJzBNRggBmZmyMEvajskiAEFJDJbuXGdHPDfIB7 GP5lNkw4+HxG/hYeVyoocwO8y2z8H0jMwaNSBLX09g9XyfGKYYykC66L8PUPGaMpuxzR L/dGGaZp36fjyN/AAA9Rw75qSFXMODujHLT66JkmAEK0azsxTyHPNLMUd2ULPo5rt5oD HqeF5OR1GFdp1rnopVPLjMZT2TY68XZwAEOIq/T0Dicf9FI7zO7UXLByZdRkLpTmRxE2 FVVCQL4iz9y/Tn+heG+irFhKpnxEnl7gxGRtAjDIznsXj22Z/iqEwC08x7Vbn6t12kRE KVvA== X-Gm-Message-State: AAQBX9f5dMj7lGBT/XF8iJXgxDagOTRfAjaV1mHadpznVs+umKcWEnKL cnIlwGwWb4ygXCuJGhYQXGsLHzV7T8ratwvbDS0n8TkAKBUQ/bJyLBXFNTmLw5fzi4edjECBEuH 6Ky0WSHY6DDktTjg4F4a0giXxHc4kkPA= X-Received: by 2002:a63:e10c:0:b0:503:7bbb:9a77 with SMTP id z12-20020a63e10c000000b005037bbb9a77mr3931615pgh.8.1681262864448; Tue, 11 Apr 2023 18:27:44 -0700 (PDT) X-Google-Smtp-Source: AKy350amKKQqYxnizq1pQSnUuatdL2oqpz9SIUgcIVlxq6CvBRBn3+mVReJSw7s426NSUFgVo9hSxAnXWokf+I9RUYQ= X-Received: by 2002:a63:e10c:0:b0:503:7bbb:9a77 with SMTP id z12-20020a63e10c000000b005037bbb9a77mr3931606pgh.8.1681262863996; Tue, 11 Apr 2023 18:27:43 -0700 (PDT) MIME-Version: 1.0 References: <20230328211119.2748442-1-jsnow@redhat.com> <20230328211119.2748442-4-jsnow@redhat.com> <88e77761-e9fe-d473-a4fa-c1d553bff4f3@redhat.com> In-Reply-To: From: John Snow Date: Tue, 11 Apr 2023 21:27:32 -0400 Message-ID: Subject: Re: [RFC PATCH 3/3] configure: install meson to a python virtual environment To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: Paolo Bonzini , qemu-devel , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Wainer dos Santos Moschetta , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Beraldo Leal , Thomas Huth , Cleber Rosa Content-Type: multipart/alternative; boundary="000000000000c8772e05f919835a" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --000000000000c8772e05f919835a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 29, 2023, 9:32 AM Daniel P. Berrang=C3=A9 wrote: > On Wed, Mar 29, 2023 at 03:27:53PM +0200, Paolo Bonzini wrote: > > On 3/29/23 14:53, Daniel P. Berrang=C3=A9 wrote: > > > I would love to see a day where configure isn't involved in the > > > build process. Obviously we can't put this new logic into > > > meson as its a chicken & egg problem. Could we potentially > > > have your new python/scripts/mkvenv.py script be responsible > > > for setting up meson in the venv though, so we can avoid > > > adding more shell code to configure ? > > > > Not sure this is the same thing a what you want, but I do have a > pipedream > > of rewriting configure in Python. At this point it has a lot more logi= c > > than it has command invocations. > > In a choice between 'shell configure' and 'python configure', I'll > take the python version, as it is a fundamentally better language to > be writing anything non-trivial in. My desire is to see the elimination > of as much shell code as possible. As a broad goal, python should be the > only scripting language we aim to use, in preference to shell or perl > or any equivalent. > I certainly prefer python to shell; I can try to move as much logic as I can into mkvenv. For this RFC I tried to "disrupt" as little as I could so it was easier to see the through-line and gain a sense for what exactly was changing. If there's an appetite for being bolder and more aggressive, we can certainly do that. I'm going to work out the kinks for the baseline functionality first, then we can apply the lipstick. Thanks, (And sorry for the hiatus again. I haven't been feeling well, please forgive my spotty attention.) --js > With regards, > Daniel > -- > |: https://berrange.com -o- > https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- > https://www.instagram.com/dberrange :| > > --000000000000c8772e05f919835a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 29, 2023, 9:32 AM Daniel = P. Berrang=C3=A9 <berrange@redhat.com> wrote:
On Wed, Mar 29, 2023 at 03:27:53PM +0200, Paolo Bonzini wrote:
> On 3/29/23 14:53, Daniel P. Berrang=C3=A9 wrote:
> > I would love to see a day where configure isn't involved in t= he
> > build process. Obviously we can't put this new logic into
> > meson as its a chicken & egg problem. Could we potentially > > have your new=C2=A0 python/scripts/mkvenv.py script be responsibl= e
> > for setting up meson in the venv though, so we can avoid
> > adding more shell code to configure ?
>
> Not sure this is the same thing a what you want, but I do have a piped= ream
> of rewriting configure in Python.=C2=A0 At this point it has a lot mor= e logic
> than it has command invocations.

In a choice between 'shell configure' and 'python configure'= ;, I'll
take the python version, as it is a fundamentally better language to
be writing anything non-trivial in. My desire is to see the elimination
of as much shell code as possible. As a broad goal, python should be the only scripting language we aim to use, in preference to shell or perl
or any equivalent.

=
I certainly prefer python to shell; I can try to move as = much logic as I can into mkvenv.

For this RFC I tried to "disrupt" as little as I could = so it was easier to see the through-line and gain a sense for what exactly = was changing. If there's an appetite for being bolder and more aggressi= ve, we can certainly do that. I'm going to work out the kinks for the b= aseline functionality first, then we can apply the lipstick.

Thanks,
(And sorry for the hiatus again.= I haven't been feeling well, please forgive my spotty attention.)

--js


With regards,
Daniel
--
|: https://berrange.com=C2=A0 =C2=A0 =C2=A0 -o-=C2=A0 =C2=A0 https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-o-=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 https://fstop138.berrange= .com :|
|: https://entangle-photo.org=C2=A0 =C2=A0 -o-=C2=A0 =C2=A0= https://www.instagram.com/dberrange :|

--000000000000c8772e05f919835a--