From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11F57C77B75 for ; Mon, 15 May 2023 21:15:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyfWd-0007YN-O9; Mon, 15 May 2023 17:14:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyfWb-0007Y8-Kt for qemu-devel@nongnu.org; Mon, 15 May 2023 17:14:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyfWa-0004NS-46 for qemu-devel@nongnu.org; Mon, 15 May 2023 17:14:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684185270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HdHnQybcSxHrUD+D7wdF13Kxj6juAgcy2F3yicFs6A=; b=KJ3wmgNM8JXmLsfIAz//tEHSpyie5lVUA0WBPOf6QBf2Bfutp6V3MGFnJQATGEpbFWJuwh 8D9vHFtjSW04cp3ivQSpzn6lGNmpSuj6BB6ELEuJv/2RMvPCEN8xEd0lSZKGGFIhNyLWWa 33EIbfLcZ4tjGLyb1q1suBV2K+ubTHs= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-rri_AjXgNA25mVJoJj9DUQ-1; Mon, 15 May 2023 17:14:29 -0400 X-MC-Unique: rri_AjXgNA25mVJoJj9DUQ-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-643a18db9efso7100774b3a.0 for ; Mon, 15 May 2023 14:14:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684185268; x=1686777268; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8HdHnQybcSxHrUD+D7wdF13Kxj6juAgcy2F3yicFs6A=; b=W/TNwtBu2GN4EvDH/jdgvvT6Q59RpV5F1gFP7/bzkPmqPsUXSggo1BVfDMcpqWr1Lf jrok57oGxPBX3Sgkc1LPPQTtIRNrvCW1GmaF2DYVE+abvaok3oLw7Jy2/9H+5P0gYMMv fXFI1z26hXTkqBRZhiG7BC60vPEQeb/hkbQqkSowI8MZyY37/Ll4WI5xxQN92me/GfbH i+ocf5JuAzE3UsRCJlLZ3Em/GspaM5PZnPfiX9XaQKLiSaED7HUZuqTWQF6HSaoWeYAC U3DpsvvVwiOIm6Q0VA4jHXkrILH5xEjSDqclnIUssceftLeTx4f88AE17LGN7241mmuI NLiQ== X-Gm-Message-State: AC+VfDy1mdygVy2CcdrU7W59x+dLpiPizU1zyGD7DItG+0H45a2Nh1BY qTaVcDwF1bzjkRZ04MuYnqWcG+wppWCLYl1spjKdE1aAY02IIjWGBVQqQPbGAlNqd6f6WXOMCeL RkSB/1To43T/BiFPo5ELjlDDo1jzlq1k= X-Received: by 2002:a05:6a00:1390:b0:646:3162:31a2 with SMTP id t16-20020a056a00139000b00646316231a2mr37365420pfg.17.1684185268605; Mon, 15 May 2023 14:14:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vFqKausuEC+c8OLrCofAOS+tM7/GOepsBqCi59RPxaKTUC1PixJjNoSJDVECV3uewytODaKqQP/Hac9RxLwU= X-Received: by 2002:a05:6a00:1390:b0:646:3162:31a2 with SMTP id t16-20020a056a00139000b00646316231a2mr37365385pfg.17.1684185268149; Mon, 15 May 2023 14:14:28 -0700 (PDT) MIME-Version: 1.0 References: <20230320105404.637661-1-berrange@redhat.com> <00341422-35d7-7091-5be4-808e1431f113@yandex-team.ru> In-Reply-To: From: John Snow Date: Mon, 15 May 2023 17:14:17 -0400 Message-ID: Subject: Re: [PATCH] python: honour message limit when using pre-opened socket To: Vladimir Sementsov-Ogievskiy Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org, Cleber Rosa , Beraldo Leal , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Mar 20, 2023 at 8:27=E2=80=AFPM John Snow wrote: > > On Mon, Mar 20, 2023 at 8:20=E2=80=AFAM Vladimir Sementsov-Ogievskiy > wrote: > > > > On 20.03.23 13:54, Daniel P. Berrang=C3=A9 wrote: > > > The default message recv limit in asyncio is smaller than our needs, = so > > > when opening connections we override it. This was done when opening a > > > connection using a socket address, but was missed when using a > > > pre-opened socket file descriptor. > > > > > > This latent bug was exposed when the QEMUMachine class was enhanced t= o > > > use socketpair() when no socket address was passed by: > > > > > > commit bd4c0ef409140bd1be393407c04005ac077d4574 > > > Author: Marc-Andr=C3=A9 Lureau > > > Date: Wed Jan 11 12:01:01 2023 +0400 > > > > > > python/qemu/machine: use socketpair() for QMP by default > > > > > > Signed-off-by: Daniel P. Berrang=C3=A9 > > > > Tested-by: Vladimir Sementsov-Ogievskiy > > > > Thanks! > > > > -- > > Best regards, > > Vladimir > > > > Thanks x3. Will stage in both places. > ... Realizing I let the two codebases diverge a bit more than I had meant to allow, and the "open with socket" rewrite I made never got brought back to qemu.git, tch. I believe this bug only exists in qemu.git because of that. I need to backport my changes to qemu.git and ensure that there isn't a problem with the revised code as it exists in qemu.qmp. I'll have to fix that *before* I drop qemu.qmp from the qemu.git repo, which I am hoping will be soon after Paolo takes the new Python patches that create a venv during configure time. --js