From: John Snow <jsnow@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Daniel Berrange" <berrange@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH 8/9] tests: add python3-venv to debian10.docker
Date: Tue, 31 May 2022 14:28:05 -0400 [thread overview]
Message-ID: <CAFn=p-bnd54uvF38Xqexi9T+P0CHo1seLYoBpwCi2V0e-unkSg@mail.gmail.com> (raw)
In-Reply-To: <3a0913d7-c148-2619-bdee-7f70b091a6a9@redhat.com>
On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 26/05/2022 02.09, John Snow wrote:
> > This is needed to be able to add a venv-building step to 'make check';
> > the clang-user job in particular needs this to be able to run
> > check-unit.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > tests/docker/dockerfiles/debian10.docker | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
> > index b414af1b9f7..03be9230664 100644
> > --- a/tests/docker/dockerfiles/debian10.docker
> > +++ b/tests/docker/dockerfiles/debian10.docker
> > @@ -34,4 +34,5 @@ RUN apt update && \
> > python3 \
> > python3-sphinx \
> > python3-sphinx-rtd-theme \
> > + python3-venv \
> > $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)
>
> Note that we'll (hopefully) drop the debian 10 container soon, since Debian
> 10 is EOL by the time we publish the next QEMU release.
>
Noted -- do you think it'd be OK to sneak this change in first and
have you move the requisite to the new container? :)
next prev parent reply other threads:[~2022-05-31 18:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 0:09 [PATCH 0/9] tests, python: prepare to expand usage of test venv John Snow
2022-05-26 0:09 ` [PATCH 1/9] python: update for mypy 0.950 John Snow
2022-05-26 0:09 ` [PATCH 2/9] tests: add "TESTS_PYTHON" variable to Makefile John Snow
2022-05-26 0:09 ` [PATCH 3/9] tests: use python3 as the python executable name John Snow
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 4/9] tests: silence pip upgrade warnings during venv creation John Snow
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 5/9] tests: add quiet-venv-pip macro John Snow
2022-05-26 12:15 ` Paolo Bonzini
2022-05-26 14:17 ` John Snow
2022-05-26 19:54 ` Paolo Bonzini
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 6/9] tests: install "qemu" namespace package into venv John Snow
2022-05-26 12:15 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 7/9] tests: use tests/venv to run basevm.py-based scripts John Snow
2022-05-26 0:09 ` [PATCH 8/9] tests: add python3-venv to debian10.docker John Snow
2022-05-26 12:14 ` Paolo Bonzini
2022-05-30 7:33 ` Thomas Huth
2022-05-31 18:28 ` John Snow [this message]
2022-06-01 7:29 ` Thomas Huth
2022-06-02 17:44 ` John Snow
2022-05-26 0:09 ` [PATCH 9/9] tests: run 'device-crash-test' from tests/venv John Snow
2022-05-26 12:14 ` Paolo Bonzini
2022-05-26 14:14 ` John Snow
2022-05-26 14:34 ` [PATCH 0/9] tests, python: prepare to expand usage of test venv John Snow
2022-06-01 10:06 ` Paolo Bonzini
2022-05-27 14:27 ` John Snow
2022-06-01 10:06 ` Paolo Bonzini
2022-06-02 17:43 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFn=p-bnd54uvF38Xqexi9T+P0CHo1seLYoBpwCi2V0e-unkSg@mail.gmail.com' \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).