From: Sam Eiderman <sameid@google.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
seabios@seabios.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct
Date: Wed, 13 Nov 2019 17:18:21 +0200 [thread overview]
Message-ID: <CAFr6bUk6gc0vCB5K=PJjd7Ahto7fb0TM+PYW78P0xER131b3NA@mail.gmail.com> (raw)
In-Reply-To: <CAFr6bUn5W2-w3z4Ty9XD7mh+=kxVq2rQJ3ZUz5nXA13ZdxQtsg@mail.gmail.com>
We should make sure drive.lchs is zeroed out for the following devices:
git grep "drive_s drive"
src/hw/ata.h: struct drive_s drive;
src/hw/esp-scsi.c: struct drive_s drive;
src/hw/lsi-scsi.c: struct drive_s drive;
src/hw/megasas.c: struct drive_s drive;
src/hw/mpt-scsi.c: struct drive_s drive;
src/hw/nvme-int.h: struct drive_s drive;
src/hw/pvscsi.c: struct drive_s drive;
src/hw/sdcard.c: struct drive_s drive;
src/hw/usb-msc.c: struct drive_s drive;
src/hw/usb-uas.c: struct drive_s drive;
src/hw/virtio-blk.c: struct drive_s drive;
src/hw/virtio-scsi.c: struct drive_s drive;
Sam
On Wed, Nov 13, 2019 at 5:03 PM Sam Eiderman <sameid@google.com> wrote:
>
> Hi,
>
> Does this fix a bug that actually happened?
>
> I just noticed that in my lchs patches I assumed that lchs struct is
> zeroed out in all devices (not only ahci):
>
> 9caa19be0e53 (geometry: Apply LCHS values for boot devices)
>
> Seems like this is not the case but why only ahci is affected?
>
> The list of devices is at least:
>
> * ata
> * ahci
> * scsi
> * esp
> * lsi
> * megasas
> * mpt
> * pvscsi
> * virtio
> * virtio-blk
>
> As specified in the commit message.
>
> Also Gerd it seems that my lchs patches were not committed in the
> latest submitted version (v4)!!!
> The ABI of the fw config key is completely broken.
>
>
> On Wed, Nov 13, 2019 at 4:02 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > On Wed, Nov 13, 2019 at 10:35:03AM +0100, Laszlo Ersek wrote:
> > > On 11/13/19 10:18, Gerd Hoffmann wrote:
> > > > Specifically port->driver.lchs needs clearing, otherwise seabios will
> > >
> > > s/driver/drive/
> >
> > > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >
> > Typo fixed & pushed.
> >
> > thanks,
> > Gerd
> > _______________________________________________
> > SeaBIOS mailing list -- seabios@seabios.org
> > To unsubscribe send an email to seabios-leave@seabios.org
next prev parent reply other threads:[~2019-11-13 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:18 [PATCH] ahci: zero-initialize port struct Gerd Hoffmann
2019-11-13 9:35 ` Laszlo Ersek
2019-11-13 14:00 ` [SeaBIOS] " Gerd Hoffmann
2019-11-13 15:03 ` Sam Eiderman
2019-11-13 15:18 ` Sam Eiderman [this message]
2019-11-13 15:46 ` Sam Eiderman
2019-11-13 16:12 ` Philippe Mathieu-Daudé
2019-11-13 16:35 ` Sam Eiderman
2019-11-13 16:46 ` Sam Eiderman
2019-11-14 7:20 ` Gerd Hoffmann
2019-11-14 9:08 ` Sam Eiderman
2019-11-15 6:54 ` Gerd Hoffmann
2019-11-15 11:35 ` Gerd Hoffmann
2019-11-15 11:50 ` Sam Eiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFr6bUk6gc0vCB5K=PJjd7Ahto7fb0TM+PYW78P0xER131b3NA@mail.gmail.com' \
--to=sameid@google.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).