From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@securiforest.com>) id 1T9ZXq-0006Sq-38
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:42:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@securiforest.com>) id 1T9ZXk-0003ga-Eg
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:42:46 -0400
Received: from vps146.softec-internet.com ([188.95.114.51]:40305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@securiforest.com>) id 1T9ZXk-0003gL-8G
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:42:40 -0400
Received: from vps146.softec-internet.com (unknown [127.0.0.1])
	by vps146.softec-internet.com (Postfix) with ESMTP id 5F13161C8005
	for <qemu-devel@nongnu.org>; Thu,  6 Sep 2012 12:42:37 +0200 (CEST)
Received: from mail-ob0-f173.google.com (unknown [209.85.214.173])
	by vps146.softec-internet.com (Postfix) with ESMTP
	for <qemu-devel@nongnu.org>; Thu,  6 Sep 2012 12:42:37 +0200 (CEST)
Received: by obbta14 with SMTP id ta14so1921802obb.4
	for <qemu-devel@nongnu.org>; Thu, 06 Sep 2012 03:42:35 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <504877D8.3030704@redhat.com>
References: <1346330948-12833-1-git-send-email-alex@securiforest.com>
	<50460275.2020506@redhat.com>
	<CAFwFPkz3ko8EBwajgFstX-HToWXqL3EXyoZ2gMqWweguMEZVDw@mail.gmail.com>
	<504877D8.3030704@redhat.com>
Date: Thu, 6 Sep 2012 12:42:35 +0200
Message-ID: <CAFwFPky9qKDGOMqcWOcqiUr7EMghv1vCLztLbgC3qYQFEwy3nQ@mail.gmail.com>
From: Alejandro Martinez <alex@securiforest.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to
 capability registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi Gerd,

On Thu, Sep 6, 2012 at 12:15 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
>> usb-next will fail to compile using -Werror with:
>> hcd-xhci.c: In function =91xhci_fire_ctl_transfer=92:
>> hcd-xhci.c:1508:14: error: variable =91wLength=92 set but not used
>> [-Werror=3Dunused-but-set-variable]
>
> Fixed.
>
> Which gcc is this?  Must be pretty cutting edge, even on Fedora 17 (gcc
> 4.7.0) I don't see that one ...

Actually it is from OpenSuSE's 12.1 rpm, at version 4.6.2.

>> It will also crash at runtime at
>> host-linux.c:usb_handle_control_packet(), since a NULL value is passed
>> from xhci_address_slot() for the USBPacket *p argument, and an assert
>> is testing for p->result =3D=3D 0.
>
> Fixed & pushed to usb-next.

Thanks, will try it out.

Thanks,
  Alex